From patchwork Fri Jan 7 05:37:23 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luiz Angelo Daros de Luca X-Patchwork-Id: 1576479 X-Patchwork-Delegate: ynezz@true.cz Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=rAd6mvco; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=YaGQ8nsK; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4JVXPY4sTyz9t2p for ; Fri, 7 Jan 2022 16:50:25 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VVjHI+gNs9E223uUrhQXRODBTqKu3am6te22okXI6LI=; b=rAd6mvco9CcYOx KMJwwg1AgDR2dst83zVJ34EH2wSETTqTHHbSXEUcQqlVj/yzsSoXdwR9QGqBkMZ6SLBvJTazo3jru xNDZ/AVKXKjIlxqawD5DExXYZIZkW4EUvu1pU0Kija2ZKDmvKlkm2WoQT7h8k9ArTlZae43HDOLCC tTk9aTKIbYByp6ZKgdVfyzJgfqYDRVsSw9TuLzDzi4Jy8BwWlymUmLR18lDOMED7xq9klqEYnpZpC qNMCsFalu89AKw9YLCDJPrTwLzHmFmfHLFbqG6LViK4yRzhCmO66eeatVtmM4mYh38Fd8+Ua3ePNF 6BQce/M+ZBjsJvh8wkTw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n5i5t-002UOt-Ex; Fri, 07 Jan 2022 05:47:17 +0000 Received: from mail-ua1-x92e.google.com ([2607:f8b0:4864:20::92e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n5hwY-002Qt2-1I for openwrt-devel@lists.openwrt.org; Fri, 07 Jan 2022 05:37:39 +0000 Received: by mail-ua1-x92e.google.com with SMTP id p1so8370553uap.9 for ; Thu, 06 Jan 2022 21:37:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kLkKcxb0innUtlIXH+ZHsQhXGGpN+2iBYMcsnv0XdAI=; b=YaGQ8nsKtWCfHGSTrNTGsQkEd5qKPmin8LDAjq/S7TQOq4Jf0O6OSGQt/CIvruLzpd BaW5F93QiDuZGLJlHyPGV4urKUCNYX3GHsPU13hJknFmC7U/cJ/lg1Vd9yystvnZIH2S +dPLFqJ0jMxu4TOBxMIdJOxFVxu4qQH0j/chYEdPGKEYRvVTmYWLsYH8Xc5KbIf9kPLm 45hwf1JVQoQI3Tk1DCRsOMPRFEKtCxWdCFLAo6AVJ/aacTaPtdy7yJ2E0Ds9F89+/289 NCRWAd9fh/OIB8M+lbq+FcQkmJrRBFM3GhSICdP2+uZVlpbfGf6gla0CsButP3d74AKU cXZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kLkKcxb0innUtlIXH+ZHsQhXGGpN+2iBYMcsnv0XdAI=; b=HbJlx7+Keg52iNR0k/Up3MNLVXMDxOU2Fn3iD1sqqusIzdCuK4/a2ZaPZHN60tueo5 8GqAT6GXNWOgXSKCJwLzAKRNhoc4r5vyat07Z6omM+ytgXeNzIbOrFy3uRDIcFkTpbv+ TBq16MXe3dN9NGb1N5XR69U2X4OEYAmus4CKDqPhaWey+RbqvGKzuehYjVxpRIh9XSOA UAElCX91bFnqiyPdGq/x0KALY97+U/0OXyhiO/ZW6jAUQv3+WyoIqimKacXJgmljJp/g q1lV45C4sLnT07WSTL1jdP2c5RJpUe4Be7E/mtLh1SzTDgF7rA4gWuW7lJEN3U07IIS3 pKgQ== X-Gm-Message-State: AOAM5302H04cHdwafyCObd7Tmk8rul4RS9UsmtsrbiVYGOr8eP0709lD oL60Xb9ju+y6Wklgb3Z7Oel0f1SxnCA= X-Google-Smtp-Source: ABdhPJxP49rqCe2Ocu8p1aTIXfhKW+SoThxAkcLVZIR1gGRqzlwv8BxUyIXqNSmna8I1n8aRK+ko0A== X-Received: by 2002:ab0:5381:: with SMTP id k1mr12643194uaa.17.1641533856976; Thu, 06 Jan 2022 21:37:36 -0800 (PST) Received: from tresc043793.tre-sc.gov.br (187-049-235-234.floripa.net.br. [187.49.235.234]) by smtp.gmail.com with ESMTPSA id g139sm2724096vke.17.2022.01.06.21.37.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jan 2022 21:37:36 -0800 (PST) From: Luiz Angelo Daros de Luca To: openwrt-devel@lists.openwrt.org Cc: Luiz Angelo Daros de Luca Subject: [PATCH 3/3] ramips: ethernet: ralink: mtu change while interface is down Date: Fri, 7 Jan 2022 02:37:23 -0300 Message-Id: <20220107053723.21341-3-luizluca@gmail.com> X-Mailer: git-send-email 2.34.0 In-Reply-To: <20220107053723.21341-1-luizluca@gmail.com> References: <20220107053723.21341-1-luizluca@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220106_213738_119966_1A2D6CDE X-CRM114-Status: GOOD ( 11.30 ) X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: fe_change_mtu didn't update the registers if the interface was down. DSA increases the CPU port MTU to accommodate the CPU tag. As this happens while the CPU port was still down, the chip regs didn't get updated and larger frames were dropped. Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:92e listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [luizluca[at]gmail.com] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org fe_change_mtu didn't update the registers if the interface was down. DSA increases the CPU port MTU to accommodate the CPU tag. As this happens while the CPU port was still down, the chip regs didn't get updated and larger frames were dropped. Signed-off-by: Luiz Angelo Daros de Luca --- .../files/drivers/net/ethernet/ralink/mtk_eth_soc.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/target/linux/ramips/files/drivers/net/ethernet/ralink/mtk_eth_soc.c b/target/linux/ramips/files/drivers/net/ethernet/ralink/mtk_eth_soc.c index be2ee6ba7f..0ae520183b 100644 --- a/target/linux/ramips/files/drivers/net/ethernet/ralink/mtk_eth_soc.c +++ b/target/linux/ramips/files/drivers/net/ethernet/ralink/mtk_eth_soc.c @@ -1484,10 +1484,9 @@ static int fe_change_mtu(struct net_device *dev, int new_mtu) priv->rx_ring.frag_size = PAGE_SIZE; priv->rx_ring.rx_buf_size = fe_max_buf_size(priv->rx_ring.frag_size); - if (!netif_running(dev)) - return 0; + if (netif_running(dev)) + fe_stop(dev); - fe_stop(dev); if (!IS_ENABLED(CONFIG_SOC_MT7621)) { fwd_cfg = fe_r32(fwd_reg); if (new_mtu <= ETH_DATA_LEN) { @@ -1501,7 +1500,10 @@ static int fe_change_mtu(struct net_device *dev, int new_mtu) fe_w32(fwd_cfg, fwd_reg); } - return fe_open(dev); + if (netif_running(dev)) + return fe_open(dev); + + return 0; } static const struct net_device_ops fe_netdev_ops = {