diff mbox series

[OpenWrt-Devel] iproute2: m_xt.so depends on dynsyms.list

Message ID 20210902232814.132726-1-roman@advem.lv
State Superseded
Headers show
Series [OpenWrt-Devel] iproute2: m_xt.so depends on dynsyms.list | expand

Commit Message

Roman Yeryomin Sept. 2, 2021, 11:28 p.m. UTC
When doing parallel build on a fast machine with bottleneck in i/o,
m_xt.so may start linking faster than dynsyms.list gets populated,
resulting in error:

ld:dynsyms.list:0: syntax error in dynamic list

Fix this by adding dynsyms.list as make dependency to m_xt.so
Described also here:
https://bugs.openwrt.org/index.php?do=details&task_id=3353

Signed-off-by: Roman Yeryomin <roman@advem.lv>
Fixes: FS#3353
---
 .../utils/iproute2/patches/175-reduce-dynamic-syms.patch    | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Roman Yeryomin Sept. 3, 2021, 8:49 a.m. UTC | #1
On 2021-09-03 02:28, Roman Yeryomin wrote:
> When doing parallel build on a fast machine with bottleneck in i/o,
> m_xt.so may start linking faster than dynsyms.list gets populated,
> resulting in error:
> 
> ld:dynsyms.list:0: syntax error in dynamic list
> 
> Fix this by adding dynsyms.list as make dependency to m_xt.so
> Described also here:
> https://bugs.openwrt.org/index.php?do=details&task_id=3353
> 
> Signed-off-by: Roman Yeryomin <roman@advem.lv>
> Fixes: FS#3353
> ---

Please discard this. Making m_xt.so dependant on dynsyms.list 
unconditionally was bad idea.
Will re-send proper version.

Regards,
Roman
diff mbox series

Patch

diff --git a/package/network/utils/iproute2/patches/175-reduce-dynamic-syms.patch b/package/network/utils/iproute2/patches/175-reduce-dynamic-syms.patch
index da961a183b..aa98c97549 100644
--- a/package/network/utils/iproute2/patches/175-reduce-dynamic-syms.patch
+++ b/package/network/utils/iproute2/patches/175-reduce-dynamic-syms.patch
@@ -26,6 +26,12 @@ 
  
  q_atm.so: q_atm.c
  	$(QUIET_CC)$(CC) $(CFLAGS) $(CPPFLAGS) $(LDFLAGS) -shared -fpic -o q_atm.so q_atm.c -latm
+ 
+-m_xt.so: m_xt.c
++m_xt.so: m_xt.c dynsyms.list
+ 	$(QUIET_CC)$(CC) $(CFLAGS) $(CPPFLAGS) $(LDFLAGS) -shared -fpic -o m_xt.so m_xt.c $$($(PKG_CONFIG) xtables --cflags --libs)
+ 
+ m_xt_old.so: m_xt_old.c
 @@ -205,4 +206,15 @@ static-syms.h: $(wildcard *.c)
  		sed -n '/'$$s'[^ ]* =/{s:.* \([^ ]*'$$s'[^ ]*\) .*:extern char \1[] __attribute__((weak)); if (!strcmp(sym, "\1")) return \1;:;p}' $$files ; \
  	done > $@