diff mbox series

[1/2] zram-swap: clean up the makefile

Message ID 20210331130959.653229-2-rsalvaterra@gmail.com
State Superseded
Headers show
Series zram-swap improvements | expand

Commit Message

Rui Salvaterra March 31, 2021, 1:09 p.m. UTC
Break dependencies into separate lines, to improve the readability. Trim
trailing whitespace.

Signed-off-by: Rui Salvaterra <rsalvaterra@gmail.com>
---
 package/system/zram-swap/Makefile | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

Comments

Stijn Tintel March 31, 2021, 9:06 p.m. UTC | #1
On 31/03/2021 16:09, Rui Salvaterra wrote:
> Break dependencies into separate lines, to improve the readability. Trim
> trailing whitespace.
>
> Signed-off-by: Rui Salvaterra <rsalvaterra@gmail.com>
> ---
>  package/system/zram-swap/Makefile | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/package/system/zram-swap/Makefile b/package/system/zram-swap/Makefile
> index 18c6afee96..96cdcdc5ee 100644
> --- a/package/system/zram-swap/Makefile
> +++ b/package/system/zram-swap/Makefile
> @@ -17,14 +17,20 @@ include $(INCLUDE_DIR)/package.mk
>  define Package/zram-swap
>    SECTION:=utils
>    CATEGORY:=Base system
> -  DEPENDS:=+kmod-zram +@BUSYBOX_CONFIG_MKSWAP +@BUSYBOX_CONFIG_SWAPON +@BUSYBOX_CONFIG_FEATURE_SWAPON_DISCARD +@BUSYBOX_CONFIG_FEATURE_SWAPON_PRI +@BUSYBOX_CONFIG_SWAPOFF
> +  DEPENDS:= \
> +	+kmod-zram \
> +	+@BUSYBOX_CONFIG_MKSWAP \
> +	+@BUSYBOX_CONFIG_SWAPON \
> +	+@BUSYBOX_CONFIG_FEATURE_SWAPON_DISCARD \
> +	+@BUSYBOX_CONFIG_FEATURE_SWAPON_PRI \
> +	+@BUSYBOX_CONFIG_SWAPOFF
Please put them in alphabetical order.
>    TITLE:=ZRAM swap scripts
>    PKGARCH:=all
>  endef
>  
>  define Package/zram-swap/description
> - A script to activate swaping on a compressed zram partition. This 
> - could be used to increase the available memory, by using compressed 
> + A script to activate swaping on a compressed zram partition. This
> + could be used to increase the available memory, by using compressed
>   memory.
>  endef
>  

Stijn
Rui Salvaterra April 1, 2021, 11:39 a.m. UTC | #2
Hi, Stijn,

On Wed, 31 Mar 2021 at 22:06, Stijn Tintel <stijn@linux-ipv6.be> wrote:
>
[snip]
> Please put them in alphabetical order.

I kept the same order (left to right, top to bottom), but my OCD
agrees with you. Will fix. :)

Thanks,
Rui
Alberto Bursi April 3, 2021, 9:37 p.m. UTC | #3
A few days ago, Louis Rossmann, a relatively famous person in the 
electronics repair community has started a fundraiser to get the Right 
to Repair movement's goals passed into law though a "direct ballot 
initiative" in the USA.  It's a way to create a law that is bypassing 
politicians and asking directly to the citizens decide if they want it 
or not with their vote in a referendum.

This is at least partially relevant for OpenWrt and I think it's 
interesting for many in our community.
Right to Repair involves outlawing software restrictions that lock down 
devices to prevent independent repair or modification of the devices you 
have bought (and own).
It also involves requiring that devices are designed to be 
serviced/repaired, and making technical documentation/parts available.

While Louis is in the USA, such laws would have an effect in the rest of 
the western world as well.

He has been lobbying for Right to Repair with US politicians for many 
years without much success, while also owning and growing an electronic 
board repair businness.

Most of what he did and does, and also the board repair he teaches, can 
be found in is in his youtube channel, 
https://www.youtube.com/channel/UCl2mFZoRqjw_ELax4Yisf6w

The video where he summarizes his story and more information about the 
crowfunding and its goals are here 
https://www.youtube.com/watch?v=dWIF3ZRpf0I

In case anyone wants to donate to the cause, the crowdfunding page is here.

https://www.gofundme.com/f/lets-get-right-to-repair-passed


-Alberto
Torbjörn Jansson April 4, 2021, 5:57 a.m. UTC | #4
On 2021-04-03 23:37, Alberto Bursi wrote:
> A few days ago, Louis Rossmann, a relatively famous person in the electronics 
> repair community has started a fundraiser to get the Right to Repair movement's 
> goals passed into law though a "direct ballot initiative" in the USA.  It's a 
> way to create a law that is bypassing politicians and asking directly to the 
> citizens decide if they want it or not with their vote in a referendum.
> 
> This is at least partially relevant for OpenWrt and I think it's interesting 
> for many in our community.
> Right to Repair involves outlawing software restrictions that lock down devices 
> to prevent independent repair or modification of the devices you have bought 
> (and own).
> It also involves requiring that devices are designed to be serviced/repaired, 
> and making technical documentation/parts available.
> 
> While Louis is in the USA, such laws would have an effect in the rest of the 
> western world as well.
> 
> He has been lobbying for Right to Repair with US politicians for many years 
> without much success, while also owning and growing an electronic board repair 
> businness.
> 
> Most of what he did and does, and also the board repair he teaches, can be 
> found in is in his youtube channel, 
> https://www.youtube.com/channel/UCl2mFZoRqjw_ELax4Yisf6w
> 
> The video where he summarizes his story and more information about the 
> crowfunding and its goals are here https://www.youtube.com/watch?v=dWIF3ZRpf0I
> 
> In case anyone wants to donate to the cause, the crowdfunding page is here.
> 
> https://www.gofundme.com/f/lets-get-right-to-repair-passed
> 
> 
> -Alberto
> 

why did you put this mail in the thread for "zram-swap: clean up the makefile"?
Mauro Mozzarelli April 5, 2021, 11:15 a.m. UTC | #5
Just to clarify: 'Right to Repair' is already a law in the European Union. It is beginning to be enforced from 2021 and it will go through further evolution steps.

On 03/04/2021, 22:40, "openwrt-devel on behalf of Alberto Bursi" <openwrt-devel-bounces@lists.openwrt.org on behalf of bobafetthotmail@gmail.com> wrote:

    A few days ago, Louis Rossmann, a relatively famous person in the 
    electronics repair community has started a fundraiser to get the Right 
    to Repair movement's goals passed into law though a "direct ballot 
    initiative" in the USA.  It's a way to create a law that is bypassing 
    politicians and asking directly to the citizens decide if they want it 
    or not with their vote in a referendum.

    This is at least partially relevant for OpenWrt and I think it's 
    interesting for many in our community.
    Right to Repair involves outlawing software restrictions that lock down 
    devices to prevent independent repair or modification of the devices you 
    have bought (and own).
    It also involves requiring that devices are designed to be 
    serviced/repaired, and making technical documentation/parts available.

    While Louis is in the USA, such laws would have an effect in the rest of 
    the western world as well.

    He has been lobbying for Right to Repair with US politicians for many 
    years without much success, while also owning and growing an electronic 
    board repair businness.

    Most of what he did and does, and also the board repair he teaches, can 
    be found in is in his youtube channel, 
    https://www.youtube.com/channel/UCl2mFZoRqjw_ELax4Yisf6w

    The video where he summarizes his story and more information about the 
    crowfunding and its goals are here 
    https://www.youtube.com/watch?v=dWIF3ZRpf0I

    In case anyone wants to donate to the cause, the crowdfunding page is here.

    https://www.gofundme.com/f/lets-get-right-to-repair-passed


    -Alberto

    _______________________________________________
    openwrt-devel mailing list
    openwrt-devel@lists.openwrt.org
    https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Alberto Bursi April 6, 2021, 12:22 a.m. UTC | #6
What is "beginning to be enforced" from 2021? They barely approved a 
generic list of intents and a promise to do something about it by 2030.
What is in the list is still very vague and easy to abuse. It's going to 
take a few years to see anything resembling a law come from that.

Don't get me wrong, it's still better than the US where the whole "Right 
to Repair" movement isn't even taken seriously, but it's still not 
anywhere near the "enforcment" part.
See for example the breakdown of what was done, from the EU-based Right 
to Repair movement website 
https://repair.eu/news/new-ecodesign-regulations-5-reasons-europe-still-doesnt-have-the-right-to-repair/

-Alberto

On 05/04/21 13:15, Mauro Mozzarelli wrote:
> Just to clarify: 'Right to Repair' is already a law in the European Union. It is beginning to be enforced from 2021 and it will go through further evolution steps.
> 
> On 03/04/2021, 22:40, "openwrt-devel on behalf of Alberto Bursi" <openwrt-devel-bounces@lists.openwrt.org on behalf of bobafetthotmail@gmail.com> wrote:
> 
>      A few days ago, Louis Rossmann, a relatively famous person in the
>      electronics repair community has started a fundraiser to get the Right
>      to Repair movement's goals passed into law though a "direct ballot
>      initiative" in the USA.  It's a way to create a law that is bypassing
>      politicians and asking directly to the citizens decide if they want it
>      or not with their vote in a referendum.
> 
>      This is at least partially relevant for OpenWrt and I think it's
>      interesting for many in our community.
>      Right to Repair involves outlawing software restrictions that lock down
>      devices to prevent independent repair or modification of the devices you
>      have bought (and own).
>      It also involves requiring that devices are designed to be
>      serviced/repaired, and making technical documentation/parts available.
> 
>      While Louis is in the USA, such laws would have an effect in the rest of
>      the western world as well.
> 
>      He has been lobbying for Right to Repair with US politicians for many
>      years without much success, while also owning and growing an electronic
>      board repair businness.
> 
>      Most of what he did and does, and also the board repair he teaches, can
>      be found in is in his youtube channel,
>      https://www.youtube.com/channel/UCl2mFZoRqjw_ELax4Yisf6w
> 
>      The video where he summarizes his story and more information about the
>      crowfunding and its goals are here
>      https://www.youtube.com/watch?v=dWIF3ZRpf0I
> 
>      In case anyone wants to donate to the cause, the crowdfunding page is here.
> 
>      https://www.gofundme.com/f/lets-get-right-to-repair-passed
> 
> 
>      -Alberto
> 
>      _______________________________________________
>      openwrt-devel mailing list
>      openwrt-devel@lists.openwrt.org
>      https://lists.openwrt.org/mailman/listinfo/openwrt-devel
> 
> 
>
Petr Štetiar April 6, 2021, 8:18 a.m. UTC | #7
Alberto Bursi <bobafetthotmail@gmail.com> [2021-04-06 02:22:07]:

Hi,

[adding openwrt-adm to Cc:]

> This is at least partially relevant for OpenWrt and I think it's interesting
> for many in our community. 

I agree.

What about little bit improved promotion of both EU/US efforts, for example
official front page endorsement on openwrt.org, openwrt-announce mail and
pinned forum topic (14-30 days)?

Alberto would you be willing to help preparing text for this official project
endorsement? I assume, that if nobody rejects this idea, then it probably
should be OK to proceed next Monday, April 12th.

Cheers,

Petr
John Crispin April 6, 2021, 9:08 a.m. UTC | #8
context ?

     John

On 06.04.21 10:18, Petr Štetiar wrote:
> Alberto Bursi <bobafetthotmail@gmail.com> [2021-04-06 02:22:07]:
>
> Hi,
>
> [adding openwrt-adm to Cc:]
>
>> This is at least partially relevant for OpenWrt and I think it's interesting
>> for many in our community.
> I agree.
>
> What about little bit improved promotion of both EU/US efforts, for example
> official front page endorsement on openwrt.org, openwrt-announce mail and
> pinned forum topic (14-30 days)?
>
> Alberto would you be willing to help preparing text for this official project
> endorsement? I assume, that if nobody rejects this idea, then it probably
> should be OK to proceed next Monday, April 12th.
>
> Cheers,
>
> Petr
>
> _______________________________________________
> openwrt-adm mailing list
> openwrt-adm@lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-adm
Petr Štetiar April 6, 2021, 10:51 a.m. UTC | #9
John Crispin <john@phrozen.org> [2021-04-06 11:08:41]:

> context ?

https://lists.infradead.org/pipermail/openwrt-devel/2021-April/034537.html
diff mbox series

Patch

diff --git a/package/system/zram-swap/Makefile b/package/system/zram-swap/Makefile
index 18c6afee96..96cdcdc5ee 100644
--- a/package/system/zram-swap/Makefile
+++ b/package/system/zram-swap/Makefile
@@ -17,14 +17,20 @@  include $(INCLUDE_DIR)/package.mk
 define Package/zram-swap
   SECTION:=utils
   CATEGORY:=Base system
-  DEPENDS:=+kmod-zram +@BUSYBOX_CONFIG_MKSWAP +@BUSYBOX_CONFIG_SWAPON +@BUSYBOX_CONFIG_FEATURE_SWAPON_DISCARD +@BUSYBOX_CONFIG_FEATURE_SWAPON_PRI +@BUSYBOX_CONFIG_SWAPOFF
+  DEPENDS:= \
+	+kmod-zram \
+	+@BUSYBOX_CONFIG_MKSWAP \
+	+@BUSYBOX_CONFIG_SWAPON \
+	+@BUSYBOX_CONFIG_FEATURE_SWAPON_DISCARD \
+	+@BUSYBOX_CONFIG_FEATURE_SWAPON_PRI \
+	+@BUSYBOX_CONFIG_SWAPOFF
   TITLE:=ZRAM swap scripts
   PKGARCH:=all
 endef
 
 define Package/zram-swap/description
- A script to activate swaping on a compressed zram partition. This 
- could be used to increase the available memory, by using compressed 
+ A script to activate swaping on a compressed zram partition. This
+ could be used to increase the available memory, by using compressed
  memory.
 endef