| Message ID | 20210216093059.25266-1-ynezz@true.cz |
|---|---|
| State | Not Applicable |
| Delegated to: | Petr Štetiar |
| Headers | show |
| Series | [21.02] feeds: freifunk: use mirror from openwrt.org | expand |
Hi, > -----Original Message----- > From: openwrt-devel [mailto:openwrt-devel-bounces@lists.openwrt.org] > On Behalf Of Petr Štetiar > Sent: Dienstag, 16. Februar 2021 10:31 > To: openwrt-devel@lists.openwrt.org > Cc: Petr Štetiar <ynezz@true.cz> > Subject: [PATCH 21.02] feeds: freifunk: use mirror from openwrt.org > > We shouldn't rely on GitHub for anything serious for obvious reasons. > > References: > https://github.com/openwrt/openwrt/pull/3701#issuecomment-770841946 > Signed-off-by: Petr Štetiar <ynezz@true.cz> > --- > > We've recently got following notice from GitHub: > > "If we determine that a violation has occurred, we may need to disable the > repository" > > BTW I find it quite weird, that we're using feed from external project and we > don't have access there. This is for example issue now, where we wanted to > prepare 21.02 release, but we can't even create branch in that feed > repository, which is blocking builds[1]: > > Updating feed 'freifunk' from 'https://github.com/freifunk/openwrt- > packages.git;openwrt-21.02' ... > ... > fatal: Remote branch openwrt-21.02 not found in upstream origin > > 1. http://buildbot.openwrt.org/openwrt- > 21.02/images/builders/imx6%2Fgeneric/builds/1/steps/updatefeeds/logs/st > dio In the discussion about adding this feed, there was only a very weak tendency for the addition (I added it to master then): https://github.com/openwrt/openwrt/pull/3013 If this creates non-trivial problems/holdup or the maintainers are not interested in moving, I think making the feed optional or removing it again is the better option. Added Sven to the recipients. Best Adrian > > feeds.conf.default | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/feeds.conf.default b/feeds.conf.default index > 03bfacb620fd..7aa07a8916c1 100644 > --- a/feeds.conf.default > +++ b/feeds.conf.default > @@ -2,7 +2,7 @@ src-git packages > https://git.openwrt.org/feed/packages.git > src-git luci https://git.openwrt.org/project/luci.git > src-git routing https://git.openwrt.org/feed/routing.git > src-git telephony https://git.openwrt.org/feed/telephony.git > -src-git freifunk https://github.com/freifunk/openwrt-packages.git > +src-git freifunk https://git.openwrt.org/feed/freifunk.git > #src-git video https://github.com/openwrt/video.git > #src-git targets https://github.com/openwrt/targets.git > #src-git management https://github.com/openwrt- > management/packages.git > > _______________________________________________ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Hi, There is an issue on the freifunk repo exactly about this topic. https://github.com/freifunk/openwrt-packages/issues/37 Greets, Perry On 2/16/21 1:54 PM, Adrian Schmutzler wrote: > Hi, > >> -----Original Message----- >> From: openwrt-devel [mailto:openwrt-devel-bounces@lists.openwrt.org] >> On Behalf Of Petr Štetiar >> Sent: Dienstag, 16. Februar 2021 10:31 >> To: openwrt-devel@lists.openwrt.org >> Cc: Petr Štetiar <ynezz@true.cz> >> Subject: [PATCH 21.02] feeds: freifunk: use mirror from openwrt.org >> >> We shouldn't rely on GitHub for anything serious for obvious reasons. >> >> References: >> https://github.com/openwrt/openwrt/pull/3701#issuecomment-770841946 >> Signed-off-by: Petr Štetiar <ynezz@true.cz> >> --- >> >> We've recently got following notice from GitHub: >> >> "If we determine that a violation has occurred, we may need to disable the >> repository" >> >> BTW I find it quite weird, that we're using feed from external project and we >> don't have access there. This is for example issue now, where we wanted to >> prepare 21.02 release, but we can't even create branch in that feed >> repository, which is blocking builds[1]: >> >> Updating feed 'freifunk' from 'https://github.com/freifunk/openwrt- >> packages.git;openwrt-21.02' ... >> ... >> fatal: Remote branch openwrt-21.02 not found in upstream origin >> >> 1. http://buildbot.openwrt.org/openwrt- >> 21.02/images/builders/imx6%2Fgeneric/builds/1/steps/updatefeeds/logs/st >> dio > > In the discussion about adding this feed, there was only a very weak tendency for the addition (I added it to master then): > > https://github.com/openwrt/openwrt/pull/3013 > > If this creates non-trivial problems/holdup or the maintainers are not interested in moving, I think making the feed optional or removing it again is the better option. > > Added Sven to the recipients. > > Best > > Adrian > >> >> feeds.conf.default | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/feeds.conf.default b/feeds.conf.default index >> 03bfacb620fd..7aa07a8916c1 100644 >> --- a/feeds.conf.default >> +++ b/feeds.conf.default >> @@ -2,7 +2,7 @@ src-git packages >> https://git.openwrt.org/feed/packages.git >> src-git luci https://git.openwrt.org/project/luci.git >> src-git routing https://git.openwrt.org/feed/routing.git >> src-git telephony https://git.openwrt.org/feed/telephony.git >> -src-git freifunk https://github.com/freifunk/openwrt-packages.git >> +src-git freifunk https://git.openwrt.org/feed/freifunk.git >> #src-git video https://github.com/openwrt/video.git >> #src-git targets https://github.com/openwrt/targets.git >> #src-git management https://github.com/openwrt- >> management/packages.git >> >> _______________________________________________ >> openwrt-devel mailing list >> openwrt-devel@lists.openwrt.org >> https://lists.openwrt.org/mailman/listinfo/openwrt-devel > > > _______________________________________________ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/mailman/listinfo/openwrt-devel >
Hi, I have submitted two PR's to remove the freifunk feed from master and openwrt-21.02. https://github.com/openwrt/openwrt/pull/3900 https://github.com/openwrt/openwrt/pull/3901 The reasons for removing the feeds, outside of this email thread, can be read at https://github.com/freifunk/openwrt-packages/issues/37 Greetings, Perry On 2/16/21 1:54 PM, Adrian Schmutzler wrote: > Hi, > >> -----Original Message----- >> From: openwrt-devel [mailto:openwrt-devel-bounces@lists.openwrt.org] >> On Behalf Of Petr Štetiar >> Sent: Dienstag, 16. Februar 2021 10:31 >> To: openwrt-devel@lists.openwrt.org >> Cc: Petr Štetiar <ynezz@true.cz> >> Subject: [PATCH 21.02] feeds: freifunk: use mirror from openwrt.org >> >> We shouldn't rely on GitHub for anything serious for obvious reasons. >> >> References: >> https://github.com/openwrt/openwrt/pull/3701#issuecomment-770841946 >> Signed-off-by: Petr Štetiar <ynezz@true.cz> >> --- >> >> We've recently got following notice from GitHub: >> >> "If we determine that a violation has occurred, we may need to disable the >> repository" >> >> BTW I find it quite weird, that we're using feed from external project and we >> don't have access there. This is for example issue now, where we wanted to >> prepare 21.02 release, but we can't even create branch in that feed >> repository, which is blocking builds[1]: >> >> Updating feed 'freifunk' from 'https://github.com/freifunk/openwrt- >> packages.git;openwrt-21.02' ... >> ... >> fatal: Remote branch openwrt-21.02 not found in upstream origin >> >> 1. http://buildbot.openwrt.org/openwrt- >> 21.02/images/builders/imx6%2Fgeneric/builds/1/steps/updatefeeds/logs/st >> dio > > In the discussion about adding this feed, there was only a very weak tendency for the addition (I added it to master then): > > https://github.com/openwrt/openwrt/pull/3013 > > If this creates non-trivial problems/holdup or the maintainers are not interested in moving, I think making the feed optional or removing it again is the better option. > > Added Sven to the recipients. > > Best > > Adrian > >> >> feeds.conf.default | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/feeds.conf.default b/feeds.conf.default index >> 03bfacb620fd..7aa07a8916c1 100644 >> --- a/feeds.conf.default >> +++ b/feeds.conf.default >> @@ -2,7 +2,7 @@ src-git packages >> https://git.openwrt.org/feed/packages.git >> src-git luci https://git.openwrt.org/project/luci.git >> src-git routing https://git.openwrt.org/feed/routing.git >> src-git telephony https://git.openwrt.org/feed/telephony.git >> -src-git freifunk https://github.com/freifunk/openwrt-packages.git >> +src-git freifunk https://git.openwrt.org/feed/freifunk.git >> #src-git video https://github.com/openwrt/video.git >> #src-git targets https://github.com/openwrt/targets.git >> #src-git management https://github.com/openwrt- >> management/packages.git >> >> _______________________________________________ >> openwrt-devel mailing list >> openwrt-devel@lists.openwrt.org >> https://lists.openwrt.org/mailman/listinfo/openwrt-devel > > > _______________________________________________ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/mailman/listinfo/openwrt-devel >
Perry <isprotejesvalkata@gmail.com> [2021-02-21 14:13:15]: Hi, > I have submitted two PR's to remove the freifunk feed from master and > openwrt-21.02. thank you for the heads up, I'm just wondering why we should left openwrt-19.07[1] behind? 1. https://git.openwrt.org/2a3dbded93775aeaf28fbebbd6aada07c9f588c1 Cheers, Petr
Am Sonntag, 21. Februar 2021, 20:13:40 CEST schrieb Petr Štetiar: Hi, > > > I have submitted two PR's to remove the freifunk feed from master and > > openwrt-21.02. > > thank you for the heads up, I'm just wondering why we should left > openwrt-19.07[1] behind? > > 1. https://git.openwrt.org/2a3dbded93775aeaf28fbebbd6aada07c9f588c1 > probably as removing inside a release-branch without real need has the potential to cause more trouble than we will gain. Sven
diff --git a/feeds.conf.default b/feeds.conf.default index 03bfacb620fd..7aa07a8916c1 100644 --- a/feeds.conf.default +++ b/feeds.conf.default @@ -2,7 +2,7 @@ src-git packages https://git.openwrt.org/feed/packages.git src-git luci https://git.openwrt.org/project/luci.git src-git routing https://git.openwrt.org/feed/routing.git src-git telephony https://git.openwrt.org/feed/telephony.git -src-git freifunk https://github.com/freifunk/openwrt-packages.git +src-git freifunk https://git.openwrt.org/feed/freifunk.git #src-git video https://github.com/openwrt/video.git #src-git targets https://github.com/openwrt/targets.git #src-git management https://github.com/openwrt-management/packages.git
We shouldn't rely on GitHub for anything serious for obvious reasons. References: https://github.com/openwrt/openwrt/pull/3701#issuecomment-770841946 Signed-off-by: Petr Štetiar <ynezz@true.cz> --- We've recently got following notice from GitHub: "If we determine that a violation has occurred, we may need to disable the repository" BTW I find it quite weird, that we're using feed from external project and we don't have access there. This is for example issue now, where we wanted to prepare 21.02 release, but we can't even create branch in that feed repository, which is blocking builds[1]: Updating feed 'freifunk' from 'https://github.com/freifunk/openwrt-packages.git;openwrt-21.02' ... ... fatal: Remote branch openwrt-21.02 not found in upstream origin 1. http://buildbot.openwrt.org/openwrt-21.02/images/builders/imx6%2Fgeneric/builds/1/steps/updatefeeds/logs/stdio feeds.conf.default | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)