| Message ID | 20210126195201.2085621-1-mail@aparcar.org |
|---|---|
| State | Accepted |
| Delegated to: | Paul Spooren |
| Headers | show |
| Series | umdns: bump to 2021-01-26 | expand |
Paul Spooren <mail@aparcar.org> [2021-01-26 09:52:02]: Hi, > -PKG_RELEASE:=4 > +PKG_RELEASE:=$(AUTORELEASE) IIUC this looks like a default value, so why to bother with this copy&pasta? Can't this be a default which could be overriden when needed? -- ynezz
On Wed, Jan 27, 2021 at 22:37, Petr Štetiar <ynezz@true.cz> wrote:
> Can't this be a default which could be overriden when needed?
Sure, see patch below. As it's a new feature I wanted it optionally
rather than treewide for the beginning.
I'll send a patch.
Paul Spooren <mail@aparcar.org> [2021-01-28 09:11:50]: > On Wed, Jan 27, 2021 at 22:37, Petr Štetiar <ynezz@true.cz> wrote: > > Can't this be a default which could be overriden when needed? > > Sure, see patch below. As it's a new feature I wanted it optionally rather > than treewide for the beginning. I didn't wrote treewide. One could simply remove the PKG_RELEASE in the package and get AUTORELEASE implicitly, instead of this explicit copy&pasta. -- ynezz
diff --git a/package/network/services/umdns/Makefile b/package/network/services/umdns/Makefile index 41945ce007..a405dad0e8 100644 --- a/package/network/services/umdns/Makefile +++ b/package/network/services/umdns/Makefile @@ -1,5 +1,5 @@ # -# Copyright (C) 2014 OpenWrt.org +# Copyright (C) 2014-2021 OpenWrt.org # # This is free software, licensed under the GNU General Public License v2. # See /LICENSE for more information. @@ -8,12 +8,12 @@ include $(TOPDIR)/rules.mk PKG_NAME:=umdns -PKG_RELEASE:=4 +PKG_RELEASE:=$(AUTORELEASE) PKG_SOURCE_URL=$(PROJECT_GIT)/project/mdnsd.git PKG_SOURCE_PROTO:=git -PKG_SOURCE_DATE:=2020-10-26 -PKG_SOURCE_VERSION:=59e4fc98162d253b4e5ecd110f7bc5ea3962e221 +PKG_SOURCE_DATE:=2021-01-26 +PKG_SOURCE_VERSION:=78aa36b0e9808e801c527c6dc47320e593309522 PKG_MIRROR_HASH:=35fefc76d84c963ccb0aa72ac738065649f361d2946d3bc45fbd205d1dfc3d9f PKG_MAINTAINER:=John Crispin <john@phrozen.org>
* i78aa36b umdns: fix 64-bit time format string * start using $(AUTORELEASE) * Update Copyright Signed-off-by: Paul Spooren <mail@aparcar.org> --- package/network/services/umdns/Makefile | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)