From patchwork Wed Nov 14 15:25:48 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin 'ldir' Darbyshire-Bryant X-Patchwork-Id: 997791 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=darbyshire-bryant.me.uk Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MME4Rndq"; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=darbyshire-bryant.me.uk header.i=@darbyshire-bryant.me.uk header.b="dzrDnd/1"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 42w7dC2BR5z9s9G for ; Thu, 15 Nov 2018 02:26:38 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Subject:MIME-Version:Message-ID:Date:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=WbWqlmrwKS4cudD9OAGM/SkWkxQBAve1Nycl/36xtJs=; b=MME4RndqNLDNhq U88YwK71CQjdN92B4vGSMUknzEsgaHc+7Spaxz91i/7NpbjFSbA8YO63i3nEgA0jOStg7DaRoZFdI 2jho/Yc18gWIuSaK9fY6IHJ1TBfvZhD7e9n99G+T4LuZuGdYM4/0epLMmVFoLcFZoOXGJIUNAX77m Om5Hayx7VGhqvXM/apwKFa4h49OVrO9coGMuEFLHKhCEPyhdszWlw6eMo9bDk9uku/YyBxmqNvIK7 16sHGynHVU/mdWly/o9WFUDBCMRILjkpTMWsIxlPvSto11GiRqDe3xkgGm2a3JjfIjHW34cQ0jBBZ JWRb2howXaufhJ/IHR7Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gMx3p-0000W2-Pm; Wed, 14 Nov 2018 15:26:33 +0000 Received: from mail-db3eur04on061e.outbound.protection.outlook.com ([2a01:111:f400:fe0c::61e] helo=EUR04-DB3-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gMx3b-0000Tl-Hd for openwrt-devel@lists.openwrt.org; Wed, 14 Nov 2018 15:26:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darbyshire-bryant.me.uk; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6sB71Gess1BthtKJqsX4sQQCV/I5vcIoYgclWGkOhB4=; b=dzrDnd/1T3hKq4+1ffW1hmavSljApefpbU8mGzkjhVKv49/1Ifx36aPMp0IwD2LSDOu2W9O48iT1tWIha0C6UmI9R2yIoPhLmYW8+lce1jLMdstJ6nHxDhtWgGfQYnHI7+y/3K2AhBVUhjjCxZDXs83O/B8BC9GufkzBzTy01Pk= Received: from VI1PR0302MB2750.eurprd03.prod.outlook.com (10.171.105.143) by VI1PR0302MB3391.eurprd03.prod.outlook.com (52.134.13.153) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1294.30; Wed, 14 Nov 2018 15:25:48 +0000 Received: from VI1PR0302MB2750.eurprd03.prod.outlook.com ([fe80::619c:1a98:5588:6396]) by VI1PR0302MB2750.eurprd03.prod.outlook.com ([fe80::619c:1a98:5588:6396%12]) with mapi id 15.20.1294.045; Wed, 14 Nov 2018 15:25:48 +0000 From: Kevin Darbyshire-Bryant To: "openwrt-devel@lists.openwrt.org" Thread-Topic: [PATCH] hostapd: add utf8_ssid flag & enable as default Thread-Index: AQHUfC5R1QAqWpiysUOAR4d3+XHw2Q== Date: Wed, 14 Nov 2018 15:25:48 +0000 Message-ID: <20181114152531.64093-1-ldir@darbyshire-bryant.me.uk> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: LO2P265CA0248.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8a::20) To VI1PR0302MB2750.eurprd03.prod.outlook.com (2603:10a6:800:e2::15) authentication-results: spf=none (sender IP is ) smtp.mailfrom=kevin@darbyshire-bryant.me.uk; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [2a02:c7f:1240:ee00::dc83] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR0302MB3391; 6:oXVrtW9guj6aPWQIEc2BWnuGjJSiEpxmvCq6kV6+UZAEV9L71gUt22jsxPAnXSv+mDfhJT+vZsnHfZzQIMakFRuRiA0Qf6GNLu3/jVly0RO31yh1wMXBS3rB3k+f+hX6WVcft7zdcVs0Ii55H21vzaULZcCV+UjVDcbsGj7gBQcLLUSH4GwaNz9XGFqGdzUB9kcpT7NrpjGYKs4sxfK9yLxKoBiZOJlrwfS7pou08SRXMbPPE4dIwYZ8AWLG5CEAsoVQfWJYv/hm6U+Vkb5U4gk6lg2+sOaX0aTWJ+BdR5ZXrdGPdOEJSR9ZWjvXtVuyDGzJ19ptSCFc/qlz8o1XBphJyRkIPwRae/NWacNPUmmWouJiJ/MmRPiIJBvaMVNzMF751bE3N8Xrn1Q4q8yDbLuuD3+nckNhlhXdvEbG3U5G1Yx+hHaTTL90HVY2VaBxeBSF3ZuBbr0+kvVS4KjEfg==; 5:spEQbDxtbGURCeciff8ypeXrfWC+s+KFKsumRZxZ0EsCbDpioNPCTPLOhWiG+/WhmjZoBTYpUs69JjLj/k7SQe/ZvCO/UF7ZkpUDn59F5ysykKC38pNQ5jF/lA1fF/f3/loFw6ICpEP+p7NIWV+TFTGfHmdvvsmC7bLoIxlFiOA=; 7:jJMXtnFyLJxG3AuTyKTxfKEVaVJi9a9xLtKhDR6R9dSaKG9NgKY1hVN82BXEXRev3c0+i67m4/hQx8d2ladN41+AEAqIgcbGWSUXC9dFf92Cfp5vaEzxT+/JW2Y3fGdGKzxSS65w9m6I/swmLoK1qQ== x-ms-office365-filtering-correlation-id: 4c7dfa06-9868-40f0-406c-08d64a457408 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390098)(7020095)(4652040)(7021145)(8989299)(5600074)(711020)(4534185)(7022145)(4603075)(4627221)(201702281549075)(8990200)(7048125)(7024125)(7027125)(7023125)(2017052603328)(7153060)(7193020); SRVR:VI1PR0302MB3391; x-ms-traffictypediagnostic: VI1PR0302MB3391: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(3231410)(944501410)(4982022)(52105112)(10201501046)(3002001)(148016)(149066)(150057)(6041310)(2016111802025)(20161123560045)(20161123562045)(20161123558120)(20161123564045)(6043046)(201708071742011)(7699051)(76991095); SRVR:VI1PR0302MB3391; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0302MB3391; x-forefront-prvs: 085634EFF4 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(346002)(136003)(376002)(366004)(39830400003)(199004)(189003)(2616005)(25786009)(81166006)(81156014)(74482002)(97736004)(476003)(71190400001)(71200400001)(486006)(316002)(2501003)(8676002)(4326008)(1857600001)(8936002)(508600001)(256004)(14444005)(46003)(36756003)(2906002)(6506007)(6486002)(14454004)(186003)(1076002)(6436002)(5640700003)(107886003)(53376002)(106356001)(6916009)(2900100001)(52116002)(53936002)(68736007)(53366004)(305945005)(7736002)(6116002)(6306002)(99286004)(105586002)(5660300001)(386003)(6512007)(2351001)(102836004)(10090945008); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0302MB3391; H:VI1PR0302MB2750.eurprd03.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: darbyshire-bryant.me.uk does not designate permitted sender hosts) x-microsoft-antispam-message-info: JcGoWrBpiIL94CY2Dd91t9PDeQxpqueHVbJdt070RwvKYsi2pPeyil8CiwRIzaLZW9J/hRxk7C+25IJRCMILuroA1mXkKvfd8ambdHudjcpGmkc6Va6eRSON0ujOw98d3Y3EYHN8t/byYbifIp3sJQ8GMORCk5oaUPopeYpRysTB2mXDZruOf3zzzDWGoVW3r2sN8u/OwQlcRByCsJnGDaLnAH17RcKdA6kwLNfvA286a/XyqXziAwJfx0mVLLr5y7EZGUaxos6EqxBHSgTJLxB4fpzP4gGp3xHCVmu80sjFGCc/0wY9S5e6lK4A7mjzvxR9K/8g+Kg/s/OEBGlnylQ9PPwYIVatZ+6UeTP2jUA= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: darbyshire-bryant.me.uk X-MS-Exchange-CrossTenant-Network-Message-Id: 4c7dfa06-9868-40f0-406c-08d64a457408 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Nov 2018 15:25:48.3944 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 9151708b-c553-406f-8e56-694f435154a4 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0302MB3391 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181114_072619_628968_23495758 X-CRM114-Status: UNSURE ( 9.64 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2a01:111:f400:fe0c:0:0:0:61e listed in] [list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain Subject: [OpenWrt-Devel] [PATCH] hostapd: add utf8_ssid flag & enable as default X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Darbyshire-Bryant Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org SSIDs may contain UTF8 characters but ideally hostapd should be told this is the case so it can advertise the fact. Default enable this option. add uci option utf8_ssid '0'/'1' for disable/enable e.g. config wifi-iface option utf8_ssid '0' Signed-off-by: Kevin Darbyshire-Bryant --- package/network/services/hostapd/Makefile | 2 +- package/network/services/hostapd/files/hostapd.sh | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/package/network/services/hostapd/Makefile b/package/network/services/hostapd/Makefile index bf9a64419d..45c394640d 100644 --- a/package/network/services/hostapd/Makefile +++ b/package/network/services/hostapd/Makefile @@ -7,7 +7,7 @@ include $(TOPDIR)/rules.mk PKG_NAME:=hostapd -PKG_RELEASE:=5 +PKG_RELEASE:=6 PKG_SOURCE_URL:=http://w1.fi/hostap.git PKG_SOURCE_PROTO:=git diff --git a/package/network/services/hostapd/files/hostapd.sh b/package/network/services/hostapd/files/hostapd.sh index 540d1182cc..7f3157cd27 100644 --- a/package/network/services/hostapd/files/hostapd.sh +++ b/package/network/services/hostapd/files/hostapd.sh @@ -168,7 +168,7 @@ EOF hostapd_common_add_bss_config() { config_add_string 'bssid:macaddr' 'ssid:string' - config_add_boolean wds wmm uapsd hidden + config_add_boolean wds wmm uapsd hidden utf8_ssid config_add_int maxassoc max_inactivity config_add_boolean disassoc_low_ack isolate short_preamble @@ -258,7 +258,7 @@ hostapd_set_bss_options() { maxassoc max_inactivity disassoc_low_ack isolate auth_cache \ wps_pushbutton wps_label ext_registrar wps_pbc_in_m1 wps_ap_setup_locked \ wps_independent wps_device_type wps_device_name wps_manufacturer wps_pin \ - macfilter ssid wmm uapsd hidden short_preamble rsn_preauth \ + macfilter ssid utf8_ssid wmm uapsd hidden short_preamble rsn_preauth \ iapp_interface eapol_version dynamic_vlan ieee80211w nasid \ acct_server acct_secret acct_port acct_interval \ bss_load_update_period chan_util_avg_period sae_require_mfp @@ -277,6 +277,7 @@ hostapd_set_bss_options() { set_default acct_port 1813 set_default bss_load_update_period 60 set_default chan_util_avg_period 600 + set_default utf8_ssid 1 append bss_conf "ctrl_interface=/var/run/hostapd" if [ "$isolate" -gt 0 ]; then @@ -296,6 +297,7 @@ hostapd_set_bss_options() { append bss_conf "wmm_enabled=$wmm" "$N" append bss_conf "ignore_broadcast_ssid=$hidden" "$N" append bss_conf "uapsd_advertisement_enabled=$uapsd" "$N" + append bss_conf "utf8_ssid=$utf8_ssid" "$N" [ "$tdls_prohibit" -gt 0 ] && append bss_conf "tdls_prohibit=$tdls_prohibit" "$N"