From patchwork Wed Dec 16 23:26:08 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathias Kresin X-Patchwork-Id: 557822 X-Patchwork-Delegate: openwrt@kresin.me Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from arrakis.dune.hu (arrakis.dune.hu [78.24.191.176]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 600661402ED for ; Thu, 17 Dec 2015 10:27:56 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kresin-me.20150623.gappssmtp.com header.i=@kresin-me.20150623.gappssmtp.com header.b=pp72fKRx; dkim-atps=neutral Received: from arrakis.dune.hu (localhost [127.0.0.1]) by arrakis.dune.hu (Postfix) with ESMTP id 2238B28B741; Thu, 17 Dec 2015 00:26:18 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on arrakis.dune.hu X-Spam-Level: X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from arrakis.dune.hu (localhost [127.0.0.1]) by arrakis.dune.hu (Postfix) with ESMTP id 1EC9F28021B for ; Thu, 17 Dec 2015 00:26:06 +0100 (CET) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 CL_IP_EQ_HELO_IP=-2 (check from: .kresin. - helo: .mail-lb0-f169.google. - helo-domain: .google.) FROM/MX_MATCHES_NOT_HELO(DOMAIN)=1; rate: -5.5 Received: from mail-lb0-f169.google.com (mail-lb0-f169.google.com [209.85.217.169]) by arrakis.dune.hu (Postfix) with ESMTPS for ; Thu, 17 Dec 2015 00:26:03 +0100 (CET) Received: by mail-lb0-f169.google.com with SMTP id u9so35145869lbp.2 for ; Wed, 16 Dec 2015 15:26:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kresin-me.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:in-reply-to:references; bh=UaE13IbBVQ30nussseZ3H/79alCHsVDCeUOijciqwWo=; b=pp72fKRxiuPBE+SC/EAaI6+810BQjc2w3JNIH6lWWEum9f+RWbuO9kgCgAXm/3nhGR 1wsefVX/ESvyKM3RbJreoqMGXXCJH9IkCtkeKRnzj30RerIhrhbFTNyPvZVKA0xhRxRn yW8io8TRzyqVuSTAqympTVPwDeEj4aUA3iJNBpyNYn+/zOhV0o+1jLdjH0tFkob3NsEw QSkyxJp4J7IgHvumK1lHQPG7CAtOhz+As9Mn0u4Ce+CozXzH9RRyDsUikGktZdrP8X23 X5Q910HuddcwsLPeh/qZMD3SC6Wa12lDLVCPyilmQ6ASc4gMqSBXJCXpyEhxrfXYjS5P Gkyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=UaE13IbBVQ30nussseZ3H/79alCHsVDCeUOijciqwWo=; b=gniY4SiNhiBt+RI3fhWRj2ZidM/gG9+70NPWB2tQCFC4gPunEzf8JBvWZr9Y4uvtsf He5iZnT5MKhKHvv6TgU29adiJ0smgKngAYEHeMYOttYgr3XxEzD2k8imjqlw2rE+cdr4 OQEhpUANphLRHei4Z02ZMO20O+JBsWCn0YdWk2Q+6lOwwBpVE/q/wnlH5UUYvLiLFGab PEOLXodtKhjtnaZpcpEkdNCFe7MrAtVUroWerfdf2+mMxXJIzehLkgzcmz3MMz9nXDna EfSjSwQ6IpqMytqKVTx8kWZy8mjbbgQn6HMKR9ligdAzxr2IHyquSva9W3uiTpuxNvvj sGhw== X-Gm-Message-State: ALoCoQlCuz4ScVKYSKC/Yqac118zsRYeBlNjN1L/NxkQUQJWVXdm/a42o6goNB6QfRNsU20D99SnL3DXWUH4lUEbq9Tixr8vIA== X-Received: by 10.112.162.8 with SMTP id xw8mr19926626lbb.57.1450308378077; Wed, 16 Dec 2015 15:26:18 -0800 (PST) Received: from desktop.wvd.kresin.me (p5DDC699D.dip0.t-ipconnect.de. [93.220.105.157]) by smtp.gmail.com with ESMTPSA id px9sm1455930lbb.4.2015.12.16.15.26.17 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 16 Dec 2015 15:26:17 -0800 (PST) From: Mathias Kresin To: openwrt-devel@lists.openwrt.org Date: Thu, 17 Dec 2015 00:26:08 +0100 Message-Id: <1450308368-20406-3-git-send-email-openwrt@kresin.me> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1450308368-20406-1-git-send-email-openwrt@kresin.me> References: <1450308368-20406-1-git-send-email-openwrt@kresin.me> Subject: [OpenWrt-Devel] [PATCH 3/3] lantiq: let dsl_notify.sh exclusive handle the dsl led X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: openwrt-devel-bounces@lists.openwrt.org Sender: "openwrt-devel" dsl_control (dsl_notify.sh) is the only process which is aware of the state of the atm/ptm interface. Use the dsl led exclusive for the dsl line state. All touched boards have a distinct internet led set, which is perfect fine for indicating the ppp status. No need to add another netdev trigger to the ptm/atm device. Signed-off-by: Mathias Kresin --- target/linux/lantiq/base-files/etc/board.d/01_leds | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/target/linux/lantiq/base-files/etc/board.d/01_leds b/target/linux/lantiq/base-files/etc/board.d/01_leds index 8422ec0..9787d2d 100755 --- a/target/linux/lantiq/base-files/etc/board.d/01_leds +++ b/target/linux/lantiq/base-files/etc/board.d/01_leds @@ -43,7 +43,6 @@ VGV7510KW22) ucidef_set_led_default "power" "power" "power" "1" ucidef_set_led_default "power2" "power2" "power2" "0" ucidef_set_led_wlan "wifi" "wifi" "wifi" "phy0radio" - ucidef_set_led_netdev "dsl" "dsl" "dsl" "nas0" ucidef_set_led_netdev "internet_green" "internet_green" "internet_green" "pppoe-wan" ;; VGV7519) @@ -57,7 +56,6 @@ P2812HNUF*) ucidef_set_led_default "power" "power" "power" "0" ucidef_set_led_default "power2" "power2" "power2" "1" ucidef_set_led_wlan "wireless_green" "wireless_green" "wireless_green" "phy0radio" - ucidef_set_led_netdev "dsl" "dsl" "dsl" "nas0" ucidef_set_led_netdev "internet_green" "internet_green" "internet_green" "pppoe-wan" ;; ARV7519RW22) @@ -69,7 +67,7 @@ ARV8539PW22) ucidef_set_led_default "power" "power" "soc:green:power" "1" ucidef_set_led_default "power2" "power2" "soc:red:power" "0" ucidef_set_led_wlan "wifi" "wifi" "soc:green:wireless" "phy0tpt" - ucidef_set_led_netdev "dsl" "dsl" "soc:green:dsl" "nas0" + ucidef_set_led_default "dsl" "dsl" "soc:green:dsl" "0" ucidef_set_led_netdev "online" "online" "soc:green:online" "pppoe-wan" ;; *)