| Message ID | 1450308368-20406-2-git-send-email-openwrt@kresin.me |
|---|---|
| State | Under Review, archived |
| Delegated to: | Mathias Kresin |
| Headers | show |
Hi, we had a discussion yesterday with a few people and agreed to cleanup the led names on for the lantiq target to match the format expected by the kernel. i like this patch however we need to do the led renaming first i guess. John On 17/12/2015 00:26, Mathias Kresin wrote: > Signed-off-by: Mathias Kresin <openwrt@kresin.me> > --- > target/linux/lantiq/dts/ARV4510PW.dts | 2 +- > target/linux/lantiq/dts/ARV4520PW.dts | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/target/linux/lantiq/dts/ARV4510PW.dts b/target/linux/lantiq/dts/ARV4510PW.dts > index 4772495..67c9999 100644 > --- a/target/linux/lantiq/dts/ARV4510PW.dts > +++ b/target/linux/lantiq/dts/ARV4510PW.dts > @@ -168,7 +168,7 @@ > gpios = <&gpios 15 0>; > }; > adsl { > - label = "adsl"; > + label = "dsl"; > gpios = <&gpios 14 0>; > }; > internet { > diff --git a/target/linux/lantiq/dts/ARV4520PW.dts b/target/linux/lantiq/dts/ARV4520PW.dts > index 8a5b797..3aa06a9 100644 > --- a/target/linux/lantiq/dts/ARV4520PW.dts > +++ b/target/linux/lantiq/dts/ARV4520PW.dts > @@ -145,7 +145,7 @@ > gpios = <&gpio 3 1>; > }; > adsl { > - label = "adsl"; > + label = "dsl"; > gpios = <&gpio 4 1>; > }; > internet { >
2015-12-17 7:52 GMT+01:00 John Crispin <john@phrozen.org>: > Hi, > > we had a discussion yesterday with a few people and agreed to cleanup > the led names on for the lantiq target to match the format expected by > the kernel. i like this patch however we need to do the led renaming > first i guess. From my point of view, a configurable DSL led is a precondition for renaming the leds. but I'm sure you have a better general view than I. I'm fine to skip this patch of the series and fix the DSL led of the affected boards after renaming the leds. I totally agree with you, that the led naming is suboptimal. I'm currently working on adding support for systems which are using three leds for boot state indication. I had to rewrite the whole diag.sh, with the benefit that we can get rid of the static power[0-2] naming as well. With having led names like power[0-2] without any indication which colour the led has, it's a mess to ensure that I don't break existing power led setups. Am I right that you are talking about a naming scheme like "devicename:colour:function" as it's suggested by https://www.kernel.org/doc/Documentation/leds/leds-class.txt? Are there any known limitations for the led node names, which are available at /sys/class/leds/*/device/of_node/? Maybe we can use node names according to the intended (OpenWrt) use and prevent bloating the board.d led file this way after switching to the devicename:colour:function naming. Are you working on renaming the leds or are you wait for patches?
On 17/12/2015 13:58, Mathias Kresin wrote: > 2015-12-17 7:52 GMT+01:00 John Crispin <john@phrozen.org>: >> Hi, >> >> we had a discussion yesterday with a few people and agreed to cleanup >> the led names on for the lantiq target to match the format expected by >> the kernel. i like this patch however we need to do the led renaming >> first i guess. > > From my point of view, a configurable DSL led is a precondition for > renaming the leds. but I'm sure you have a better general view than I. > I'm fine to skip this patch of the series and fix the DSL led of the > affected boards after renaming the leds. > > I totally agree with you, that the led naming is suboptimal. I'm > currently working on adding support for systems which are using three > leds for boot state indication. I had to rewrite the whole diag.sh, > with the benefit that we can get rid of the static power[0-2] naming > as well. With having led names like power[0-2] without any indication > which colour the led has, it's a mess to ensure that I don't break > existing power led setups. > > Am I right that you are talking about a naming scheme like > "devicename:colour:function" as it's suggested by > https://www.kernel.org/doc/Documentation/leds/leds-class.txt? correct, we cleaned up ralink recently and i would like to see the ame happen for lantiq > > Are there any known limitations for the led node names, which are > available at /sys/class/leds/*/device/of_node/? Maybe we can use node > names according to the intended (OpenWrt) use and prevent bloating the > board.d led file this way after switching to the > devicename:colour:function naming. > > Are you working on renaming the leds or are you wait for patches? not actively working on it now, we made a short todo list for lantiq for the DD release which will be based on v4.4. if you have the time, then go for it :) John > _______________________________________________ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel >
diff --git a/target/linux/lantiq/dts/ARV4510PW.dts b/target/linux/lantiq/dts/ARV4510PW.dts index 4772495..67c9999 100644 --- a/target/linux/lantiq/dts/ARV4510PW.dts +++ b/target/linux/lantiq/dts/ARV4510PW.dts @@ -168,7 +168,7 @@ gpios = <&gpios 15 0>; }; adsl { - label = "adsl"; + label = "dsl"; gpios = <&gpios 14 0>; }; internet { diff --git a/target/linux/lantiq/dts/ARV4520PW.dts b/target/linux/lantiq/dts/ARV4520PW.dts index 8a5b797..3aa06a9 100644 --- a/target/linux/lantiq/dts/ARV4520PW.dts +++ b/target/linux/lantiq/dts/ARV4520PW.dts @@ -145,7 +145,7 @@ gpios = <&gpio 3 1>; }; adsl { - label = "adsl"; + label = "dsl"; gpios = <&gpio 4 1>; }; internet {
Signed-off-by: Mathias Kresin <openwrt@kresin.me> --- target/linux/lantiq/dts/ARV4510PW.dts | 2 +- target/linux/lantiq/dts/ARV4520PW.dts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)