| Message ID | 1436370498-8984-3-git-send-email-christian@m3hlis.de |
|---|---|
| State | Changes Requested |
| Headers | show |
Hi, On 08/07/2015 17:48, Christian Mehlis wrote: > Signed-off-by: Christian Mehlis <christian@m3hlis.de> > --- > target/linux/ar71xx/files/arch/mips/ath79/mach-wpj531.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/target/linux/ar71xx/files/arch/mips/ath79/mach-wpj531.c b/target/linux/ar71xx/files/arch/mips/ath79/mach-wpj531.c > index 2cc2fe8..7a074c8 100644 > --- a/target/linux/ar71xx/files/arch/mips/ath79/mach-wpj531.c > +++ b/target/linux/ar71xx/files/arch/mips/ath79/mach-wpj531.c > @@ -99,8 +99,6 @@ static void __init common_setup(void) > > ath79_register_m25p80(NULL); > > - ath79_setup_ar933x_phy4_switch(false, false); > - why is this unnecessary ? do we now rely on the bootloader to have already made the setup ? i picked up the other 4 patches from the series already. John > ath79_register_mdio(0, 0x0); > > /* LAN */ >
Am 09.07.2015 um 08:14 schrieb John Crispin: > why is this unnecessary ? do we now rely on the bootloader to have > already made the setup ? Hi John, I see, I couldn't find any difference in calling this function or not from a perspective within the system (swconfig, ethtool). Perhaps I'm just lucky and uboot did everything right...let's keep this line! Best Christian
diff --git a/target/linux/ar71xx/files/arch/mips/ath79/mach-wpj531.c b/target/linux/ar71xx/files/arch/mips/ath79/mach-wpj531.c index 2cc2fe8..7a074c8 100644 --- a/target/linux/ar71xx/files/arch/mips/ath79/mach-wpj531.c +++ b/target/linux/ar71xx/files/arch/mips/ath79/mach-wpj531.c @@ -99,8 +99,6 @@ static void __init common_setup(void) ath79_register_m25p80(NULL); - ath79_setup_ar933x_phy4_switch(false, false); - ath79_register_mdio(0, 0x0); /* LAN */
Signed-off-by: Christian Mehlis <christian@m3hlis.de> --- target/linux/ar71xx/files/arch/mips/ath79/mach-wpj531.c | 2 -- 1 file changed, 2 deletions(-)