From patchwork Tue Jan 6 07:23:37 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yegor Yefremov X-Patchwork-Id: 425561 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from arrakis.dune.hu (arrakis.dune.hu [78.24.191.176]) (using TLSv1.1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id BC380140082 for ; Tue, 6 Jan 2015 18:24:25 +1100 (AEDT) Received: from arrakis.dune.hu (localhost [127.0.0.1]) by arrakis.dune.hu (Postfix) with ESMTP id E24C1289C5F; Tue, 6 Jan 2015 08:22:09 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on arrakis.dune.hu X-Spam-Level: X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.2 Received: from arrakis.dune.hu (localhost [127.0.0.1]) by arrakis.dune.hu (Postfix) with ESMTP id 30E18280067 for ; Tue, 6 Jan 2015 08:22:05 +0100 (CET) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 CL_IP_EQ_FROM_MX=-3.1; rate: -7.6 Received: from mail.visionsystems.de (mail.visionsystems.de [213.209.99.202]) by arrakis.dune.hu (Postfix) with ESMTP for ; Tue, 6 Jan 2015 08:22:04 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mail.visionsystems.de (Postfix) with ESMTP id BA65C2FA3F2; Tue, 6 Jan 2015 08:24:10 +0100 (CET) Received: from mail.visionsystems.de ([127.0.0.1]) by localhost (mail.visionsystems.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 25796-03; Tue, 6 Jan 2015 08:23:47 +0100 (CET) Received: from visionsystems.de (kallisto.visionsystems.local [192.168.1.3]) by mail.visionsystems.de (Postfix) with ESMTP id 4CEE62FA1A2; Tue, 6 Jan 2015 08:23:47 +0100 (CET) Received: from development1.visionsystems.local ([192.168.1.36]) by visionsystems.de with Microsoft SMTPSVC(6.0.3790.4675); Tue, 6 Jan 2015 08:23:46 +0100 From: yegorslists@googlemail.com To: openwrt-devel@lists.openwrt.org Date: Tue, 6 Jan 2015 08:23:37 +0100 Message-Id: <1420529017-30472-1-git-send-email-yegorslists@googlemail.com> X-Mailer: git-send-email 1.7.7 X-OriginalArrivalTime: 06 Jan 2015 07:23:46.0986 (UTC) FILETIME=[B5B5E0A0:01D02981] X-Virus-Scanned: amavisd-new at visionsystems.de Subject: [OpenWrt-Devel] [PATCH] list: remove double freeing of section X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: openwrt-devel-bounces@lists.openwrt.org Sender: "openwrt-devel" From: Yegor Yefremov This error was reported by cppcheck. Compile tested only. Signed-off-by: Yegor Yefremov --- list.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/list.c b/list.c index 0d00f81..46f8943 100644 --- a/list.c +++ b/list.c @@ -346,7 +346,6 @@ uci_lookup_ext_section(struct uci_context *ctx, struct uci_ptr *ptr) goto done; error: - free(section); memset(ptr, 0, sizeof(struct uci_ptr)); UCI_THROW(ctx, UCI_ERR_INVAL); done: