mbox series

[v3,0/9] odhcpd patchset

Message ID 20240409030540.77576-1-newtwen+github@gmail.com
Headers show
Series odhcpd patchset | expand

Message

Paul Donald April 9, 2024, 3:04 a.m. UTC 
From: Paul Donald <newtwen@gmail.com>

applies to odhcpd master HEAD d8118f6e76e5519881f9a37137c3a06b3cb60fd2

Before:
==
ICMPv6 Option (Prefix information : fd51:1c2a:8909::/64)
    Type: Prefix information (3)
    Length: 4 (32 bytes)
    Prefix Length: 64
    Flag: 0xc0, On-link flag(L), Autonomous address-configuration flag(A)
    Valid Lifetime: Infinity (4294967295)
    Preferred Lifetime: Infinity (4294967295)
    Reserved
    Prefix: fd51:1c2a:8909::
==After:==
ICMPv6 Option (Prefix information : fd51:1c2a:8909::/64)
    Type: Prefix information (3)
    Length: 4 (32 bytes)
    Prefix Length: 64
    Flag: 0xc0, On-link flag(L), Autonomous address-configuration flag(A)
    Valid Lifetime: Infinity (4294967295)
    Preferred Lifetime: 420
    Reserved
    Prefix: fd51:1c2a:8909::
==


changes:
v1: initial patch
v2: implemented feedback for commit messages
v3: house-keeping. removed config defaults/clamping

Paul Donald (9):
  various: refactor pref(erred) to preferred_lt (lifetime)
  various: refactor valid -> valid_lt (lifetime)
  router: inherit user-assigned preferred_lifetime
  router: Limit prefix preferred_lt to valid_lt in accordance with
    RFC4861
  various: Comment spell-fixes, new comments for extra clarification
  various: (formatting) convert spaces -> tabs
  router: rename minvalid -> lowest_found_lifetime
  router: disambiguate and clarify 'no route' messages
  config: set RFC defaults for preferred lifetime

 README          |   2 +-
 src/config.c    |  55 +++++++++----------
 src/dhcpv4.c    |   2 +-
 src/dhcpv6-ia.c | 140 ++++++++++++++++++++++++------------------------
 src/dhcpv6.c    |   6 +--
 src/dhcpv6.h    |   8 +--
 src/ndp.c       |   4 +-
 src/netlink.c   |  56 +++++++++----------
 src/odhcpd.c    |   8 +--
 src/odhcpd.h    |   4 +-
 src/router.c    | 115 +++++++++++++++++++++------------------
 11 files changed, 207 insertions(+), 193 deletions(-)

Comments

Paul D May 6, 2024, 1 p.m. UTC | #1 
Any further comments or reviews for this to go in?


On 2024-04-09 05:04, Paul Donald wrote:
> From: Paul Donald <newtwen@gmail.com>
> 
> applies to odhcpd master HEAD d8118f6e76e5519881f9a37137c3a06b3cb60fd2
> 
> Before:
> ==
> ICMPv6 Option (Prefix information : fd51:1c2a:8909::/64)
>     Type: Prefix information (3)
>     Length: 4 (32 bytes)
>     Prefix Length: 64
>     Flag: 0xc0, On-link flag(L), Autonomous address-configuration flag(A)
>     Valid Lifetime: Infinity (4294967295)
>     Preferred Lifetime: Infinity (4294967295)
>     Reserved
>     Prefix: fd51:1c2a:8909::
> ==After:==
> ICMPv6 Option (Prefix information : fd51:1c2a:8909::/64)
>     Type: Prefix information (3)
>     Length: 4 (32 bytes)
>     Prefix Length: 64
>     Flag: 0xc0, On-link flag(L), Autonomous address-configuration flag(A)
>     Valid Lifetime: Infinity (4294967295)
>     Preferred Lifetime: 420
>     Reserved
>     Prefix: fd51:1c2a:8909::
> ==
> 
> 
> changes:
> v1: initial patch
> v2: implemented feedback for commit messages
> v3: house-keeping. removed config defaults/clamping