From patchwork Sat May 6 17:28:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Hoffmann X-Patchwork-Id: 1778038 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=MKyu6YGj; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=3e8.eu header.i=@3e8.eu header.a=rsa-sha256 header.s=mail20211217 header.b=hmoGUfyY; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4QDF4F36BLz214P for ; Sun, 7 May 2023 03:32:28 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=cTMPItLdxMGpD6hZYeqPB7RnHNJQ0rUcEAXYtyUrCx8=; b=MKyu6YGjtDwYGU b63PB6kGM65vsQ/Pu5Ap4s0w1KbiVWfKflIxVilHcdbpt81CC6Qurq9deL1ftyJyiHh0YTNKcRdFy jSMR2SAtPIcuYqljHNvNCzpNfoVmfMeHA27dZXx84ZbarACR2EGhbYwiqUpSzqXAQFbX6TPJP54Hc S+Jd7c4+StAYMgPRMd8YECMCgK7NLBl5tEuBpuV3/x2aFoZrxNPMGMxV7tmh7n82UO6U5TuOn8qYX yF0GmvPmjU90ymIpquMvLy5n2vXdq3rdOD7FhuItQiPAn07XFac3M/XVd4Z3NBhf0rUGfwye4SJoe D/JmHs1R3viAQ6q/xITQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pvLj9-00E6Sq-0i; Sat, 06 May 2023 17:29:47 +0000 Received: from srv5.3e8.eu ([94.16.113.219]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pvLj5-00E6SG-0h for openwrt-devel@lists.openwrt.org; Sat, 06 May 2023 17:29:45 +0000 Received: from localhost.localdomain (p200300c6cf1962a00858ededb4df0c9f.dip0.t-ipconnect.de [IPv6:2003:c6:cf19:62a0:858:eded:b4df:c9f]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by srv5.3e8.eu (Postfix) with ESMTPSA id EBE46120B4B; Sat, 6 May 2023 19:29:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=3e8.eu; s=mail20211217; t=1683394172; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=DNK4yuaNJDCK/j4bHjxeGIKELnp1EJ3mg9WUuJJ54bc=; b=hmoGUfyYTz0k4ZIL1XC4lQuYmMMYPhxgsuCI5D84+5DLnSeiJNWcR9EYDqXu4K1NQ3J1+A BmeIL6IaYLCe+smDkaI8rWCTOLMYejWP5y0HscLwA2Md92vqecPi29NYhpsqCCqzz29O80 e/7NysFqhxkyyMcyIL3K7yyjQ2yj7QFs7c3oFSxNlQA6qr92zrtZsskl+WEuwIqPQF0k1x KzqG/iZsd0IfypqLJh2vfWMpXKEL+cJrQkn8jrj4gxz1WNJcrMxUBoNDuQNrUX42jHFebY orB96JMNbEYfB5lIKkEIxB8DJ4cdb9bqer849iI9wszuNRwF6mD05EegRwtgPg== From: Jan Hoffmann To: openwrt-devel@lists.openwrt.org, Sander Vanheule Cc: Jan Hoffmann Subject: [PATCH v2 0/4] realtek: fix multiple issues with L2 forwarding Date: Sat, 6 May 2023 19:28:51 +0200 Message-Id: <20230506172855.1138748-1-jan@3e8.eu> X-Mailer: git-send-email 2.40.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230506_102944_006210_08EAB027 X-CRM114-Status: UNSURE ( 7.45 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: This series fixes several bugs that can result in packets being forwarded incorrectly. The port isolation and VLAN issues probably remained unnoticed so far, because they only manifest after a port le [...] Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org This series fixes several bugs that can result in packets being forwarded incorrectly. The port isolation and VLAN issues probably remained unnoticed so far, because they only manifest after a port leaves a bridge, or when an existing VLAN membership is changed. v2: - Fixed checkpatch.pl warnings - Removed comment about RTL838X_PORT_ISO_CTRL, as the traffic_set method is now used instead of accessing the register directly - Added Fixes tags for first commit Jan Hoffmann (4): realtek: properly update port masks when port leaves bridge realtek: initialize port masks to match the default state realtek: fix standalone ports in presence of static fdb entries realtek: handle changed flags in VLAN configuration .../files-5.10/drivers/net/dsa/rtl83xx/dsa.c | 90 +++++++++++-------- .../drivers/net/dsa/rtl83xx/rtl838x.c | 10 +++ .../drivers/net/dsa/rtl83xx/rtl838x.h | 14 +++ .../drivers/net/dsa/rtl83xx/rtl839x.c | 11 +++ .../files-5.15/drivers/net/dsa/rtl83xx/dsa.c | 86 +++++++++++------- .../drivers/net/dsa/rtl83xx/rtl838x.c | 10 +++ .../drivers/net/dsa/rtl83xx/rtl838x.h | 14 +++ .../drivers/net/dsa/rtl83xx/rtl839x.c | 11 +++ 8 files changed, 175 insertions(+), 71 deletions(-)