mbox series

[v2,0/4] realtek: fix multiple issues with L2 forwarding

Message ID 20230506172855.1138748-1-jan@3e8.eu
Headers show
Series realtek: fix multiple issues with L2 forwarding | expand

Message

Jan Hoffmann May 6, 2023, 5:28 p.m. UTC 
This series fixes several bugs that can result in packets being
forwarded incorrectly. The port isolation and VLAN issues probably
remained unnoticed so far, because they only manifest after a port
leaves a bridge, or when an existing VLAN membership is changed.

v2:
 - Fixed checkpatch.pl warnings
 - Removed comment about RTL838X_PORT_ISO_CTRL, as the traffic_set
   method is now used instead of accessing the register directly
 - Added Fixes tags for first commit

Jan Hoffmann (4):
  realtek: properly update port masks when port leaves bridge
  realtek: initialize port masks to match the default state
  realtek: fix standalone ports in presence of static fdb entries
  realtek: handle changed flags in VLAN configuration

 .../files-5.10/drivers/net/dsa/rtl83xx/dsa.c  | 90 +++++++++++--------
 .../drivers/net/dsa/rtl83xx/rtl838x.c         | 10 +++
 .../drivers/net/dsa/rtl83xx/rtl838x.h         | 14 +++
 .../drivers/net/dsa/rtl83xx/rtl839x.c         | 11 +++
 .../files-5.15/drivers/net/dsa/rtl83xx/dsa.c  | 86 +++++++++++-------
 .../drivers/net/dsa/rtl83xx/rtl838x.c         | 10 +++
 .../drivers/net/dsa/rtl83xx/rtl838x.h         | 14 +++
 .../drivers/net/dsa/rtl83xx/rtl839x.c         | 11 +++
 8 files changed, 175 insertions(+), 71 deletions(-)

Comments

Sander Vanheule May 7, 2023, 5:18 p.m. UTC | #1 
On Sat, 2023-05-06 at 19:28 +0200, Jan Hoffmann wrote:
> This series fixes several bugs that can result in packets being
> forwarded incorrectly. The port isolation and VLAN issues probably
> remained unnoticed so far, because they only manifest after a port
> leaves a bridge, or when an existing VLAN membership is changed.
> 
> v2:
>  - Fixed checkpatch.pl warnings
>  - Removed comment about RTL838X_PORT_ISO_CTRL, as the traffic_set
>    method is now used instead of accessing the register directly
>  - Added Fixes tags for first commit
> 
> Jan Hoffmann (4):
>   realtek: properly update port masks when port leaves bridge
>   realtek: initialize port masks to match the default state
>   realtek: fix standalone ports in presence of static fdb entries
>   realtek: handle changed flags in VLAN configuration

Thanks for the updates. Patches applied to master!

Best,
Sander