Message ID | 20210506162514.5913-1-denis281089@gmail.com |
---|---|
Headers | show |
Series | RFC: ath79: add support for Mikrotik RB91xG | expand |
Hello Denis, On Thu, May 6, 2021 at 7:31 PM Denis Kalashnikov <denis281089@gmail.com> wrote: > When porting RB91xG ad hoc drivers (gpio-latch and rb91x-nand) from ar71xx > to ath79, I made a decision to rework this to more clear design in my opinion: > MFD driver that requests and controls the gpio lines, and separate NAND > driver and GPIO-latch driver that uses API of the MFD driver (like > how in rb4xx-clpd is done). ar71xx gpio-latch is very good, but somewhat hacky, > so I don't think that it can be general driver for gpio controller on a latch. > I could be wrong. Also it is my first attempt to port OpenWrt to a device, so > I need a review from the community. I've tested all these on my RB912UAG-2HPnD. > Gigabit Ethernet, 2.4GHz Wi-Fi, sysupgrade and LEDs:) are working for me. > Not working: beeper, button and USB port/mPCIe (has not tested yet). Thank you for this considerable work! Besides the per patch comments, please check checkpatch.pl report, it produces some useful inputs. -- Sergey