mbox series

[OpenWrt-Devel,0/2] x86: Fix combined squashfs images

Message ID 1553699336-5208-1-git-send-email-ynezz@true.cz
Headers show
Series x86: Fix combined squashfs images | expand

Message

Petr Štetiar March 27, 2019, 3:08 p.m. UTC 
Hi,

we're currently producing unusable x86 combined squashfs images (18.06.1,
18.06.2 and snapshots) as we don't enable TARGET_IMAGES_PAD, thus providing
very small space for the overlay filesystem, leading to the following with
OpenWrt 18.06.1 r7258-5eb055306f images on x86 QEMU:

 root@(none):/# mount | egrep 'root|overlay'
  /dev/root on /rom type squashfs
  /dev/loop0 on /overlay type ext4
  overlayfs:/overlay on / type overlay

 root@(none):/# df -h | egrep 'root|overlay|Size'
  Filesystem                Size      Used Available Use% Mounted on
  /dev/root                 2.5M      2.5M         0 100% /rom
  /dev/loop0              113.0K      8.0K     97.0K   8% /overlay
  overlayfs:/overlay      113.0K      8.0K     97.0K   8% /

We should rather ensure proper image padding in image generation code and we
shouldn't rely on config options in order to generate usable images.

So this small patch series removes TARGET_IMAGES_PAD config option and
enforces padding on combined images, which fixes the combined squashfs images
and make them usable again.

Petr Štetiar (2):
  build: Remove TARGET_IMAGES_PAD option
  x86: image: Remove TARGET_IMAGES_PAD option and force padding

 config/Config-images.in         | 8 +-------
 target/linux/x86/image/Makefile | 2 +-
 2 files changed, 2 insertions(+), 8 deletions(-)