| Message ID | f5cae71d159e9c255e24d4221d4c8f138a239cc2.1726148741.git.echaudro@redhat.com |
|---|---|
| State | Accepted |
| Commit | fa731c1129f10a21b57671ec64c01ef40225d347 |
| Headers | show |
| Series | [ovs-dev] oss-fuzz: Fix odp_flow_format() API in the fuzz tests. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
On 9/12/24 15:45, Eelco Chaudron wrote: > When the commit below introduced an API change, the oss-fuzz component > was not updated accordingly, leading to failures in the upstream > oss-fuzz tests. > > For more information on the failure, see: > https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=71524 > > Fixes: 252ee0f18211 ("dpif: Fix flow put debug message match content.") > Signed-off-by: Eelco Chaudron <echaudro@redhat.com> > --- > tests/oss-fuzz/odp_target.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tests/oss-fuzz/odp_target.c b/tests/oss-fuzz/odp_target.c > index ae61cdca3..0d615f8a2 100644 > --- a/tests/oss-fuzz/odp_target.c > +++ b/tests/oss-fuzz/odp_target.c > @@ -81,7 +81,8 @@ parse_keys(bool wc_keys, const char *in) > ds_init(&out); > if (wc_keys) { > odp_flow_format(odp_key.data, odp_key.size, > - odp_mask.data, odp_mask.size, NULL, &out, false); > + odp_mask.data, odp_mask.size, NULL, &out, false, > + false); > } else { > odp_flow_key_format(odp_key.data, odp_key.size, &out); > } I didn't test the actual build, but looks correct. Acked-by: Ilya Maximets <i.maximets@ovn.org>
On 12 Sep 2024, at 16:19, Ilya Maximets wrote: > On 9/12/24 15:45, Eelco Chaudron wrote: >> When the commit below introduced an API change, the oss-fuzz component >> was not updated accordingly, leading to failures in the upstream >> oss-fuzz tests. >> >> For more information on the failure, see: >> https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=71524 >> >> Fixes: 252ee0f18211 ("dpif: Fix flow put debug message match content.") >> Signed-off-by: Eelco Chaudron <echaudro@redhat.com> >> --- >> tests/oss-fuzz/odp_target.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/tests/oss-fuzz/odp_target.c b/tests/oss-fuzz/odp_target.c >> index ae61cdca3..0d615f8a2 100644 >> --- a/tests/oss-fuzz/odp_target.c >> +++ b/tests/oss-fuzz/odp_target.c >> @@ -81,7 +81,8 @@ parse_keys(bool wc_keys, const char *in) >> ds_init(&out); >> if (wc_keys) { >> odp_flow_format(odp_key.data, odp_key.size, >> - odp_mask.data, odp_mask.size, NULL, &out, false); >> + odp_mask.data, odp_mask.size, NULL, &out, false, >> + false); >> } else { >> odp_flow_key_format(odp_key.data, odp_key.size, &out); >> } > > I didn't test the actual build, but looks correct. I verified it offline with their tools. Thanks for the quick review, and the patch is applied to main. > Acked-by: Ilya Maximets <i.maximets@ovn.org>
diff --git a/tests/oss-fuzz/odp_target.c b/tests/oss-fuzz/odp_target.c index ae61cdca3..0d615f8a2 100644 --- a/tests/oss-fuzz/odp_target.c +++ b/tests/oss-fuzz/odp_target.c @@ -81,7 +81,8 @@ parse_keys(bool wc_keys, const char *in) ds_init(&out); if (wc_keys) { odp_flow_format(odp_key.data, odp_key.size, - odp_mask.data, odp_mask.size, NULL, &out, false); + odp_mask.data, odp_mask.size, NULL, &out, false, + false); } else { odp_flow_key_format(odp_key.data, odp_key.size, &out); }
When the commit below introduced an API change, the oss-fuzz component was not updated accordingly, leading to failures in the upstream oss-fuzz tests. For more information on the failure, see: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=71524 Fixes: 252ee0f18211 ("dpif: Fix flow put debug message match content.") Signed-off-by: Eelco Chaudron <echaudro@redhat.com> --- tests/oss-fuzz/odp_target.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)