| Message ID | bf8674d16eed0009c426908ec7698244dfecd36f.1649149317.git.lic121@chinatelecom.cn |
|---|---|
| State | Accepted |
| Headers | show |
| Series | fix revalidation triggers | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | fail | github build: failed |
| ovsrobot/intel-ovs-compilation | success | test: success |
On Tue, Apr 5, 2022 at 12:17 PM lic121 <lic121@chinatelecom.cn> wrote: > Once ct_zone timeout policy changes, revalidator is supposed to be > triggered. > > Fixes: 993cae678bca ("ofproto-dpif: Consume CT_Zone, and CT_Timeout_Policy > tables") > Signed-off-by: lic121 <lic121@chinatelecom.cn> > --- > Changes look good to me! Acked-by: Eelco Chaudron <echaudro@redhat.com>
On 4/8/22 09:49, Eelco Chaudron wrote: > On Tue, Apr 5, 2022 at 12:17 PM lic121 <lic121@chinatelecom.cn> wrote: > >> Once ct_zone timeout policy changes, revalidator is supposed to be >> triggered. >> >> Fixes: 993cae678bca ("ofproto-dpif: Consume CT_Zone, and CT_Timeout_Policy >> tables") >> Signed-off-by: lic121 <lic121@chinatelecom.cn> >> --- >> > > Changes look good to me! > > Acked-by: Eelco Chaudron <echaudro@redhat.com> I applied this patch. Also backported down to 2.13. Thanks! Best regadrs, Ilya Maximets.
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c index 6601f23..7a1bb0d 100644 --- a/ofproto/ofproto-dpif.c +++ b/ofproto/ofproto-dpif.c @@ -5597,6 +5597,7 @@ ct_set_zone_timeout_policy(const char *datapath_type, uint16_t zone_id, ct_timeout_policy_unref(backer, ct_zone->ct_tp); ct_zone->ct_tp = ct_tp; ct_tp->ref_count++; + backer->need_revalidate = REV_RECONFIGURE; } } else { struct ct_zone *new_ct_zone = ct_zone_alloc(zone_id); @@ -5604,6 +5605,7 @@ ct_set_zone_timeout_policy(const char *datapath_type, uint16_t zone_id, cmap_insert(&backer->ct_zones, &new_ct_zone->node, hash_int(zone_id, 0)); ct_tp->ref_count++; + backer->need_revalidate = REV_RECONFIGURE; } } @@ -5620,6 +5622,7 @@ ct_del_zone_timeout_policy(const char *datapath_type, uint16_t zone_id) if (ct_zone) { ct_timeout_policy_unref(backer, ct_zone->ct_tp); ct_zone_remove_and_destroy(backer, ct_zone); + backer->need_revalidate = REV_RECONFIGURE; } }
Once ct_zone timeout policy changes, revalidator is supposed to be triggered. Fixes: 993cae678bca ("ofproto-dpif: Consume CT_Zone, and CT_Timeout_Policy tables") Signed-off-by: lic121 <lic121@chinatelecom.cn> --- ofproto/ofproto-dpif.c | 3 +++ 1 file changed, 3 insertions(+)