Message ID | DM2PR0501MB1020A68A3E8972772F141E8BB35D0@DM2PR0501MB1020.namprd05.prod.outlook.com |
---|---|
State | Not Applicable |
Headers | show
Return-Path: <ovs-dev-bounces@openvswitch.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3vQ50P6PHPz9s7J for <incoming@patchwork.ozlabs.org>; Sat, 18 Feb 2017 07:56:05 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=onevmw.onmicrosoft.com header.i=@onevmw.onmicrosoft.com header.b="D8dI3CFj"; dkim-atps=neutral Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 16302B90; Fri, 17 Feb 2017 20:56:04 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 381EDB2B for <dev@openvswitch.org>; Fri, 17 Feb 2017 20:56:02 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.7.6 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0079.outbound.protection.outlook.com [104.47.36.79]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 8278C14D for <dev@openvswitch.org>; Fri, 17 Feb 2017 20:56:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=onevmw.onmicrosoft.com; s=selector1-vmware-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=OmJMNjweohdFcrDV2ywPSC11M9F3pAPQplzVj8Z4xHQ=; b=D8dI3CFjPaAzoGY1s2mE6nxiLQHgRNTWvzSPqmacF4xC0NrQ3Z7SlpmQtY/EB0TUZS/hLYq1/0ymx6FyAjZO2iwBpuvBQT3TlXJKaYuHPBUVvNZB0ybo5Ql3aS60uZH/C2vJMs9yAJuUIsqaN5KzdEVKXcLZszC8a8U/qtLInx4= Received: from DM2PR0501MB1020.namprd05.prod.outlook.com (10.160.25.12) by DM2PR0501MB1018.namprd05.prod.outlook.com (10.160.24.156) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.919.10; Fri, 17 Feb 2017 20:55:59 +0000 Received: from DM2PR0501MB1020.namprd05.prod.outlook.com ([10.160.25.12]) by DM2PR0501MB1020.namprd05.prod.outlook.com ([10.160.25.12]) with mapi id 15.01.0919.013; Fri, 17 Feb 2017 20:55:59 +0000 From: Nithin Raju <nithin@vmware.com> To: Alin Serdean <aserdean@cloudbasesolutions.com>, "dev@openvswitch.org" <dev@openvswitch.org> Thread-Topic: [PATCH] windows: Broken internal netdevs Thread-Index: AQHSiQ5xvZqFSUMDyEei9icR0jYihKFtrkaM Date: Fri, 17 Feb 2017 20:55:59 +0000 Message-ID: <DM2PR0501MB1020A68A3E8972772F141E8BB35D0@DM2PR0501MB1020.namprd05.prod.outlook.com> References: <20170217111010.12064-1-aserdean@cloudbasesolutions.com> In-Reply-To: <20170217111010.12064-1-aserdean@cloudbasesolutions.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=nithin@vmware.com; x-originating-ip: [24.7.249.206] x-ms-office365-filtering-correlation-id: 3a7d4d63-853e-4846-3a1c-08d457776044 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:DM2PR0501MB1018; x-microsoft-exchange-diagnostics: 1; DM2PR0501MB1018; 7:PO8ilaQsH30Ie3Kish6tgfZX73xhdwljMEOXyoZugowrzf7QUX6J6w7iGKlP7uTR1Q8uHqCxoU2AcHL1fs9PqbYNONaR2PWm/HkA264iyPdzHkAL5geRLMbdzYrYxpKQY42frXwrKoCoanTL43PGQH/ALsH9/H6Ld7GFqRpeCURFQo7mRetzV9OEcvYVdzMmfbcuGAQwUFZY3QfCuxseJerDZ3a+gDf2vNXk7HS89DsfV9PzmEvdYFb6Z37lgOAkAZYNYUOztqxXkWK4bHngkNxCiIBnjznnSqCW96XlxUAkiU7RWBFdhRI9VYZRcDZbdEBCqmBJ/+9k1j7MSeftAQ==; 20:YBFXLuXS8SegDaBx/FlfQm5uzFXqWFnlpZf/5IPmC8NGZsbzR4KGY2NA6eXdrj2F0waeV8FkuR4p9BBU/1mIpL4CwAVBdbI0YluTmBeAGoee3Xzr8RUon68afhor0KjqPuJ/Gjocd1NW7XwxCR73+GBd0b3EkoPCdZtNYE6xGM0= x-microsoft-antispam-prvs: <DM2PR0501MB1018C8F9104B05D45BC0B692B35D0@DM2PR0501MB1018.namprd05.prod.outlook.com> x-exchange-antispam-report-test: UriScan:(61668805478150)(10436049006162)(216315784871565); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6041248)(20161123560025)(20161123555025)(20161123564025)(20161123562025)(20161123558025)(6072148); SRVR:DM2PR0501MB1018; BCL:0; PCL:0; RULEID:; SRVR:DM2PR0501MB1018; x-forefront-prvs: 02213C82F8 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(7916002)(39450400003)(377454003)(189002)(51914003)(199003)(54356999)(86362001)(305945005)(3660700001)(76176999)(33656002)(2906002)(68736007)(122556002)(7736002)(53546006)(50986999)(66066001)(102836003)(92566002)(6116002)(3280700002)(2900100001)(74316002)(3846002)(8936002)(53936002)(8676002)(81156014)(2950100002)(7696004)(2501003)(81166006)(77096006)(106356001)(9686003)(189998001)(6506006)(229853002)(38730400002)(6436002)(101416001)(6306002)(55016002)(25786008)(6246003)(97736004)(5660300001)(106116001)(105586002)(99286003); DIR:OUT; SFP:1101; SCL:1; SRVR:DM2PR0501MB1018; H:DM2PR0501MB1020.namprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: vmware.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: vmware.com X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Feb 2017 20:55:59.2159 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR0501MB1018 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Subject: Re: [ovs-dev] [PATCH] windows: Broken internal netdevs X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: <ovs-dev.openvswitch.org> List-Unsubscribe: <https://mail.openvswitch.org/mailman/options/ovs-dev>, <mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe> List-Archive: <http://mail.openvswitch.org/pipermail/ovs-dev/> List-Post: <mailto:ovs-dev@openvswitch.org> List-Help: <mailto:ovs-dev-request@openvswitch.org?subject=help> List-Subscribe: <https://mail.openvswitch.org/mailman/listinfo/ovs-dev>, <mailto:ovs-dev-request@openvswitch.org?subject=subscribe> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org |
diff --git a/lib/netdev-windows.c b/lib/netdev-windows.c index b22bd09..375cb32 100644 --- a/lib/netdev-windows.c +++ b/lib/netdev-windows.c @@ -159,7 +159,10 @@ netdev_windows_system_construct(struct netdev *netdev_) /* Query the attributes and runtime status of the netdev. */ ret = query_netdev(netdev_get_name(&netdev->up), &info, &buf); - if (ret) { + /* "Internal" netdevs do not exist in the kernel yet. They need to be + * transformed into a netdev object and passed to dpif_port_add(), which + * will add them to the kernel. */ + if (strcmp(netdev_get_type(&netdev->up), "internal") && ret) { return ret; } ofpbuf_delete(buf);
Thanks for the fix. Acked-by: Nithin Raju <Nithin@vmware.com>