From patchwork Fri Feb 19 18:55:23 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joe Stringer X-Patchwork-Id: 585383 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from archives.nicira.com (li376-54.members.linode.com [96.126.127.54]) by ozlabs.org (Postfix) with ESMTP id 12064140326 for ; Sat, 20 Feb 2016 05:56:21 +1100 (AEDT) Received: from archives.nicira.com (localhost [127.0.0.1]) by archives.nicira.com (Postfix) with ESMTP id E522810AEA; Fri, 19 Feb 2016 10:56:20 -0800 (PST) X-Original-To: dev@openvswitch.org Delivered-To: dev@openvswitch.org Received: from mx3v3.cudamail.com (mx3.cudamail.com [64.34.241.5]) by archives.nicira.com (Postfix) with ESMTPS id 54D8210AD7 for ; Fri, 19 Feb 2016 10:56:19 -0800 (PST) Received: from bar6.cudamail.com (localhost [127.0.0.1]) by mx3v3.cudamail.com (Postfix) with ESMTPS id 83E5016385D for ; Fri, 19 Feb 2016 11:56:18 -0700 (MST) X-ASG-Debug-ID: 1455908177-0b3237554ebf820001-byXFYA Received: from mx1-pf1.cudamail.com ([192.168.24.1]) by bar6.cudamail.com with ESMTP id SaWdEkOp6cV3gAnX (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Fri, 19 Feb 2016 11:56:18 -0700 (MST) X-Barracuda-Envelope-From: joe@ovn.org X-Barracuda-RBL-Trusted-Forwarder: 192.168.24.1 Received: from unknown (HELO relay4-d.mail.gandi.net) (217.70.183.196) by mx1-pf1.cudamail.com with ESMTPS (DHE-RSA-AES256-SHA encrypted); 19 Feb 2016 18:56:17 -0000 Received-SPF: pass (mx1-pf1.cudamail.com: SPF record at ovn.org designates 217.70.183.196 as permitted sender) X-Barracuda-Apparent-Source-IP: 217.70.183.196 X-Barracuda-RBL-IP: 217.70.183.196 Received: from mfilter48-d.gandi.net (mfilter48-d.gandi.net [217.70.178.179]) by relay4-d.mail.gandi.net (Postfix) with ESMTP id 199801720A3 for ; Fri, 19 Feb 2016 19:56:15 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mfilter48-d.gandi.net Received: from relay4-d.mail.gandi.net ([IPv6:::ffff:217.70.183.196]) by mfilter48-d.gandi.net (mfilter48-d.gandi.net [::ffff:10.0.15.180]) (amavisd-new, port 10024) with ESMTP id 9suO0yz1D9-g for ; Fri, 19 Feb 2016 19:55:43 +0100 (CET) X-Originating-IP: 74.125.82.45 Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) (Authenticated sender: joe@ovn.org) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id B24561720AE for ; Fri, 19 Feb 2016 19:55:43 +0100 (CET) Received: by mail-wm0-f45.google.com with SMTP id g62so83961699wme.0 for ; Fri, 19 Feb 2016 10:55:43 -0800 (PST) X-Gm-Message-State: AG10YORA95jTWRIXxNlsaKLW6G6PCsQlQEA1THInbsNLNz3nbWeS+7uECh+PeFEtZjmTUHrg7rN6EhBz8gBW4g== X-Received: by 10.194.61.169 with SMTP id q9mr14588889wjr.77.1455908143512; Fri, 19 Feb 2016 10:55:43 -0800 (PST) MIME-Version: 1.0 Received: by 10.27.11.70 with HTTP; Fri, 19 Feb 2016 10:55:23 -0800 (PST) In-Reply-To: <1455907481-24507-6-git-send-email-joe@ovn.org> References: <1455907481-24507-1-git-send-email-joe@ovn.org> <1455907481-24507-6-git-send-email-joe@ovn.org> X-CudaMail-Envelope-Sender: joe@ovn.org From: Joe Stringer Date: Fri, 19 Feb 2016 10:55:23 -0800 X-Gmail-Original-Message-ID: Message-ID: X-CudaMail-Whitelist-To: dev@openvswitch.org X-CudaMail-MID: CM-E1-218059537 X-CudaMail-DTE: 021916 X-CudaMail-Originating-IP: 217.70.183.196 To: Jesse Gross , ovs dev X-ASG-Orig-Subj: [##CM-E1-218059537##]Re: [PATCHv2 5/6] datapath: stt: Relax MTU constraints. X-Barracuda-Connect: UNKNOWN[192.168.24.1] X-Barracuda-Start-Time: 1455908178 X-Barracuda-Encrypted: DHE-RSA-AES256-SHA X-Barracuda-URL: https://web.cudamail.com:443/cgi-mod/mark.cgi X-ASG-Whitelist: Header =?UTF-8?B?eFwtY3VkYW1haWxcLXdoaXRlbGlzdFwtdG8=?= X-Virus-Scanned: by bsmtpd at cudamail.com X-Barracuda-BRTS-Status: 1 Subject: Re: [ovs-dev] [PATCHv2 5/6] datapath: stt: Relax MTU constraints. X-BeenThere: dev@openvswitch.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@openvswitch.org Sender: "dev" On 19 February 2016 at 10:44, Joe Stringer wrote: > Currently, even if the entire path supports jumbo frames, the STT netdev > limits the path MTU to 1500 bytes, and cannot be configured otherwise. > Relax the constraints on modifying the device MTU, and set it to the > maximum by default. > > Signed-off-by: Joe Stringer > --- > v2: Use dev->hard_header_len. > Follow upstream style. > Fix device registration leak on change_mtu failure. I neglected to actually add this fragment into the commit, incremental: diff --git a/datapath/linux/compat/stt.c b/datapath/linux/compat/stt.c index 34efc4f56468..5b6857717091 100644 --- a/datapath/linux/compat/stt.c +++ b/datapath/linux/compat/stt.c @@ -1691,7 +1691,7 @@ static int __stt_change_mtu(struct net_device *dev, int new_mtu, bool strict) if (new_mtu < 68) return -EINVAL; - if (new_mtu < 68) { + if (new_mtu > max_mtu) { if (strict) return -EINVAL;