From patchwork Fri Aug 11 18:43:23 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joe Stringer X-Patchwork-Id: 800725 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3xTYn06rYpz9t0j for ; Sat, 12 Aug 2017 04:43:48 +1000 (AEST) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 4C96AB88; Fri, 11 Aug 2017 18:43:47 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 0713DAB2 for ; Fri, 11 Aug 2017 18:43:46 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id D363B8C for ; Fri, 11 Aug 2017 18:43:45 +0000 (UTC) X-Originating-IP: 209.85.215.43 Received: from mail-lf0-f43.google.com (mail-lf0-f43.google.com [209.85.215.43]) (Authenticated sender: joe@ovn.org) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 8542AA80C1 for ; Fri, 11 Aug 2017 20:43:44 +0200 (CEST) Received: by mail-lf0-f43.google.com with SMTP id y15so19528236lfd.5 for ; Fri, 11 Aug 2017 11:43:44 -0700 (PDT) X-Gm-Message-State: AHYfb5hrZN4FJLyYX6xelO8FoVECNbDyub6mdS/Wl8TNEyUF6LjMyTRs UwmwJxuSjJ+ZGh0G3ceWDgkb8Yby0A== X-Received: by 10.46.9.16 with SMTP id 16mr6057144ljj.155.1502477023745; Fri, 11 Aug 2017 11:43:43 -0700 (PDT) MIME-Version: 1.0 Received: by 10.46.83.25 with HTTP; Fri, 11 Aug 2017 11:43:23 -0700 (PDT) In-Reply-To: <20170808080305.GB28258@vergenet.net> References: <1502119151-49792-1-git-send-email-roid@mellanox.com> <20170808080305.GB28258@vergenet.net> From: Joe Stringer Date: Fri, 11 Aug 2017 11:43:23 -0700 X-Gmail-Original-Message-ID: Message-ID: To: Simon Horman Cc: ovs dev Subject: Re: [ovs-dev] [PATCH 0/7] Add offload support for ip ttl and tcp flags X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org On 8 August 2017 at 01:03, Simon Horman wrote: > On Mon, Aug 07, 2017 at 06:19:04PM +0300, Roi Dayan wrote: >> Hi, >> >> This series adds support for offloading ip ttl and tcp flags >> using tc interface. > > This looks nice, thanks. > > Acked-by: Simon Horman > > I'm also happy to apply this if someone else provides a review. Thanks folks, I'll apply the series to master soon with Simon's acks and the following style fixup. static const struct nl_policy tunnel_key_policy[] = { diff --git a/lib/tc.c b/lib/tc.c index bf12a5bea494..c9cada249de3 100644 --- a/lib/tc.c +++ b/lib/tc.c @@ -363,7 +363,6 @@ nl_parse_flower_ip(struct nlattr **attrs, struct tc_flower *flower) { key->ip_ttl = nl_attr_get_u8(attrs[TCA_FLOWER_KEY_IP_TTL]); mask->ip_ttl = nl_attr_get_u8(attrs[TCA_FLOWER_KEY_IP_TTL_MASK]); } - }