Message ID | CALDO+SZFKbD-sP_HZ0oxGG9TfO3T1Rk+WYDhTrqs2K_98VT0kA@mail.gmail.com |
---|---|
State | Not Applicable |
Headers | show |
On 21 December 2016 at 07:45, William Tu <u9012063@gmail.com> wrote: > Hi Joe, > > I think we're missing the normal action for handling the non-IP > traffic. Can you try this patch on top of the clone? > > --- a/tests/system-traffic.at > +++ b/tests/system-traffic.at > @@ -340,6 +340,7 @@ AT_CLEANUP > AT_SETUP([datapath - clone action]) > OVS_TRAFFIC_VSWITCHD_START() > > +AT_CHECK([ovs-ofctl add-flow br0 "actions=normal"]) > ADD_NAMESPACES(at_ns0, at_ns1, at_ns2) > > ADD_VETH(p0, at_ns0, br0, "10.1.1.1/24") If you force all traffic to be handled with this flow, then the test will pass but it will not be testing anything. Looking at the test, I don't really follow how it is supposed to be guaranteeing that the expected actions are executed on both copies of the packet. Could you explain it?
--- a/tests/system-traffic.at +++ b/tests/system-traffic.at @@ -340,6 +340,7 @@ AT_CLEANUP AT_SETUP([datapath - clone action]) OVS_TRAFFIC_VSWITCHD_START() +AT_CHECK([ovs-ofctl add-flow br0 "actions=normal"]) ADD_NAMESPACES(at_ns0, at_ns1, at_ns2) ADD_VETH(p0, at_ns0, br0, "10.1.1.1/24")