From patchwork Mon Dec 5 21:57:47 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Russell Bryant X-Patchwork-Id: 702901 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3tXdtK1gd9z9s3T for ; Tue, 6 Dec 2016 08:58:17 +1100 (AEDT) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 89C4CB7A; Mon, 5 Dec 2016 21:58:14 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 16EC495D for ; Mon, 5 Dec 2016 21:58:13 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 71E7F134 for ; Mon, 5 Dec 2016 21:58:11 +0000 (UTC) Received: from mfilter32-d.gandi.net (mfilter32-d.gandi.net [217.70.178.163]) by relay2-d.mail.gandi.net (Postfix) with ESMTP id 1EAE2C5A56 for ; Mon, 5 Dec 2016 22:58:10 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mfilter32-d.gandi.net Received: from relay2-d.mail.gandi.net ([IPv6:::ffff:217.70.183.194]) by mfilter32-d.gandi.net (mfilter32-d.gandi.net [::ffff:10.0.15.180]) (amavisd-new, port 10024) with ESMTP id 0AJb81aYDmNG for ; Mon, 5 Dec 2016 22:58:08 +0100 (CET) X-Originating-IP: 209.85.210.182 Received: from mail-wj0-f182.google.com (mail-wj0-f182.google.com [209.85.210.182]) (Authenticated sender: russell@ovn.org) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 0BA9DC5A5A for ; Mon, 5 Dec 2016 22:58:07 +0100 (CET) Received: by mail-wj0-f182.google.com with SMTP id tk12so7464820wjb.3 for ; Mon, 05 Dec 2016 13:58:07 -0800 (PST) X-Gm-Message-State: AKaTC00u7GAO/UBxjDha3dbShjYxjWT9Liv+9+qwpynkAYx36zjkgndK8frw8IWauj2Rnot1pup3bGbjnuqPFA== X-Received: by 10.194.112.196 with SMTP id is4mr59168182wjb.92.1480975087711; Mon, 05 Dec 2016 13:58:07 -0800 (PST) MIME-Version: 1.0 Received: by 10.80.129.227 with HTTP; Mon, 5 Dec 2016 13:57:47 -0800 (PST) In-Reply-To: <20161205181348.GA3129@ovn.org> References: <20161205170533.27981-1-russell@ovn.org> <20161205181043.GZ3129@ovn.org> <20161205181348.GA3129@ovn.org> From: Russell Bryant Date: Mon, 5 Dec 2016 16:57:47 -0500 X-Gmail-Original-Message-ID: Message-ID: To: Ben Pfaff X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,HTML_MESSAGE, RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org X-Content-Filtered-By: Mailman/MimeDel 2.1.12 Cc: ovs dev Subject: Re: [ovs-dev] [PATCH] ovn-controller(8): ovn-remote must be an IP adddress. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org On Mon, Dec 5, 2016 at 1:13 PM, Ben Pfaff wrote: > On Mon, Dec 05, 2016 at 10:10:43AM -0800, Ben Pfaff wrote: > > On Mon, Dec 05, 2016 at 12:05:33PM -0500, Russell Bryant wrote: > > > Document that the value of the ovn-remote configuration > > > option must be an IP address. This came up on IRC where > > > someone trying OVN put a hostname here and observed that > > > it did not work. > > > > > > Signed-off-by: Russell Bryant > > > --- > > > ovn/controller/ovn-controller.8.xml | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/ovn/controller/ovn-controller.8.xml b/ovn/controller/ovn- > controller.8.xml > > > index 5f51cb1..825a538 100644 > > > --- a/ovn/controller/ovn-controller.8.xml > > > +++ b/ovn/controller/ovn-controller.8.xml > > > @@ -93,7 +93,7 @@ > > >
> > >

> > > The OVN database that this system should connect to for its > > > - configuration. > > > + configuration. The value must be an IP address. > > >

> > > > Not an IP address but an OVSDB remote in the form tcp:ip[:port] or > > ssl:ip[:port]. > Ah yes. Thanks. > > Actually the documentation just below that paragraph is wrong too. > > Maybe something like this: > > diff --git a/ovn/controller/ovn-controller.8.xml b/ovn/controller/ovn- > controller.8.xml > index 5f51cb1..9f4dad1 100644 > --- a/ovn/controller/ovn-controller.8.xml > +++ b/ovn/controller/ovn-controller.8.xml > @@ -93,13 +93,8 @@ >
>

> The OVN database that this system should connect to for its > - configuration. > -

> - > -

> - Currently, ovn-controller does not support > changing this > - setting mid-run. If the value needs to change, the daemon must > be > - restarted. (This behavior should be improved.) > + configuration, in one of the same forms documented above for the > + ovs-database. >

>
> > I thought this option didn't take effect mid-run, but it's because there's a stale comment left in the code. I'll fix this up in v2. { diff --git a/ovn/controller/ovn-controller.c b/ovn/controller/ovn-controller.c index fea7841..4fbf455 100644 --- a/ovn/controller/ovn-controller.c +++ b/ovn/controller/ovn-controller.c @@ -204,10 +204,7 @@ get_chassis_id(const struct ovsdb_idl *ovs_idl) } /* Retrieves the OVN Southbound remote location from the - * "external-ids:ovn-remote" key in 'ovs_idl' and returns a copy of it. - * - * XXX ovn-controller does not support this changing mid-run, but that should - * be addressed later. */ + * "external-ids:ovn-remote" key in 'ovs_idl' and returns a copy of it. */ static char * get_ovnsb_remote(struct ovsdb_idl *ovs_idl)