From patchwork Mon Jun 5 19:01:08 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Russell Bryant X-Patchwork-Id: 771388 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3whPLX4BLbz9s3w for ; Tue, 6 Jun 2017 05:01:40 +1000 (AEST) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id CC24995E; Mon, 5 Jun 2017 19:01:35 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 334B694F for ; Mon, 5 Jun 2017 19:01:34 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id A9CB410E for ; Mon, 5 Jun 2017 19:01:33 +0000 (UTC) Received: from mfilter13-d.gandi.net (mfilter13-d.gandi.net [217.70.178.141]) by relay4-d.mail.gandi.net (Postfix) with ESMTP id 51A4B17209F for ; Mon, 5 Jun 2017 21:01:32 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mfilter13-d.gandi.net Received: from relay4-d.mail.gandi.net ([IPv6:::ffff:217.70.183.196]) by mfilter13-d.gandi.net (mfilter13-d.gandi.net [::ffff:10.0.15.180]) (amavisd-new, port 10024) with ESMTP id SIf1bD19i5wP for ; Mon, 5 Jun 2017 21:01:31 +0200 (CEST) X-Originating-IP: 209.85.216.172 Received: from mail-qt0-f172.google.com (mail-qt0-f172.google.com [209.85.216.172]) (Authenticated sender: russell@ovn.org) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id C4ADF17209D for ; Mon, 5 Jun 2017 21:01:30 +0200 (CEST) Received: by mail-qt0-f172.google.com with SMTP id u19so41555180qta.3 for ; Mon, 05 Jun 2017 12:01:30 -0700 (PDT) X-Gm-Message-State: AKS2vOwzeXyXGqdJDJ7xGBXUSoLMw0uvpaDsmuI9klbi29vExLENVO2m 9M4hxAnYq/z986HxGB90AHO2jS6yHA== X-Received: by 10.200.37.201 with SMTP id f9mr26450022qtf.138.1496689289324; Mon, 05 Jun 2017 12:01:29 -0700 (PDT) MIME-Version: 1.0 Received: by 10.140.93.99 with HTTP; Mon, 5 Jun 2017 12:01:08 -0700 (PDT) In-Reply-To: <1496675607-28619-1-git-send-email-dalvarez@redhat.com> References: <1496675607-28619-1-git-send-email-dalvarez@redhat.com> From: Russell Bryant Date: Mon, 5 Jun 2017 15:01:08 -0400 X-Gmail-Original-Message-ID: Message-ID: To: Daniel Alvarez X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Cc: ovs dev Subject: Re: [ovs-dev] [PATCH v2] Copy external_ids from Logical_Switch_Port to SB database X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org On Mon, Jun 5, 2017 at 11:13 AM, Daniel Alvarez wrote: > This patch makes ovn-northd copy all string-string pairs in > external_ids column of the Logical_Switch_Port table in Northbound > database to the equivalent column of the Port_Binding table in > Southbound database. > > OpenStack Neutron will add some useful data to NB database that can be > later read by networking-ovn-metadata-agent without the need of > maintaining a connection to NB database. This data would include > the CIDR's of a port or the project and device ID's which are needed > when talking to Nova to request metadata. > --- > ovn/northd/ovn-northd.c | 11 +++++++---- > ovn/ovn-nb.xml | 11 ++++++++++- > 2 files changed, 17 insertions(+), 5 deletions(-) > This looks good to me. Can you please append this doc addition and add your "Signed-off-by" to the patch? Thanks. diff --git a/ovn/ovn-sb.xml b/ovn/ovn-sb.xml index f3c3212..0e0fe12 100644 --- a/ovn/ovn-sb.xml +++ b/ovn/ovn-sb.xml @@ -2179,7 +2179,16 @@ tcp.flags = RST; - See External IDs at the beginning of this document. +

+ See External IDs at the beginning of this document. +

+ +

+ The ovn-northd program populates this column with + all entries into the column of the + table of the + database. +