Message ID | CA+0q_PgPKYwELen4Q6rgm9XEVhdL_n_Mex6Q_vFZxkcN2Wz+XQ@mail.gmail.com |
---|---|
State | Changes Requested |
Headers | show |
Thanks a lot Russel On Mon, Jun 5, 2017 at 9:01 PM, Russell Bryant <russell@ovn.org> wrote: > On Mon, Jun 5, 2017 at 11:13 AM, Daniel Alvarez <dalvarez@redhat.com> > wrote: > > This patch makes ovn-northd copy all string-string pairs in > > external_ids column of the Logical_Switch_Port table in Northbound > > database to the equivalent column of the Port_Binding table in > > Southbound database. > > > > OpenStack Neutron will add some useful data to NB database that can be > > later read by networking-ovn-metadata-agent without the need of > > maintaining a connection to NB database. This data would include > > the CIDR's of a port or the project and device ID's which are needed > > when talking to Nova to request metadata. > > --- > > ovn/northd/ovn-northd.c | 11 +++++++---- > > ovn/ovn-nb.xml | 11 ++++++++++- > > 2 files changed, 17 insertions(+), 5 deletions(-) > > > > This looks good to me. Can you please append this doc addition and > add your "Signed-off-by" to the patch? > Done in the v3 > > Thanks. > > diff --git a/ovn/ovn-sb.xml b/ovn/ovn-sb.xml > index f3c3212..0e0fe12 100644 > --- a/ovn/ovn-sb.xml > +++ b/ovn/ovn-sb.xml > @@ -2179,7 +2179,16 @@ tcp.flags = RST; > > <group title="Common Columns"> > <column name="external_ids"> > - See <em>External IDs</em> at the beginning of this document. > + <p> > + See <em>External IDs</em> at the beginning of this document. > + </p> > + > + <p> > + The <code>ovn-northd</code> program populates this column with > + all entries into the <ref column="external_ids"/> column of the > + <ref table="Logical_Switch_Port"/> table of the > + <ref db="OVN_Northbound"/> database. > + </p> > </column> > </group> > </table> >
diff --git a/ovn/ovn-sb.xml b/ovn/ovn-sb.xml index f3c3212..0e0fe12 100644 --- a/ovn/ovn-sb.xml +++ b/ovn/ovn-sb.xml @@ -2179,7 +2179,16 @@ tcp.flags = RST; <group title="Common Columns"> <column name="external_ids"> - See <em>External IDs</em> at the beginning of this document. + <p> + See <em>External IDs</em> at the beginning of this document. + </p> + + <p> + The <code>ovn-northd</code> program populates this column with + all entries into the <ref column="external_ids"/> column of the + <ref table="Logical_Switch_Port"/> table of the + <ref db="OVN_Northbound"/> database. + </p> </column> </group> </table>