| Message ID | 20240921063940.45672-1-sunyang.wu@jaguarmicro.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [ovs-dev] netdev-offload: Fix incorrect comments. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
On 21 Sep 2024, at 8:39, Sunyang Wu via dev wrote: > This patch fixes incorrect comments. > > Signed-off-by: Sunyang Wu <sunyang.wu@jaguarmicro.com> Hi Sunyang, Thanks for fixing this mistake. While you’re at it, maybe also align/fix the rest of the structure? How about: /* Offload-capable (HW) netdev information */ struct netdev_hw_info { - bool oor; /* Out of Offload Resources ? */ - atomic_bool miss_api_supported; /* hw_miss_packet_recover() supported.*/ - int offload_count; /* Pending (non-offloaded) flow count */ - int pending_count; /* Offloaded flow count */ + bool oor; /* Out of Offload Resources? */ + atomic_bool miss_api_supported; /* hw_miss_packet_recover() supported. */ + int offload_count; /* Offloaded flow count. */ + int pending_count; /* Pending (non-offloaded) flow count. */ OVSRCU_TYPE(void *) offload_data; /* Offload metadata. */ }; > --- > lib/netdev-offload.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/netdev-offload.h b/lib/netdev-offload.h > index 47f8e6f48..63d3ec5d3 100644 > --- a/lib/netdev-offload.h > +++ b/lib/netdev-offload.h > @@ -48,8 +48,8 @@ struct ovs_action_push_tnl; > struct netdev_hw_info { > bool oor; /* Out of Offload Resources ? */ > atomic_bool miss_api_supported; /* hw_miss_packet_recover() supported.*/ > - int offload_count; /* Pending (non-offloaded) flow count */ > - int pending_count; /* Offloaded flow count */ > + int offload_count; /* Offloaded flow count */ > + int pending_count; /* Pending (non-offloaded) flow count */ > OVSRCU_TYPE(void *) offload_data; /* Offload metadata. */ > }; > > -- > 2.19.0.rc0.windows.1 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
diff --git a/lib/netdev-offload.h b/lib/netdev-offload.h index 47f8e6f48..63d3ec5d3 100644 --- a/lib/netdev-offload.h +++ b/lib/netdev-offload.h @@ -48,8 +48,8 @@ struct ovs_action_push_tnl; struct netdev_hw_info { bool oor; /* Out of Offload Resources ? */ atomic_bool miss_api_supported; /* hw_miss_packet_recover() supported.*/ - int offload_count; /* Pending (non-offloaded) flow count */ - int pending_count; /* Offloaded flow count */ + int offload_count; /* Offloaded flow count */ + int pending_count; /* Pending (non-offloaded) flow count */ OVSRCU_TYPE(void *) offload_data; /* Offload metadata. */ };
This patch fixes incorrect comments. Signed-off-by: Sunyang Wu <sunyang.wu@jaguarmicro.com> --- lib/netdev-offload.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)