| Message ID | 20240712213010.1780089-3-mkp@redhat.com |
|---|---|
| State | Superseded |
| Delegated to: | Ilya Maximets |
| Headers | show |
| Series | [ovs-dev,v5,1/3] userspace: Adjust segment size on encapsulation. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
On Fri, Jul 12, 2024 at 11:30 PM Mike Pattrick <mkp@redhat.com> wrote: > > Previously the OVS support for checksum/TSO offloading didn't work well > with some network cards that supported VXLAN/Geneve tunnel TSO but not > outer UDP checksums. Now support for this configuration is improved and > we no longer need to disable the VXLAN/Geneve TSO flags from intel > hardware support flags. Not sure it is clear to anyone reading this commitlog. Maybe explain that restoring those capabilities makes it possible to do hw tso over tunnel, when tunnel csum is disabled? > > The modification to outer UDP offload is still required pending a future > DPDK release. Indeed, when the dpdk fixes are in, we can re-enable those capabilities (well, to be more precise, we can stop filtering broken capabilities) on those nics. > > Suggested-by: David Marchand <david.marchand@redhat.com> > Signed-off-by: Mike Pattrick <mkp@redhat.com> Reviewed-by: David Marchand <david.marchand@redhat.com>
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index 02cef6e45..95a78241d 100644 --- a/lib/netdev-dpdk.c +++ b/lib/netdev-dpdk.c @@ -1363,8 +1363,6 @@ dpdk_eth_dev_init(struct netdev_dpdk *dev) "net/ice, net/i40e or net/iavf port.", netdev_get_name(&dev->up)); info.tx_offload_capa &= ~RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM; - info.tx_offload_capa &= ~RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO; - info.tx_offload_capa &= ~RTE_ETH_TX_OFFLOAD_GENEVE_TNL_TSO; } if (info.tx_offload_capa & RTE_ETH_TX_OFFLOAD_IPV4_CKSUM) {
Previously the OVS support for checksum/TSO offloading didn't work well with some network cards that supported VXLAN/Geneve tunnel TSO but not outer UDP checksums. Now support for this configuration is improved and we no longer need to disable the VXLAN/Geneve TSO flags from intel hardware support flags. The modification to outer UDP offload is still required pending a future DPDK release. Suggested-by: David Marchand <david.marchand@redhat.com> Signed-off-by: Mike Pattrick <mkp@redhat.com> --- lib/netdev-dpdk.c | 2 -- 1 file changed, 2 deletions(-)