From patchwork Fri Jun 7 09:30:55 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Kalcok X-Patchwork-Id: 1944989 X-Patchwork-Delegate: horms@verge.net.au Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=canonical.com header.i=@canonical.com header.a=rsa-sha256 header.s=20210705 header.b=VXaL2sq8; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.136; helo=smtp3.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VwbYT2Vnxz20Q5 for ; Fri, 7 Jun 2024 19:31:25 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id B818B61510; Fri, 7 Jun 2024 09:31:23 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id DDDu_a3dRoAw; Fri, 7 Jun 2024 09:31:22 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.9.56; helo=lists.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 7F651614F0 Authentication-Results: smtp3.osuosl.org; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=canonical.com header.i=@canonical.com header.a=rsa-sha256 header.s=20210705 header.b=VXaL2sq8 Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp3.osuosl.org (Postfix) with ESMTPS id 7F651614F0; Fri, 7 Jun 2024 09:31:22 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 48E2CC0012; Fri, 7 Jun 2024 09:31:22 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 7254FC0011 for ; Fri, 7 Jun 2024 09:31:21 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 5452040B09 for ; Fri, 7 Jun 2024 09:31:21 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id zuPoQhALo3ri for ; Fri, 7 Jun 2024 09:31:20 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=185.125.188.121; helo=smtp-relay-canonical-1.canonical.com; envelope-from=martin.kalcok@canonical.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org 4305640103 Authentication-Results: smtp2.osuosl.org; dmarc=pass (p=none dis=none) header.from=canonical.com DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 4305640103 Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=canonical.com header.i=@canonical.com header.a=rsa-sha256 header.s=20210705 header.b=VXaL2sq8 Received: from smtp-relay-canonical-1.canonical.com (smtp-relay-canonical-1.canonical.com [185.125.188.121]) by smtp2.osuosl.org (Postfix) with ESMTPS id 4305640103 for ; Fri, 7 Jun 2024 09:31:19 +0000 (UTC) Received: from omen-desktop.. (178-143-45-0.static.orange.sk [178.143.45.0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-1.canonical.com (Postfix) with ESMTPSA id 756883F0F9; Fri, 7 Jun 2024 09:31:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1717752677; bh=FJPcOB1d3Mj4ELlyOdbRGdcaHjdCGrUh3K0vyBkuSU0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=VXaL2sq8FDB/BAGp6RYhpMyfW9hqXMje3t+MzrMVqiFUk4Y7KGRCkzj+LpVxVguE+ VEhjn4qYmPLyh43CuAcaH/iYveWfCzImMO1y9jHys+kOGA6PvCE+yTpWvLHQnLGEOi G518AUiaCvU2X/hs2SRAUSAAi7t1n2RZ6AIhpXJJvnl9A1syfqqLHqYxkOPS9d4euI R5y830pc4Th8SKGa6NNz59MuJseAuDY5M+paRSQt71inaZM6P+NAgS8VPuOxD2/MXp CggLoS/REjEDJ6ObKFpkaXwSc67DC6T+zTfrR6gw4D+EzstrvUlR1TMqzztXu4/5oi bXY3bPA24qwlA== From: Martin Kalcok To: i.maximets@ovn.org, horms@ovn.org, dev@openvswitch.org Date: Fri, 7 Jun 2024 11:30:55 +0200 Message-Id: <20240607093055.160537-1-martin.kalcok@canonical.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <0ead0188-36b5-4184-a98a-265da41faa82@ovn.org> References: <0ead0188-36b5-4184-a98a-265da41faa82@ovn.org> MIME-Version: 1.0 Subject: [ovs-dev] [Patch v2] ovsdb-client: Add "COLUMN" arg to help for 'dump'. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" Help text for 'ovsdb-client dump' does not mention that it's capable of dumping a specific column's contents if the user supplies the column's name as a fourth positional argument. Signed-off-by: Martin Kalcok Acked-by: Simon Horman --- ovsdb/ovsdb-client.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ovsdb/ovsdb-client.c b/ovsdb/ovsdb-client.c index cf2ecfd08..b7b189c7e 100644 --- a/ovsdb/ovsdb-client.c +++ b/ovsdb/ovsdb-client.c @@ -451,9 +451,9 @@ usage(void) " wait until DATABASE reaches STATE " "(\"added\" or \"connected\" or \"removed\")\n" " in DATBASE on SERVER.\n" - "\n dump [SERVER] [DATABASE] [TABLE]\n" - " dump contents of TABLE (or all tables) in DATABASE on SERVER\n" - " to stdout\n" + "\n dump [SERVER] [DATABASE] [TABLE [COLUMN]...]\n" + " dump contents of COLUMNs, TABLE (or all tables) in DATABASE\n" + " on SERVER to stdout\n" "\n backup [SERVER] [DATABASE] > SNAPSHOT\n" " dump database contents in the form of a database file\n" "\n [--force] restore [SERVER] [DATABASE] < SNAPSHOT\n"