diff mbox series

[ovs-dev] system-dpdk: tolerate new warnings 23.11.1/24.03

Message ID 20240605104439.792449-1-christian.ehrhardt@canonical.com
State Superseded
Delegated to: Kevin Traynor
Headers show
Series [ovs-dev] system-dpdk: tolerate new warnings 23.11.1/24.03 | expand

Checks

Context Check Description
ovsrobot/apply-robot warning apply and check: warning
ovsrobot/github-robot-_Build_and_Test success github build: passed
ovsrobot/intel-ovs-compilation success test: success

Commit Message

Christian Ehrhardt June 5, 2024, 10:44 a.m. UTC
From: Christian Ehrhardt <christian.ehrhardt@canonical.com>

DPDK fixed counting of telemetry clients in 24.03 [1] which was also
backported to 23.11.1 [2]. Due to that the dpdk related openvswitch
tests now fail in the following cases:
  4: OVS-DPDK - ping vhost-user ports FAILED (system-dpdk.at:148)
  5: OVS-DPDK - ping vhost-user-client ports FAILED (system-dpdk.at:224)
  16: OVS-DPDK - MTU increase vport port FAILED (system-dpdk.at:609)
  17: OVS-DPDK - MTU decrease vport port FAILED (system-dpdk.at:651)
  20: OVS-DPDK - MTU upper bound vport port FAILED (system-dpdk.at:767)
  21: OVS-DPDK - MTU lower bound vport port FAILED (system-dpdk.at:809)

This is due to a new error being logged in those conditions.
  dpdk|ERR|TELEMETRY: Socket write base info to client failed

This is ok to happen in the cases we set up in the DPDK related tests
for OVS and can be ignored, therefore it is added to the tolerated
messages in the m4 definition of OVS_DPDK_STOP_VSWITCHD.

[1]: https://github.com/DPDK/dpdk/commit/e14bb5f1
[2]: https://github.com/DPDK/dpdk-stable/commit/cbd1c165

Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
---
 tests/system-dpdk-macros.at | 1 +
 1 file changed, 1 insertion(+)

Comments

Christian Ehrhardt June 5, 2024, 10:50 a.m. UTC | #1
On Wed, Jun 5, 2024 at 12:44 PM <christian.ehrhardt@canonical.com> wrote:
>
> From: Christian Ehrhardt <christian.ehrhardt@canonical.com>

To add some more context which didn't fit the commit message (a.k.a I
shamefully forgot to add a cover letter :-/)

I've seen the discussion on [1] planning to add support for 23.11.1
And the referred patch set of David [2] is empty right now.
There even was the change to refer to 23.11.1 in [3][4]

So I wonder if that particular error is only thrown when the
auto-tests of OVS run in the environment Ubuntu has for autopkgtest as
it was spotted there initially [5].
But TBH after some diving into the test framework [6] I could recreate
the issue quite easily, so I wonder why it hasn't been seen yet.

Generally the question I can't answer without you, is this indeed a
message that can be ignored in that environment.
Or is it actually a signal of a legit issue we'd need to find and fix?

[1]: https://mail.openvswitch.org/pipermail/ovs-dev/2024-May/414129.html
[2]: https://patchwork.ozlabs.org/project/openvswitch/list/?series=403694
[3]: https://mail.openvswitch.org/pipermail/ovs-dev/2024-May/414231.html
[4]: https://mail.openvswitch.org/pipermail/ovs-dev/2024-May/414234.html
[5]: https://autopkgtest.ubuntu.com/results/autopkgtest-oracular/oracular/amd64/o/openvswitch/20240531_100906_6f957@/log.gz
[6]: https://bugs.launchpad.net/ubuntu/+source/openvswitch/+bug/2067889

> DPDK fixed counting of telemetry clients in 24.03 [1] which was also
> backported to 23.11.1 [2]. Due to that the dpdk related openvswitch
> tests now fail in the following cases:
>   4: OVS-DPDK - ping vhost-user ports FAILED (system-dpdk.at:148)
>   5: OVS-DPDK - ping vhost-user-client ports FAILED (system-dpdk.at:224)
>   16: OVS-DPDK - MTU increase vport port FAILED (system-dpdk.at:609)
>   17: OVS-DPDK - MTU decrease vport port FAILED (system-dpdk.at:651)
>   20: OVS-DPDK - MTU upper bound vport port FAILED (system-dpdk.at:767)
>   21: OVS-DPDK - MTU lower bound vport port FAILED (system-dpdk.at:809)
>
> This is due to a new error being logged in those conditions.
>   dpdk|ERR|TELEMETRY: Socket write base info to client failed
>
> This is ok to happen in the cases we set up in the DPDK related tests
> for OVS and can be ignored, therefore it is added to the tolerated
> messages in the m4 definition of OVS_DPDK_STOP_VSWITCHD.
>
> [1]: https://github.com/DPDK/dpdk/commit/e14bb5f1
> [2]: https://github.com/DPDK/dpdk-stable/commit/cbd1c165
>
> Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> ---
>  tests/system-dpdk-macros.at | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tests/system-dpdk-macros.at b/tests/system-dpdk-macros.at
> index 7cf9bac17..64e5ad522 100644
> --- a/tests/system-dpdk-macros.at
> +++ b/tests/system-dpdk-macros.at
> @@ -82,6 +82,7 @@ $1";/does not exist. The Open vSwitch kernel module is probably not loaded./d
>  /Failed to enable flow control/d
>  /ice_vsi_config_outer_vlan_stripping(): Single VLAN mode (SVM) does not support qinq/d
>  /Rx checksum offload is not supported on/d
> +/TELEMETRY: Socket write base info to client failed/d
>  /TELEMETRY: No legacy callbacks, legacy socket not created/d"])
>  ])
>
> --
> 2.43.0
>
diff mbox series

Patch

diff --git a/tests/system-dpdk-macros.at b/tests/system-dpdk-macros.at
index 7cf9bac17..64e5ad522 100644
--- a/tests/system-dpdk-macros.at
+++ b/tests/system-dpdk-macros.at
@@ -82,6 +82,7 @@  $1";/does not exist. The Open vSwitch kernel module is probably not loaded./d
 /Failed to enable flow control/d
 /ice_vsi_config_outer_vlan_stripping(): Single VLAN mode (SVM) does not support qinq/d
 /Rx checksum offload is not supported on/d
+/TELEMETRY: Socket write base info to client failed/d
 /TELEMETRY: No legacy callbacks, legacy socket not created/d"])
 ])