Message ID | 20240604092324.66610-1-svc.ovs-community@vmware.com |
---|---|
State | Superseded |
Headers | show |
Series | [ovs-dev,v1,1/1] datapath-windows : Avoid a deadlock when processing TFTP conntrack. | expand |
Context | Check | Description |
---|---|---|
ovsrobot/apply-robot | warning | apply and check: warning |
ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
ovsrobot/intel-ovs-compilation | success | test: success |
References: <20240604092324.66610-1-svc.ovs-community@vmware.com> Bleep bloop. Greetings Wilson Peng, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Wilson Peng <pweisong@vmware.com> needs to sign off. WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: Wilson Peng <svc.ovs-community@vmware.com> Lines checked: 82, Warnings: 1, Errors: 1 Please check this out. If you feel there has been an error, please email aconole@redhat.com Thanks, 0-day Robot
diff --git a/datapath-windows/ovsext/Conntrack.c b/datapath-windows/ovsext/Conntrack.c index 39ba5cc10..ae91ed18e 100644 --- a/datapath-windows/ovsext/Conntrack.c +++ b/datapath-windows/ovsext/Conntrack.c @@ -1033,9 +1033,15 @@ OvsProcessConntrackEntry(OvsForwardingContext *fwdCtx, } else { POVS_CT_ENTRY parentEntry; parentEntry = OvsCtRelatedLookup(ctx->key, currentTime); - entry->parent = parentEntry; - if (parentEntry != NULL) { - state |= OVS_CS_F_RELATED; + if (((layers->isIPv6 && key->ipv6Key.nwProto == IPPROTO_UDP) || + (!(layers->isIPv6) && key->ipKey.nwProto == IPPROTO_UDP)) && + (parentEntry == entry)) { + /* Do nothing here, it would deadlock for invalid tftp packet*/ + } else { + entry->parent = parentEntry; + if (parentEntry != NULL) { + state |= OVS_CS_F_RELATED; + } } } }