From patchwork Mon May 27 11:00:33 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Roi Dayan X-Patchwork-Id: 1939849 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=sgMhjCAp; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.133; helo=smtp2.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Vnt481C7sz20KL for ; Mon, 27 May 2024 21:01:11 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 4E05D4029B; Mon, 27 May 2024 11:01:10 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 5cDNh4XDSBVO; Mon, 27 May 2024 11:01:09 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=2605:bc80:3010:104::8cd3:938; helo=lists.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 1FEFD40144 Authentication-Results: smtp2.osuosl.org; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=sgMhjCAp Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp2.osuosl.org (Postfix) with ESMTPS id 1FEFD40144; Mon, 27 May 2024 11:01:09 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id F05CFC0072; Mon, 27 May 2024 11:01:08 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 66202C0037 for ; Mon, 27 May 2024 11:01:07 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 5273840310 for ; Mon, 27 May 2024 11:01:07 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id PnGy6N9AHTeM for ; Mon, 27 May 2024 11:01:06 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2a01:111:f403:2415::600; helo=nam11-dm6-obe.outbound.protection.outlook.com; envelope-from=roid@nvidia.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org DD3DF402D7 Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org DD3DF402D7 Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=sgMhjCAp Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on20600.outbound.protection.outlook.com [IPv6:2a01:111:f403:2415::600]) by smtp4.osuosl.org (Postfix) with ESMTPS id DD3DF402D7 for ; Mon, 27 May 2024 11:01:05 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Egbijy6PQ406c+V37A/DKQUVQWJHRaZRFQBTrQoGWxPN01fD4ObCjIFbrXA7mMsI764EBxwKCAaEBJIMekNwDL74sYa+iXeYsLngg/qpafoJiDzv6ErKpD8NVFQYC8IHW6+Ao6nse6hisSfcZsWFsZ5TjJ0cwah4nkKOCxqIGx55nL/0SpUhckUl5qnedL1ASIEuEp+2DbB5a33cXJ4ZfbBLj28hciOzrLsMzv4OhxK7nENVG9oKnDYGf2FL+pCw3WysDDvo8lWv4FtzS/a50EF4LUscb9dWP5vKSr3F71CcPM+b7qeWOW+YRKWzT32xUKmoIsbYNjuaalOq53aWwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s1ZTdS2k/y5mudIrXzKqO+mzZnUWBy0Qx59DHfB6T5g=; b=kGz5dl72PXZk0luZ38kmJBWoOlDmfk4IlLZrrgPaiJMv/9SEALaV/LojGbUMp11ay1A7GmtSpfJI54UYkxsPSfaSySrEsgcx+f/lHHzZD/SGXRObri1V2OFFs2OlKfix/zAC0lsnX0CwDp+DVIhPhwLt79Jq9YbynGiwHYVs2Mih4mG4uw4uR1KQRzMikiNKs2IU12D7gsawKowBW1uo6nkjZawewKRFpPpAYJaFCY7c9fp19XHELPZkL/HWuQp1B+FTNhE1SA1h0v7bDRbQxYLhp2hAnFrUV7JeACDjloJObNyRWw0mvcDxRidp4w98s5XEBlHZNId5Q5ohrF0Pqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=openvswitch.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s1ZTdS2k/y5mudIrXzKqO+mzZnUWBy0Qx59DHfB6T5g=; b=sgMhjCAp3w/oiaACFwvgkI+TMQm0bshZx8fYQc3bsrcBnoLwV44B4Tsw0xzmQ6Sr/eUUUErNC3C8sdoHvF0KMfuwwR6tQNtDhgus15dsV+uwBerx2Ard5LfGe5D7Z9N7SeLwl1blF/zMR7PAbLW962eGIaaG28K4cyqOA0Vao6MFP6BT7t/DkFw4twdLWOnFdWwFYojU8pEFhaQa54pJRIgwka4/siLRq55o9FUjuN6qgbK5x5gshcgk2CY5YTAfMdDOpHXdhKfXS0hy5oJXcL5+jLxr0dcFvHkDZsqJIKAC6E45GDBlvme5zA4aF94pu5Bpxd1GrRzctq4UfitJOg== Received: from BY5PR03CA0002.namprd03.prod.outlook.com (2603:10b6:a03:1e0::12) by PH7PR12MB6468.namprd12.prod.outlook.com (2603:10b6:510:1f4::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7611.29; Mon, 27 May 2024 11:00:59 +0000 Received: from SJ5PEPF000001E9.namprd05.prod.outlook.com (2603:10b6:a03:1e0:cafe::c) by BY5PR03CA0002.outlook.office365.com (2603:10b6:a03:1e0::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7611.29 via Frontend Transport; Mon, 27 May 2024 11:00:59 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by SJ5PEPF000001E9.mail.protection.outlook.com (10.167.242.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.15 via Frontend Transport; Mon, 27 May 2024 11:00:58 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 27 May 2024 04:00:43 -0700 Received: from rnnvmail203.nvidia.com (10.129.68.9) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 27 May 2024 04:00:42 -0700 Received: from mtr-vdi-198.wap.labs.mlnx (10.127.8.13) by mail.nvidia.com (10.129.68.9) with Microsoft SMTP Server id 15.2.1544.4 via Frontend Transport; Mon, 27 May 2024 04:00:41 -0700 To: Date: Mon, 27 May 2024 14:00:33 +0300 Message-ID: <20240527110033.531720-2-roid@nvidia.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240527110033.531720-1-roid@nvidia.com> References: <20240527110033.531720-1-roid@nvidia.com> MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001E9:EE_|PH7PR12MB6468:EE_ X-MS-Office365-Filtering-Correlation-Id: 0dee9403-9fa4-4710-c433-08dc7e3c4a25 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230031|1800799015|82310400017|376005|36860700004; X-Microsoft-Antispam-Message-Info: =?utf-8?q?4nVYnZkF+NeJwpXVTbgOmqaSsX1rTTP?= =?utf-8?q?kM+gJ5OgOug00e00NrfQbG3P1JgkrFVoIMwl7p+G/hwGxGaL0UlxQKyn+JBVjdnG1?= =?utf-8?q?vEWn6n7CmCq2k/ORf59Q/SwQQX9srSszI58pd1cTg9diopjqUBN+rgOeoyZYA5Fw1?= =?utf-8?q?GFnk6wj+pbu7i0oc7/2M2GjpJMXDInpjEKTHZXrGD4IsOj5cXB+TSA751EV1VK6+a?= =?utf-8?q?PeWb/psntOqRWmQRaFhU9LEEM9oy3omlljiIKFG+aYKhIcJW+hzoT+BoG20zElaqT?= =?utf-8?q?7pMPMF8LWDpwOAyUZcBtpxA5XxwOcXm4xtoL3FreB9rzlQ14UnC7GpWPaZ8B4BNzx?= =?utf-8?q?tvYITXDCIetIMYmazL3csnAgw7iNOj91395cz/0xbkWnx1fTr8i4sj9jZdLgUxE5i?= =?utf-8?q?ZmgkncMPRXo2o69bpQwgw8hGmR6VSop3M2OOY39plYOiFaAwOwGu9wTGQ8HCl6Cqi?= =?utf-8?q?Eo9E0dRHNHxH+uHRg4fdEzegPU174dMlrX345uGq9w1scwkhuxuPOjn2be0GFPyc5?= =?utf-8?q?3dzBeQnjM6ZcnGOoSpRcyrUQqX53furY2DOP36AAj5VTXTr5VAbH8oiZrrV8mQVUE?= =?utf-8?q?7EDpVjoRHqRSTesdfYBsJGDZFC9amiBigymGN1HvRPnMVUilLZ8Svkns5JnrDfs+6?= =?utf-8?q?qn5oAb3MUq4tHczfA+nqNDG6RXsMeau3i1G8ZM9adQAn+sOw+q9VsEdzVQqaXrIcJ?= =?utf-8?q?GOdSCjURlyQzt1F1cocC88jvfkGVee5MCcgRqlhQ3Lav4EmySIyXBuaj0KsLHIStE?= =?utf-8?q?iC/LuYRVNbafYNPnNpHh5djpOjxb0/HM60UqET2obKD1FIoAkn99V+obEBDM8Pffq?= =?utf-8?q?s36scQ1gWVVes5MVIcUP8JUd7r+FdDk8xQrkRFBlbLjC5HJxybB2m2Ui3GkCKyDg2?= =?utf-8?q?EP020gHkvevcGjWKmuyDeLhZ3JmYm8Xq6BWKffbFC/kNkNI1oCw5B2zGNCsUvulMF?= =?utf-8?q?3nlgTXefLyCmSmDmGAXo0EWZuZaXt5AELTVKZ3Y41O46+WbEQdG26FhdkCIooP3KM?= =?utf-8?q?E9kTXEHImrkGEFijiqQjxIPUYaVkiDoRvcqXidrSNsBJFI0z8/QQemmEJwEzo6E70?= =?utf-8?q?oVrzhJI1PioGDcDHoZyvWcJ7NZj2vm9U1s5HlztmiAQ/3yuMrHAVplC2+8l5y8yIz?= =?utf-8?q?JqpKYNnXQP7FwwYClzcy35EcYfBxJXPhrLTIXBhbiXhiZ6Ot1MWDy0wn1WExQ6ern?= =?utf-8?q?yZSaa5f395EjSNt7FnRCb868zX9FTSyPBOBO4v/BiCkDYhDD6zx2LBfRCYRWhxo7g?= =?utf-8?q?BCNIruUJINsEjQcCdx6UgdALqSVgptkxIcRfZUgG5znIvwxAkApVS+OJVHLCygqy/?= =?utf-8?q?9bteRXaG4edH?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230031)(1800799015)(82310400017)(376005)(36860700004); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 May 2024 11:00:58.5644 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0dee9403-9fa4-4710-c433-08dc7e3c4a25 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001E9.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6468 Cc: Maor Dickman Subject: [ovs-dev] [PATCH 2/2] netdev-linux: Fix ethtool_cmd is partly outside array bounds. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Roi Dayan via dev From: Roi Dayan Reply-To: Roi Dayan Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" Used Ubuntu with gcc (Ubuntu 11.2.0-19ubuntu1) 11.2.0 lib/netdev-linux.c: In function ‘netdev_linux_construct’: lib/netdev-linux.c:7003:15: error: array subscript ‘struct ethtool_cmd[0]’ is partly outside array bounds of ‘union [1]’ [-Werror=array-bounds] 7003 | ecmd->cmd = cmd; | ~~~~~~~~~~^~~~~ lib/netdev-linux.c:2411:7: note: while referencing ‘sset_info’ 2411 | } sset_info; | ^~~~~~~~~ Fixes: 6c59c195266c ("netdev-linux: Use ethtool to detect offload support.") Signed-off-by: Roi Dayan --- lib/netdev-linux.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c index 0cb379295af1..ec6fcf7b2c6a 100644 --- a/lib/netdev-linux.c +++ b/lib/netdev-linux.c @@ -2402,6 +2402,7 @@ static int netdev_linux_read_stringset_info(struct netdev_linux *netdev, uint32_t *len) { union { + struct ethtool_cmd ecmd; struct ethtool_sset_info hdr; struct { uint64_t pad[2];