Message ID | 20240502111339.1699744-1-amusil@redhat.com |
---|---|
State | Accepted |
Commit | 855df0ad25a819d03c578ef39803695fcfebb429 |
Delegated to: | Ilya Maximets |
Headers | show |
Series | [ovs-dev] sparse: Add additional define for sparse on GCC >= 14. | expand |
Context | Check | Description |
---|---|---|
ovsrobot/apply-robot | success | apply and check: success |
ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
ovsrobot/intel-ovs-compilation | fail | test: fail |
On Thu, May 02, 2024 at 01:13:39PM +0200, Ales Musil wrote: > GCC 14 renamed one of the AVX512 defines to have only single > underscore instead of two [0]. Add the single underscore define to > keep compatibility with multiple GCC versions. > > [0] https://github.com/gcc-mirror/gcc/commit/aea8e4105553cd16799f2134d15420ccf182d732 > Tested-by: Dumitru Ceara <dceara@redhat.com> > Signed-off-by: Ales Musil <amusil@redhat.com> Acked-by: Simon Horman <horms@ovn.org>
On 5/3/24 13:42, Simon Horman wrote: > On Thu, May 02, 2024 at 01:13:39PM +0200, Ales Musil wrote: >> GCC 14 renamed one of the AVX512 defines to have only single >> underscore instead of two [0]. Add the single underscore define to >> keep compatibility with multiple GCC versions. >> >> [0] https://github.com/gcc-mirror/gcc/commit/aea8e4105553cd16799f2134d15420ccf182d732 >> Tested-by: Dumitru Ceara <dceara@redhat.com> >> Signed-off-by: Ales Musil <amusil@redhat.com> > > Acked-by: Simon Horman <horms@ovn.org> > Thanks, Ales, Dumitru and Simon! Applied to all branches down to 2.17 since it is needed for a successful build. Best regards, Ilya Maximets.
diff --git a/include/sparse/immintrin.h b/include/sparse/immintrin.h index dd742be9f..36b41d352 100644 --- a/include/sparse/immintrin.h +++ b/include/sparse/immintrin.h @@ -26,5 +26,9 @@ #define _KEYLOCKERINTRIN_H_INCLUDED #define __AVX512FP16INTRIN_H_INCLUDED #define __AVX512FP16VLINTRIN_H_INCLUDED +/* GCC >=14 changed the "__AVX512FP16INTRIN_H_INCLUDED" to have only single + * underscore. We need both to keep compatibility between various GCC + * versions. */ +#define _AVX512FP16INTRIN_H_INCLUDED #include_next <immintrin.h>