| Message ID | 20240409195512.2642661-1-i.maximets@ovn.org |
|---|---|
| State | Accepted |
| Commit | a35fc4ae5b4d80692022381c4bd39eecb766b5d4 |
| Delegated to: | Ilya Maximets |
| Headers | show |
| Series | [ovs-dev] checkpatch: Don't spellcheck names in tags. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
On 9 Apr 2024, at 21:55, Ilya Maximets wrote: > Current code checks spelling of names in commit message tags and that > makes no sense. > > Most of the tags are explicitly handled, but tags like 'Tested-by' or > other lesser used ones are falling through to the spellchecker and > need to be excluded. > > Signed-off-by: Ilya Maximets <i.maximets@ovn.org> Thanks for the enhancement. Acked-by: Eelco Chaudron <echaudro@redhat.com>
On 4/10/24 11:37, Eelco Chaudron wrote: > > > On 9 Apr 2024, at 21:55, Ilya Maximets wrote: > >> Current code checks spelling of names in commit message tags and that >> makes no sense. >> >> Most of the tags are explicitly handled, but tags like 'Tested-by' or >> other lesser used ones are falling through to the spellchecker and >> need to be excluded. >> >> Signed-off-by: Ilya Maximets <i.maximets@ovn.org> > > Thanks for the enhancement. > > Acked-by: Eelco Chaudron <echaudro@redhat.com> > Applied. Thanks! Best regards, Ilya Maximets.
diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py index 692bb88d4..5a41bbef7 100755 --- a/utilities/checkpatch.py +++ b/utilities/checkpatch.py @@ -442,7 +442,8 @@ def check_spelling(line, comment): if not spell_check_dict or not spellcheck: return False - if line.startswith('Fixes: '): + is_name_tag = re.compile(r'^\s*([a-z-]+-by): (.*@.*)$', re.I | re.M | re.S) + if line.startswith('Fixes: ') or is_name_tag.match(line): return False words = filter_comments(line, True) if comment else line
Current code checks spelling of names in commit message tags and that makes no sense. Most of the tags are explicitly handled, but tags like 'Tested-by' or other lesser used ones are falling through to the spellchecker and need to be excluded. Signed-off-by: Ilya Maximets <i.maximets@ovn.org> --- utilities/checkpatch.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)