From patchwork Fri Jan 26 13:20:41 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jakob Meng X-Patchwork-Id: 1891314 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=JLnEHPwI; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=2605:bc80:3010::133; helo=smtp2.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org) Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4TLyxm1BfLz23f9 for ; Sat, 27 Jan 2024 00:20:59 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id F012C4044A; Fri, 26 Jan 2024 13:20:57 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org F012C4044A Authentication-Results: smtp2.osuosl.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=JLnEHPwI X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VMLJFjIkrMB5; Fri, 26 Jan 2024 13:20:56 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp2.osuosl.org (Postfix) with ESMTPS id 85C26400D9; Fri, 26 Jan 2024 13:20:55 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 85C26400D9 Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 50D57C0072; Fri, 26 Jan 2024 13:20:55 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 3303BC0037 for ; Fri, 26 Jan 2024 13:20:54 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 0889A83D71 for ; Fri, 26 Jan 2024 13:20:54 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 0889A83D71 Authentication-Results: smtp1.osuosl.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=JLnEHPwI X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oprqRf_ky3rJ for ; Fri, 26 Jan 2024 13:20:53 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by smtp1.osuosl.org (Postfix) with ESMTPS id 2D7E183D08 for ; Fri, 26 Jan 2024 13:20:52 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 2D7E183D08 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706275251; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=3CMIlWuQF0FqjdZmBhBHxBpVMgryIkpDqu8n3ok1l5g=; b=JLnEHPwItV6Mi1PQbIiqBVoM23b252Qbwlo1ZTxuO0+FanYKh4cRPo4JW/P2BK8AeYDGKA pBKSQRfUDHW5KbsBmsUTmgStwBP5M7mBp6ZNCCerZw08oQM1H6w/WsHzFHnaq6i5sndRXQ L6quBv1JuHMc5rZWBw4x3jwgH2/H6FI= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-103-dBcKMQK4Oo24N0pC-uoP0A-1; Fri, 26 Jan 2024 08:20:50 -0500 X-MC-Unique: dBcKMQK4Oo24N0pC-uoP0A-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3392814b911so169333f8f.1 for ; Fri, 26 Jan 2024 05:20:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706275249; x=1706880049; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3CMIlWuQF0FqjdZmBhBHxBpVMgryIkpDqu8n3ok1l5g=; b=U3sNJsdF4dtLIgdtMWo/8DjsBe9zoibXVlGZ1+7EVQuzF1C6h4N9icOLV4VI6+egda 5JbmokbgGKyubLfAHtMLKLg28b4BVBox1LZYqHyXmMZkDtJtWem9qPtDRZTWFpF3a87w hkEpl63UfQMO1iGdDYYmVW7QQejOeHe82BTvCG9TbxRMXsmQvk4cT0lRXFhpoB3QHCqX 2X9mz1ZlyVHWQjTtRBqZp2jg9g1FX0LBbbTrW5u/5kMHgayI6nyc39GwCKUJHahDB8Ek CkSkjZqnjaMjOItXQ7Hx3P/79RObaF2ZQ+xb5rEU9R/iEBC+0wkNwAhTO1oreazUMEj/ d6vA== X-Gm-Message-State: AOJu0Yx4YFfJAbxma1XlwyOrxqCTHEmCzAuPDyTStCRVO9FoXRIrTMc2 GIUezMgu07/GYW1kDetpSmSPtpz1Rn4G4nPv24tPA2ZcbVc5IhnTZtKHImfqmjc5kFRc6YMLEUz zsb97Oton6OLQCT0PXpQwEwmmT2IMbcpgWmj6N2FQG44EpLNgu+hoNvwfroZDnYn0vrTbe9dm/A I6oZe6WEWkTHVt/iSld7FiHNlVnzf/ X-Received: by 2002:a05:6000:36f:b0:337:b9ad:14d with SMTP id f15-20020a056000036f00b00337b9ad014dmr548380wrf.19.1706275249508; Fri, 26 Jan 2024 05:20:49 -0800 (PST) X-Google-Smtp-Source: AGHT+IGQIMUkXixZJxGVFH0VX0SoXdVSvLEtz/4qqYjIqbB/XfX3HQ0KvHAm1gxQudUfWhHLQ70Lwg== X-Received: by 2002:a05:6000:36f:b0:337:b9ad:14d with SMTP id f15-20020a056000036f00b00337b9ad014dmr548369wrf.19.1706275249112; Fri, 26 Jan 2024 05:20:49 -0800 (PST) Received: from positronik4lide.redhat.com ([87.122.59.226]) by smtp.gmail.com with ESMTPSA id g4-20020a5d46c4000000b0033763a9ea2dsm1260585wrs.63.2024.01.26.05.20.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jan 2024 05:20:48 -0800 (PST) From: jmeng@redhat.com To: dev@openvswitch.org, i.maximets@ovn.org, amusil@redhat.com Date: Fri, 26 Jan 2024 14:20:41 +0100 Message-Id: <20240126132041.24299-1-jmeng@redhat.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: [ovs-dev] [PATCH] dpif-netdev: Increase MAX_RECIRC_DEPTH to 8. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" From: Jakob Meng In a scenario where OVN does load balancing and then SNAT with a OVS userspace datapath [0], the recirc_depth may be greater than 6. In that case, ovs-vswitchd might drop packets and raise warnings: dpif_netdev|WARN|Packet dropped. Max recirculation depth exceeded. Increasing MAX_RECIRC_DEPTH to 8 solves this issue. [0] https://github.com/ovn-org/ovn/blob/dd5cd73e3df1bfb1a215cb45d1e2e03eff1d049a/tests/system-ovn-kmod.at#L740 Reported-at: https://issues.redhat.com/browse/FDP-251 Signed-off-by: Jakob Meng --- ovs/lib/dpif-netdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ovs/lib/dpif-netdev.c b/ovs/lib/dpif-netdev.c index c1981137f9..46e24d204d 100644 --- a/ovs/lib/dpif-netdev.c +++ b/ovs/lib/dpif-netdev.c @@ -99,7 +99,7 @@ VLOG_DEFINE_THIS_MODULE(dpif_netdev); #define FLOW_DUMP_MAX_BATCH 50 /* Use per thread recirc_depth to prevent recirculation loop. */ -#define MAX_RECIRC_DEPTH 6 +#define MAX_RECIRC_DEPTH 8 DEFINE_STATIC_PER_THREAD_DATA(uint32_t, recirc_depth, 0) /* Use instant packet send by default. */