| Message ID | 20231004082628.28712-1-jmeng@redhat.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | [ovs-dev,1/3] netdev-dpdk: Document status options for VF MAC address. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | warning | apply and check: warning |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
| ovsrobot/intel-ovs-compilation | success | test: success |
On Wed, Oct 04, 2023 at 10:26:29AM +0200, jmeng@redhat.com wrote: > From: Jakob Meng <code@jakobmeng.de> > > Fixes: f4336f504b17 ("netdev-dpdk: Add option to configure VF MAC address. ") Acked-by: Simon Horman <horms@ovn.org>
Bleep bloop. Greetings Jakob Meng, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Jakob Meng <code@jakobmeng.de> needs to sign off. Lines checked: 30, Warnings: 0, Errors: 1 Please check this out. If you feel there has been an error, please email aconole@redhat.com Thanks, 0-day Robot
On 04.10.23 10:26, jmeng@redhat.com wrote: > From: Jakob Meng <code@jakobmeng.de> > > Fixes: f4336f504b17 ("netdev-dpdk: Add option to configure VF MAC address. ") > --- > vswitchd/vswitch.xml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml > index cfcde34ff..797fb05bf 100644 > --- a/vswitchd/vswitch.xml > +++ b/vswitchd/vswitch.xml > @@ -3805,6 +3805,10 @@ ovs-vsctl add-port br0 p0 -- set Interface p0 type=patch options:peer=p1 \ > Device ID of PCI device. > </column> > > + <column name="status" key="dpdk-vf-mac"> > + Ethernet address set for this VF interface. Only reported for dpdk > + VF representors. > + </column> > </group> > </group> > Signed-off-by: Jakob Meng <code@jakobmeng.de>
On 4 Oct 2023, at 10:26, jmeng@redhat.com wrote: > From: Jakob Meng <code@jakobmeng.de> > > Fixes: f4336f504b17 ("netdev-dpdk: Add option to configure VF MAC address. ") Thank for adding/fixing the documentation. //Eelco Acked-by: Eelco Chaudron <echaudro@redhat.com> > --- > vswitchd/vswitch.xml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml > index cfcde34ff..797fb05bf 100644 > --- a/vswitchd/vswitch.xml > +++ b/vswitchd/vswitch.xml > @@ -3805,6 +3805,10 @@ ovs-vsctl add-port br0 p0 -- set Interface p0 type=patch options:peer=p1 \ > Device ID of PCI device. > </column> > > + <column name="status" key="dpdk-vf-mac"> > + Ethernet address set for this VF interface. Only reported for dpdk > + VF representors. > + </column> > </group> > </group> > > -- > 2.39.2 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 04/10/2023 09:26, jmeng@redhat.com wrote: > From: Jakob Meng <code@jakobmeng.de> > > Fixes: f4336f504b17 ("netdev-dpdk: Add option to configure VF MAC address. ") > --- > vswitchd/vswitch.xml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml > index cfcde34ff..797fb05bf 100644 > --- a/vswitchd/vswitch.xml > +++ b/vswitchd/vswitch.xml > @@ -3805,6 +3805,10 @@ ovs-vsctl add-port br0 p0 -- set Interface p0 type=patch options:peer=p1 \ > Device ID of PCI device. > </column> > > + <column name="status" key="dpdk-vf-mac"> > + Ethernet address set for this VF interface. Only reported for dpdk > + VF representors. > + </column> > </group> > </group> > Acked-by: Kevin Traynor <ktraynor@redhat.com>
diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml index cfcde34ff..797fb05bf 100644 --- a/vswitchd/vswitch.xml +++ b/vswitchd/vswitch.xml @@ -3805,6 +3805,10 @@ ovs-vsctl add-port br0 p0 -- set Interface p0 type=patch options:peer=p1 \ Device ID of PCI device. </column> + <column name="status" key="dpdk-vf-mac"> + Ethernet address set for this VF interface. Only reported for dpdk + VF representors. + </column> </group> </group>
From: Jakob Meng <code@jakobmeng.de> Fixes: f4336f504b17 ("netdev-dpdk: Add option to configure VF MAC address. ") --- vswitchd/vswitch.xml | 4 ++++ 1 file changed, 4 insertions(+)