| Message ID | 20230803142311.2480008-1-i.maximets@ovn.org |
|---|---|
| State | Accepted |
| Commit | 2f34475a9708617eaa484044a5b485980b734b38 |
| Headers | show |
| Series | [ovs-dev] ci: Fix OPTS not being passed to OSX builds. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | fail | github build: failed |
| ovsrobot/intel-ovs-compilation | success | test: success |
On Thu, Aug 3, 2023 at 4:22 PM Ilya Maximets <i.maximets@ovn.org> wrote: > > Before GHA, OPTS were always passed as an argument for a *-build.sh > script. But that changed. Linux builds are using the OPTS variable > from the environment, but OSX script does not, so the options are > currently ignored. > > That wasn't a big issue until now, because SSL was not available or > the build actually worked on newer branches. But GHA recently updated > OpenSSl to 3.0+ and we have deprecation warnings on branches that do nit: OpenSSL > not support OpenSSL 3.0+ (branch 2.16) and that breaks the build. > > Fixes: 6cb2f5a630e3 ("github: Add GitHub Actions workflow.") > Signed-off-by: Ilya Maximets <i.maximets@ovn.org> Reviewed-by: David Marchand <david.marchand@redhat.com>
On 8/4/23 09:12, David Marchand wrote: > On Thu, Aug 3, 2023 at 4:22 PM Ilya Maximets <i.maximets@ovn.org> wrote: >> >> Before GHA, OPTS were always passed as an argument for a *-build.sh >> script. But that changed. Linux builds are using the OPTS variable >> from the environment, but OSX script does not, so the options are >> currently ignored. >> >> That wasn't a big issue until now, because SSL was not available or >> the build actually worked on newer branches. But GHA recently updated >> OpenSSl to 3.0+ and we have deprecation warnings on branches that do > > nit: OpenSSL > >> not support OpenSSL 3.0+ (branch 2.16) and that breaks the build. >> >> Fixes: 6cb2f5a630e3 ("github: Add GitHub Actions workflow.") >> Signed-off-by: Ilya Maximets <i.maximets@ovn.org> > > Reviewed-by: David Marchand <david.marchand@redhat.com> Thanks! I fixed the typo and applied the change to branches down to 2.16. Best regards, Ilya Maximets.
diff --git a/.ci/osx-build.sh b/.ci/osx-build.sh index 09df61826..b81744ec9 100755 --- a/.ci/osx-build.sh +++ b/.ci/osx-build.sh @@ -10,7 +10,7 @@ function configure_ovs() ./boot.sh && ./configure $* } -configure_ovs $EXTRA_OPTS $* +configure_ovs $EXTRA_OPTS $OPTS $* if [ "$CC" = "clang" ]; then make CFLAGS="$CFLAGS -Wno-error=unused-command-line-argument"
Before GHA, OPTS were always passed as an argument for a *-build.sh script. But that changed. Linux builds are using the OPTS variable from the environment, but OSX script does not, so the options are currently ignored. That wasn't a big issue until now, because SSL was not available or the build actually worked on newer branches. But GHA recently updated OpenSSl to 3.0+ and we have deprecation warnings on branches that do not support OpenSSL 3.0+ (branch 2.16) and that breaks the build. Fixes: 6cb2f5a630e3 ("github: Add GitHub Actions workflow.") Signed-off-by: Ilya Maximets <i.maximets@ovn.org> --- .ci/osx-build.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)