From patchwork Tue May 23 03:58:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nobuhiro MIKI X-Patchwork-Id: 1784799 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.137; helo=smtp4.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=yahoo-corp.jp header.i=@yahoo-corp.jp header.a=rsa-sha256 header.s=selector1 header.b=WR1fjSFD; dkim-atps=neutral Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4QQLCr0rQrz20Pb for ; Tue, 23 May 2023 13:59:03 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 8666C417CC; Tue, 23 May 2023 03:59:00 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 8666C417CC Authentication-Results: smtp4.osuosl.org; dkim=fail reason="signature verification failed" (1024-bit key, unprotected) header.d=yahoo-corp.jp header.i=@yahoo-corp.jp header.a=rsa-sha256 header.s=selector1 header.b=WR1fjSFD X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kLO5zMdStagc; Tue, 23 May 2023 03:58:59 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp4.osuosl.org (Postfix) with ESMTPS id 07C5E41800; Tue, 23 May 2023 03:58:57 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 07C5E41800 Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 3AE12C0092; Tue, 23 May 2023 03:58:55 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id AEC55C007C for ; Tue, 23 May 2023 03:58:53 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 5DB6660D88 for ; Tue, 23 May 2023 03:58:53 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 5DB6660D88 Authentication-Results: smtp3.osuosl.org; dkim=pass (1024-bit key, unprotected) header.d=yahoo-corp.jp header.i=@yahoo-corp.jp header.a=rsa-sha256 header.s=selector1 header.b=WR1fjSFD X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id S23ETxCrQYbH for ; Tue, 23 May 2023 03:58:51 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org EF0B360AEC Received: from corp-ob08.yahoo-corp.jp (corp-ob08.yahoo-corp.jp [183.79.94.93]) by smtp3.osuosl.org (Postfix) with ESMTPS id EF0B360AEC for ; Tue, 23 May 2023 03:58:50 +0000 (UTC) Received: from JPN01-OS0-obe.outbound.protection.outlook.com (mail-os0jpn01lp2111.outbound.protection.outlook.com [104.47.23.111]) by corp-ob08.yahoo-corp.jp (Postfix) with ESMTPS id C574D19FB180 for ; Tue, 23 May 2023 12:58:48 +0900 (JST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BTkvxpU+ggP5XsfjI2tn7YZKcB4f0gS8og1QLn9Gfk0YMlQBbaHmRutMysseUANELrx2dMlZ/tdb05WlQwkjBRZ5CJTogagaiDej5rlItOqDaeFbsVASXV61HtSjlA8ML98eWWKg078+bRTWLxVbiYZlvjS+OrYmwwjVcAqcYogRmZU+DQgFccZXFLEpCX3Ak8qQOCIe5VABDsWtuhVkX8TLvLEIRbuQmhazdmJvsp80avWdTXE0ZGV2xpqY0dJGdPT7dMrqeFmC3QfWqWdq7vErw5afmS98Zj0xXaf0SIUZPQe2a7fP1ZmASdaaTmCCe2A9Z4tVDW9xyF1YGCy4QQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Vi33oXrqcc4xqTncU1K1QqgBXlpa2EA++LYxvZkU5U8=; b=gpRa8YU5Bn141ZeSgq8caweI2ORAPtlOKBmQ8FxKX2jsVa9lj/xPXxZ/3ie3SU+n9Hcp+c+v1CffBdqmQUQU4r7VcXOraCuLabD2oAm81YWi4F3TJGXp0XTjaf7piP4IWHNB2D1/kwBf+9UQFE8umBPxBotAS1yd3yxdG3C3sDUgIgKNCV1SPeRhxy3bRcyEoHmGsTmJRX1MRqAIHWxwhPXGBeYF1ROrx2V93vrp8UBBFQv0+6Yg3mfWKLs8YYGhQRwdAjBRyynT7a/9ULVLZech3GZjEiW6JVYAKUZgQ/WIQXR6rGJLIv2zaVl57YSz6QMNUEM8ZyxGKHy6HuGvww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=yahoo-corp.jp; dmarc=pass action=none header.from=yahoo-corp.jp; dkim=pass header.d=yahoo-corp.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo-corp.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vi33oXrqcc4xqTncU1K1QqgBXlpa2EA++LYxvZkU5U8=; b=WR1fjSFD/+ykqC2PbZ38fLj+EdM6yOh/6dTQpuIxmYYFtZC5G963mo58IeIq9KOmwjxv77TO62PyR4LNaPICoOEgrKxqtgug4f21qKWULmae4R1AhP/2mTpKdPc6c9ktnXdZtj1793k7XojopWVgm/4Pt2vIlaiZQlTzuCp3Xq0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=yahoo-corp.jp; Received: from TY2PR01MB4107.jpnprd01.prod.outlook.com (2603:1096:404:d8::23) by TYCPR01MB8803.jpnprd01.prod.outlook.com (2603:1096:400:188::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.29; Tue, 23 May 2023 03:58:47 +0000 Received: from TY2PR01MB4107.jpnprd01.prod.outlook.com ([fe80::6e16:2bc5:f889:3826]) by TY2PR01MB4107.jpnprd01.prod.outlook.com ([fe80::6e16:2bc5:f889:3826%5]) with mapi id 15.20.6411.029; Tue, 23 May 2023 03:58:47 +0000 From: Nobuhiro MIKI To: dev@openvswitch.org Date: Tue, 23 May 2023 12:58:21 +0900 Message-Id: <20230523035823.32640-2-nmiki@yahoo-corp.jp> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230523035823.32640-1-nmiki@yahoo-corp.jp> References: <20230523035823.32640-1-nmiki@yahoo-corp.jp> X-ClientProxiedBy: TYCP301CA0008.JPNP301.PROD.OUTLOOK.COM (2603:1096:400:386::6) To TY2PR01MB4107.jpnprd01.prod.outlook.com (2603:1096:404:d8::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TY2PR01MB4107:EE_|TYCPR01MB8803:EE_ X-MS-Office365-Filtering-Correlation-Id: b757646d-bb7d-4562-41c6-08db5b4202ae X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QJJ0irz3GdGnL7IZSEpJRck5pBq36hZtUmHacpUnuX+wO0ipvzVOociXw0MYOiaLXN1s51AJAysuep+J8mBkezcFZ/37G39130OXYCn/gKGAnW/hGdPO0oHBm9iGx06QWGFwgkQYt0FQyXrzlnVOdpD3G6FKZtm62qOXugW0OEJYKpcHQ5Br7tB/rQcVS/TN8Db+CEULkFX6TOgga9Z8it/mnThVyvCzbAjezELkf/oSvLIRhaUBxMuPWrH9561imfrd6ckdPAk+oMF1IxQCVIB1RZIiNcFlmFV0iziFvK7WFT1oAGf2bEG2aEqNrSop7snQlVcPdS9F+/ydHcm/GKzWknUTUakIuN/sVSABTt2/0cvhx6snGVsoBZnfY0vEwLP2kL6VYP0EBqRUR7GsugoHQ4oTe9wNhsNkhY020FO1JqX4U5KzwJMC3Y3kMWHU9zcOrN+xRk91zwVWpRWIJ117blSGGziDa/Xf5b4CKKIP8sg0XbUWl5tuGeFopsZbiiLR78CYWLIpwtTk69tLlYnJtNpvu2SIAl06IN5vtopyLPbNudnvYHrHu86ItMPpIEMTKRsyO9DUL48rlD0YxXkZ215TIaEp+ebSqONwLT0dhALD9wf4ZLOp24YHAO/2 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TY2PR01MB4107.jpnprd01.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(39860400002)(136003)(396003)(366004)(346002)(376002)(451199021)(5660300002)(8676002)(8936002)(86362001)(1076003)(2906002)(6506007)(26005)(6512007)(36756003)(83380400001)(2616005)(186003)(107886003)(4326008)(66946007)(66556008)(66476007)(6916009)(82960400001)(316002)(478600001)(38100700002)(38350700002)(41300700001)(52116002)(6486002)(6666004); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: zv4CUFniyAYv/fqgW+IkvFJoGTvmJuVhoih6UpsZX/irmbjLzbAk1/1kq7eOQzJLza/z8CAJ59l6SBWz8CA46cF2T0dPEOiBMvwwmmuk94Atutj4ERQidfsYi53O1Ow1393I8oKVfP0qjHsQL+uL8MFMpkKyQHV54CoqDN03PnGu9NEj8WQemYDn9j4pxqoZazaTciAmiqu4CI7e7KndarzVkqCTjDP9++IjJtASpDGLJbJefOpMA8FSv2Wn3H8QZ6f4RPeEeZyRA4VJlYNKtjOX+JfafEDBxw8rPSX+YbDGvrILavFGjeJtdLvuDb9lk4Hx8eOiiP6eaD3TsI9AzynoiHAPl500SAALFbZuTY/p24JNO+hi9waM5HpqX0uA1qZ1vyuf18bjgrPgKlu2SWlSiu7KdMvSCa83TApPC5gcJSi+XDJ2HcfKa8zXlN0NB+g/VTdFtPQ4R4hgA8LuhtCULkys4iJUGKbrU3oOuosMXaWidRfD/2D+bklh1ZknC0XhZ4D8FM0mWH9h1qnT0XdrITC2lTUyywq/i8DSxaZZy8ENaAgo8UNYrFV0l3aW2HdB5q08ww8gqTbUl77LB519Hlct2boCBh/555QooBCU16Oz2aEQ6GWeMKCp1QY5o/dSj9jJW7WpRu0tDoIrLXt+PSdKKzGN8WhvNilhqFmhkCwWhSXiNtlCPh025unCyed0zRtbhgVmi6JltkSDKtG824xOM+n520fXSTtfn38LhoKa7C+Z+4Lc0HMEpIUcpd+h+fDTPXGNPrTkrn+cd+z3283+Fl8MeirYf/Aw+NcdYDJuBwBXC8UFt7+HTUzGl7MqI1PRBuMF78gM6AZs60ggIZzjinqDlWUMVvEi4QJi2PZt+Ggzst4Y18FUyFVR9uEr3NTnjQhRHlU99VNQ50aqJivnJ2EsFf7s8fFB84RFJWhzjYdv/cLp6CJeiSIwTJKnsnn+Yzh8dDx7/VPu+3ercZr6a9xj/O1koaVni1hIUkc3C9a6AAKvW4tVrXJQxpA4KyFY1w3g0SPo9zacfl3/MTHp2Pu9KFh5ezQTsx6PNEaSzPHccNwbDZ5QKOtIgJDHnTGl1Ju6UWdubRCmmWAPiHtHZTGAWluHjDmUkK5XhLJmd543Fwv5n5SFTuJsm34zYzD0My4krHhUNaASVevXslvmba+33vLSEE8Z87XcnH8JMAC898MAaYL5odYz6Lj4hRMsTfPoyGhajYSpgB9gEeNHeiElLs6BUg68YIBAuKNQERyFlCHJA4xi1DAxYzuHDmtOnoHihSXOWs//6PER+dhZ9WXEHwmFJ++QIbQkeh3a850UiOzU/7MF7QihmNoJPdUzeaa7hv1j3YAQN2cSm76MLLtW4T3eW9fMLY+XLg724Kc0YINbQ6X5lZb94DRWuN834i7oBdT01/AVTfhvB1WFBU9UNO1jNcBwkl7inaemrDICgTqAlExMrwbGcYbjhg0CPptIXfTXS9I0I5G7HSjYDlVTm1Q4xpjlAkN/23E/G41u6+mUFt7S5hF587RveZET1qZq68JDIPDAnZkGc/CpAjIinmVA6Y3ppd7KMIdcxuLXqJVLtqfGqhby X-OriginatorOrg: yahoo-corp.jp X-MS-Exchange-CrossTenant-Network-Message-Id: b757646d-bb7d-4562-41c6-08db5b4202ae X-MS-Exchange-CrossTenant-AuthSource: TY2PR01MB4107.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2023 03:58:47.5641 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a208d369-cd4e-4f87-b119-98eaf31df2c3 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pVOzQBPqQVWd9EHLrpHVWl5NPIJBB9fghQmRMO0YR/KSQk0NvY7mlkUoJAE2FznH05lcr2bWbOzcTgJdzm9B0g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYCPR01MB8803 Subject: [ovs-dev] [PATCH v5 1/3] netdev-native-tnl: Add ipv6_label param in netdev_tnl_push_ip_header. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" For tunnels such as SRv6, some popular vendor appliances support IPv6 flowlabel based load balancing. In preparation for OVS to support it, this patch modifies the encapsulation to allow IPv6 flowlabel to be configured. Signed-off-by: Nobuhiro MIKI --- lib/netdev-native-tnl.c | 23 +++++++++++++---------- lib/netdev-native-tnl.h | 4 ++-- lib/packets.c | 2 +- lib/packets.h | 2 ++ 4 files changed, 18 insertions(+), 13 deletions(-) diff --git a/lib/netdev-native-tnl.c b/lib/netdev-native-tnl.c index 9abdf51076a8..db1c4c6d9bfc 100644 --- a/lib/netdev-native-tnl.c +++ b/lib/netdev-native-tnl.c @@ -146,8 +146,8 @@ netdev_tnl_ip_extract_tnl_md(struct dp_packet *packet, struct flow_tnl *tnl, * * Return pointer to the L4 header added to 'packet'. */ void * -netdev_tnl_push_ip_header(struct dp_packet *packet, - const void *header, int size, int *ip_tot_size) +netdev_tnl_push_ip_header(struct dp_packet *packet, const void *header, + int size, int *ip_tot_size, ovs_be32 ipv6_label) { struct eth_header *eth; struct ip_header *ip; @@ -166,6 +166,7 @@ netdev_tnl_push_ip_header(struct dp_packet *packet, ip6 = netdev_tnl_ipv6_hdr(eth); *ip_tot_size -= IPV6_HEADER_LEN; ip6->ip6_plen = htons(*ip_tot_size); + packet_set_ipv6_flow_label(&ip6->ip6_flow, ipv6_label); packet->l4_ofs = dp_packet_size(packet) - *ip_tot_size; return ip6 + 1; } else { @@ -245,7 +246,8 @@ netdev_tnl_push_udp_header(const struct netdev *netdev OVS_UNUSED, struct udp_header *udp; int ip_tot_size; - udp = netdev_tnl_push_ip_header(packet, data->header, data->header_len, &ip_tot_size); + udp = netdev_tnl_push_ip_header(packet, data->header, data->header_len, + &ip_tot_size, 0); /* set udp src port */ udp->udp_src = netdev_tnl_get_src_port(packet); @@ -456,7 +458,8 @@ netdev_gre_push_header(const struct netdev *netdev, struct gre_base_hdr *greh; int ip_tot_size; - greh = netdev_tnl_push_ip_header(packet, data->header, data->header_len, &ip_tot_size); + greh = netdev_tnl_push_ip_header(packet, data->header, data->header_len, + &ip_tot_size, 0); if (greh->flags & htons(GRE_CSUM)) { ovs_be16 *csum_opt = (ovs_be16 *) (greh + 1); @@ -611,8 +614,8 @@ netdev_erspan_push_header(const struct netdev *netdev, struct erspan_md2 *md2; int ip_tot_size; - greh = netdev_tnl_push_ip_header(packet, data->header, - data->header_len, &ip_tot_size); + greh = netdev_tnl_push_ip_header(packet, data->header, data->header_len, + &ip_tot_size, 0); /* update GRE seqno */ tnl_cfg = &dev->tnl_cfg; @@ -793,8 +796,8 @@ netdev_gtpu_push_header(const struct netdev *netdev, unsigned int payload_len; payload_len = dp_packet_size(packet); - udp = netdev_tnl_push_ip_header(packet, data->header, - data->header_len, &ip_tot_size); + udp = netdev_tnl_push_ip_header(packet, data->header, data->header_len, + &ip_tot_size, 0); udp->udp_src = netdev_tnl_get_src_port(packet); udp->udp_len = htons(ip_tot_size); netdev_tnl_calc_udp_csum(udp, packet, ip_tot_size); @@ -921,8 +924,8 @@ netdev_srv6_push_header(const struct netdev *netdev OVS_UNUSED, { int ip_tot_size; - netdev_tnl_push_ip_header(packet, data->header, - data->header_len, &ip_tot_size); + netdev_tnl_push_ip_header(packet, data->header, data->header_len, + &ip_tot_size, 0); } struct dp_packet * diff --git a/lib/netdev-native-tnl.h b/lib/netdev-native-tnl.h index 4dad8f978cc6..3311d796ed85 100644 --- a/lib/netdev-native-tnl.h +++ b/lib/netdev-native-tnl.h @@ -138,8 +138,8 @@ void * netdev_tnl_ip_extract_tnl_md(struct dp_packet *packet, struct flow_tnl *tnl, unsigned int *hlen); void * -netdev_tnl_push_ip_header(struct dp_packet *packet, - const void *header, int size, int *ip_tot_size); +netdev_tnl_push_ip_header(struct dp_packet *packet, const void *header, + int size, int *ip_tot_size, ovs_be32 ipv6_label); void netdev_tnl_egress_port_range(struct unixctl_conn *conn, int argc, const char *argv[], void *aux OVS_UNUSED); diff --git a/lib/packets.c b/lib/packets.c index 06f516cb1af4..7e5a52fd40ed 100644 --- a/lib/packets.c +++ b/lib/packets.c @@ -1274,7 +1274,7 @@ packet_set_ipv6_addr(struct dp_packet *packet, uint8_t proto, pkt_metadata_init_conn(&packet->md); } -static void +void packet_set_ipv6_flow_label(ovs_16aligned_be32 *flow_label, ovs_be32 flow_key) { ovs_be32 old_label = get_16aligned_be32(flow_label); diff --git a/lib/packets.h b/lib/packets.h index 9465bec16c9c..ac4c28e471e6 100644 --- a/lib/packets.h +++ b/lib/packets.h @@ -1622,6 +1622,8 @@ void packet_set_ipv6_addr(struct dp_packet *packet, uint8_t proto, ovs_16aligned_be32 addr[4], const struct in6_addr *new_addr, bool recalculate_csum); +void packet_set_ipv6_flow_label(ovs_16aligned_be32 *flow_label, + ovs_be32 flow_key); void packet_set_tcp_port(struct dp_packet *, ovs_be16 src, ovs_be16 dst); void packet_set_udp_port(struct dp_packet *, ovs_be16 src, ovs_be16 dst); void packet_set_sctp_port(struct dp_packet *, ovs_be16 src, ovs_be16 dst);