| Message ID | 20220929170310.1735511-1-michael.phelan@intel.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev,branch-2.16,v3] dpdk: Use DPDK 20.11.6 release. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
| ovsrobot/intel-ovs-compilation | fail | test: fail |
Bleep bloop. Greetings Michael Phelan, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 102 characters long (recommended limit is 79)
#117 FILE: NEWS:12:
https://patches.dpdk.org/project/dpdk/patch/20220725203206.427083-2-david.marchand@redhat.com/.
Lines checked: 130, Warnings: 1, Errors: 0
Please check this out. If you feel there has been an error, please email aconole@redhat.com
Thanks,
0-day Robot
Hi Michael, On 29/09/2022 18:03, Michael Phelan wrote: > Update OVS CLI and relevant documentation to use DPDK 20.11.6. > > A bug was introduced in DPDK 20.11.5 by the commit > 33f2e3756186 ("vhost: fix unsafe vring addresses modifications"). > This bug can cause a deadlock when vIOMMU is enabled > and NUMA reallocation of the virtqueues happen. > A fix [1] has been posted and pushed to the DPDK 20.11 branch. > If a user wishes to avoid the issue then it is recommended to use > DPDK 20.11.4 until the release of DPDK 20.11.7. > It should be noted that DPDK 20.11.4 does not benefit from > the numerous bug fixes addressed since its release. > If a user wishes to benefit from these fixes it is recommended > to use DPDK 20.11.6. > > [1] https://patches.dpdk.org/project/dpdk/patch/20220725203206.427083-2-david.marchand@redhat.com/ > Signed-off-by: Michael Phelan <michael.phelan@intel.com> > I think it might have been worth to upgrade meson upgrade as a separate commit or mentioned in this one, so it can easily be found in git log. But I don't want to keep nit-picking on these patches, so will Ack as is and let the maintainers decide if they want to split out/add to commit msg. reviewed, ran basic PVP (on v1), ran github actions. Acked-by: Kevin Traynor <ktraynor@redhat.com> thanks, Kevin. > --- > v3: > - Update recommended meson version. > - Refactor commit message. > > v2: > - Update recommended DPDK version for older OvS versions in Documentation. > > --- > --- > .ci/linux-build.sh | 2 +- > .ci/linux-prepare.sh | 2 +- > Documentation/faq/releases.rst | 8 ++++---- > Documentation/intro/install/dpdk.rst | 8 ++++---- > NEWS | 16 ++++++++++++++++ > 5 files changed, 26 insertions(+), 10 deletions(-) > > diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh > index c06e88c57..dd0a57850 100755 > --- a/.ci/linux-build.sh > +++ b/.ci/linux-build.sh > @@ -216,7 +216,7 @@ fi > > if [ "$DPDK" ] || [ "$DPDK_SHARED" ]; then > if [ -z "$DPDK_VER" ]; then > - DPDK_VER="20.11.4" > + DPDK_VER="20.11.6" > fi > install_dpdk $DPDK_VER > if [ "$CC" = "clang" ]; then > diff --git a/.ci/linux-prepare.sh b/.ci/linux-prepare.sh > index 8d0c37d9d..26a4538c6 100755 > --- a/.ci/linux-prepare.sh > +++ b/.ci/linux-prepare.sh > @@ -27,7 +27,7 @@ cd .. > pip3 install --disable-pip-version-check --user wheel > pip3 install --disable-pip-version-check --user \ > flake8 'hacking>=3.0' sphinx pyOpenSSL setuptools > -pip3 install --user 'meson==0.47.1' > +pip3 install --user 'meson==0.48.1' > > if [ "$M32" ]; then > # Installing 32-bit libraries. > diff --git a/Documentation/faq/releases.rst b/Documentation/faq/releases.rst > index d62d575eb..977822984 100644 > --- a/Documentation/faq/releases.rst > +++ b/Documentation/faq/releases.rst > @@ -205,10 +205,10 @@ Q: What DPDK version does each Open vSwitch release work with? > 2.10.x 17.11.10 > 2.11.x 18.11.9 > 2.12.x 18.11.9 > - 2.13.x 19.11.10 > - 2.14.x 19.11.10 > - 2.15.x 20.11.4 > - 2.16.x 20.11.4 > + 2.13.x 19.11.13 > + 2.14.x 19.11.13 > + 2.15.x 20.11.6 > + 2.16.x 20.11.6 > ============ ======== > > Q: Are all the DPDK releases that OVS versions work with maintained? > diff --git a/Documentation/intro/install/dpdk.rst b/Documentation/intro/install/dpdk.rst > index 9ce5285c5..8bc6043f7 100644 > --- a/Documentation/intro/install/dpdk.rst > +++ b/Documentation/intro/install/dpdk.rst > @@ -42,7 +42,7 @@ Build requirements > In addition to the requirements described in :doc:`general`, building Open > vSwitch with DPDK will require the following: > > -- DPDK 20.11.4 > +- DPDK 20.11.6 > > - A `DPDK supported NIC`_ > > @@ -73,9 +73,9 @@ Install DPDK > #. Download the `DPDK sources`_, extract the file and set ``DPDK_DIR``:: > > $ cd /usr/src/ > - $ wget https://fast.dpdk.org/rel/dpdk-20.11.4.tar.xz > - $ tar xf dpdk-20.11.4.tar.xz > - $ export DPDK_DIR=/usr/src/dpdk-stable-20.11.4 > + $ wget https://fast.dpdk.org/rel/dpdk-20.11.6.tar.xz > + $ tar xf dpdk-20.11.6.tar.xz > + $ export DPDK_DIR=/usr/src/dpdk-stable-20.11.6 > $ cd $DPDK_DIR > > #. Configure and install DPDK using Meson > diff --git a/NEWS b/NEWS > index c6b9c2ca8..578b845dd 100644 > --- a/NEWS > +++ b/NEWS > @@ -1,5 +1,21 @@ > v2.16.5 - xx xxx xxxx > --------------------- > + - DPDK: > + * OVS validated with DPDK 20.11.6. > + DPDK 20.11.6 requires a meson version of 0.48.1 or higher. > + A bug was introduced in DPDK 20.11.5 by the commit > + 33f2e3756186 ("vhost: fix unsafe vring addresses modifications"). > + This bug can cause a deadlock when vIOMMU is enabled and NUMA > + reallocation of the virtqueues happen. > + A fix has been posted and pushed to the DPDK 20.11 branch. > + It can be found here: > + https://patches.dpdk.org/project/dpdk/patch/20220725203206.427083-2-david.marchand@redhat.com/. > + If a user wishes to avoid the issue then it is recommended to use > + DPDK 20.11.4 until the release of DPDK 20.11.7. > + It should be noted that DPDK 20.11.4 does not benefit from the numerous > + bug fixes addressed since its release. > + If a user wishes to benefit from these fixes it is recommended to use > + DPDK 20.11.6. > > v2.16.4 - 15 Jun 2022 > ---------------------
> -----Original Message----- > From: Kevin Traynor <ktraynor@redhat.com> > Sent: Friday, September 30, 2022 11:43 AM > To: Phelan, Michael <michael.phelan@intel.com>; dev@openvswitch.org > Cc: Stokes, Ian <ian.stokes@intel.com>; i.maximets@ovn.org; > maxime.coquelin@redhat.com; david.marchand@redhat.com > Subject: Re: [branch-2.16, v3] dpdk: Use DPDK 20.11.6 release. > > Hi Michael, > > On 29/09/2022 18:03, Michael Phelan wrote: > > Update OVS CLI and relevant documentation to use DPDK 20.11.6. > > > > A bug was introduced in DPDK 20.11.5 by the commit > > 33f2e3756186 ("vhost: fix unsafe vring addresses modifications"). > > This bug can cause a deadlock when vIOMMU is enabled > > and NUMA reallocation of the virtqueues happen. > > A fix [1] has been posted and pushed to the DPDK 20.11 branch. > > If a user wishes to avoid the issue then it is recommended to use > > DPDK 20.11.4 until the release of DPDK 20.11.7. > > It should be noted that DPDK 20.11.4 does not benefit from > > the numerous bug fixes addressed since its release. > > If a user wishes to benefit from these fixes it is recommended > > to use DPDK 20.11.6. > > > > [1] https://patches.dpdk.org/project/dpdk/patch/20220725203206.427083-2- > david.marchand@redhat.com/ > > Signed-off-by: Michael Phelan <michael.phelan@intel.com> > > > > I think it might have been worth to upgrade meson upgrade as a separate > commit or mentioned in this one, so it can easily be found in git log. > But I don't want to keep nit-picking on these patches, so will Ack as is > and let the maintainers decide if they want to split out/add to commit msg. > I was happy to keep the change as part of the patch as the DPDK version being updated requires the meson change. > reviewed, ran basic PVP (on v1), ran github actions. > > Acked-by: Kevin Traynor <ktraynor@redhat.com> Thanks for review Kevin, units tests in the Intel CI we were run and passed (were unrelated to the DPDK changes). applied. Thanks Ian > > thanks, > Kevin. > > > --- > > v3: > > - Update recommended meson version. > > - Refactor commit message. > > > > v2: > > - Update recommended DPDK version for older OvS versions in > Documentation. > > > > --- > > --- > > .ci/linux-build.sh | 2 +- > > .ci/linux-prepare.sh | 2 +- > > Documentation/faq/releases.rst | 8 ++++---- > > Documentation/intro/install/dpdk.rst | 8 ++++---- > > NEWS | 16 ++++++++++++++++ > > 5 files changed, 26 insertions(+), 10 deletions(-) > > > > diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh > > index c06e88c57..dd0a57850 100755 > > --- a/.ci/linux-build.sh > > +++ b/.ci/linux-build.sh > > @@ -216,7 +216,7 @@ fi > > > > if [ "$DPDK" ] || [ "$DPDK_SHARED" ]; then > > if [ -z "$DPDK_VER" ]; then > > - DPDK_VER="20.11.4" > > + DPDK_VER="20.11.6" > > fi > > install_dpdk $DPDK_VER > > if [ "$CC" = "clang" ]; then > > diff --git a/.ci/linux-prepare.sh b/.ci/linux-prepare.sh > > index 8d0c37d9d..26a4538c6 100755 > > --- a/.ci/linux-prepare.sh > > +++ b/.ci/linux-prepare.sh > > @@ -27,7 +27,7 @@ cd .. > > pip3 install --disable-pip-version-check --user wheel > > pip3 install --disable-pip-version-check --user \ > > flake8 'hacking>=3.0' sphinx pyOpenSSL setuptools > > -pip3 install --user 'meson==0.47.1' > > +pip3 install --user 'meson==0.48.1' > > > > if [ "$M32" ]; then > > # Installing 32-bit libraries. > > diff --git a/Documentation/faq/releases.rst b/Documentation/faq/releases.rst > > index d62d575eb..977822984 100644 > > --- a/Documentation/faq/releases.rst > > +++ b/Documentation/faq/releases.rst > > @@ -205,10 +205,10 @@ Q: What DPDK version does each Open vSwitch > release work with? > > 2.10.x 17.11.10 > > 2.11.x 18.11.9 > > 2.12.x 18.11.9 > > - 2.13.x 19.11.10 > > - 2.14.x 19.11.10 > > - 2.15.x 20.11.4 > > - 2.16.x 20.11.4 > > + 2.13.x 19.11.13 > > + 2.14.x 19.11.13 > > + 2.15.x 20.11.6 > > + 2.16.x 20.11.6 > > ============ ======== > > > > Q: Are all the DPDK releases that OVS versions work with maintained? > > diff --git a/Documentation/intro/install/dpdk.rst > b/Documentation/intro/install/dpdk.rst > > index 9ce5285c5..8bc6043f7 100644 > > --- a/Documentation/intro/install/dpdk.rst > > +++ b/Documentation/intro/install/dpdk.rst > > @@ -42,7 +42,7 @@ Build requirements > > In addition to the requirements described in :doc:`general`, building Open > > vSwitch with DPDK will require the following: > > > > -- DPDK 20.11.4 > > +- DPDK 20.11.6 > > > > - A `DPDK supported NIC`_ > > > > @@ -73,9 +73,9 @@ Install DPDK > > #. Download the `DPDK sources`_, extract the file and set ``DPDK_DIR``:: > > > > $ cd /usr/src/ > > - $ wget https://fast.dpdk.org/rel/dpdk-20.11.4.tar.xz > > - $ tar xf dpdk-20.11.4.tar.xz > > - $ export DPDK_DIR=/usr/src/dpdk-stable-20.11.4 > > + $ wget https://fast.dpdk.org/rel/dpdk-20.11.6.tar.xz > > + $ tar xf dpdk-20.11.6.tar.xz > > + $ export DPDK_DIR=/usr/src/dpdk-stable-20.11.6 > > $ cd $DPDK_DIR > > > > #. Configure and install DPDK using Meson > > diff --git a/NEWS b/NEWS > > index c6b9c2ca8..578b845dd 100644 > > --- a/NEWS > > +++ b/NEWS > > @@ -1,5 +1,21 @@ > > v2.16.5 - xx xxx xxxx > > --------------------- > > + - DPDK: > > + * OVS validated with DPDK 20.11.6. > > + DPDK 20.11.6 requires a meson version of 0.48.1 or higher. > > + A bug was introduced in DPDK 20.11.5 by the commit > > + 33f2e3756186 ("vhost: fix unsafe vring addresses modifications"). > > + This bug can cause a deadlock when vIOMMU is enabled and NUMA > > + reallocation of the virtqueues happen. > > + A fix has been posted and pushed to the DPDK 20.11 branch. > > + It can be found here: > > + https://patches.dpdk.org/project/dpdk/patch/20220725203206.427083- > 2-david.marchand@redhat.com/. > > + If a user wishes to avoid the issue then it is recommended to use > > + DPDK 20.11.4 until the release of DPDK 20.11.7. > > + It should be noted that DPDK 20.11.4 does not benefit from the numerous > > + bug fixes addressed since its release. > > + If a user wishes to benefit from these fixes it is recommended to use > > + DPDK 20.11.6. > > > > v2.16.4 - 15 Jun 2022 > > ---------------------
diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh index c06e88c57..dd0a57850 100755 --- a/.ci/linux-build.sh +++ b/.ci/linux-build.sh @@ -216,7 +216,7 @@ fi if [ "$DPDK" ] || [ "$DPDK_SHARED" ]; then if [ -z "$DPDK_VER" ]; then - DPDK_VER="20.11.4" + DPDK_VER="20.11.6" fi install_dpdk $DPDK_VER if [ "$CC" = "clang" ]; then diff --git a/.ci/linux-prepare.sh b/.ci/linux-prepare.sh index 8d0c37d9d..26a4538c6 100755 --- a/.ci/linux-prepare.sh +++ b/.ci/linux-prepare.sh @@ -27,7 +27,7 @@ cd .. pip3 install --disable-pip-version-check --user wheel pip3 install --disable-pip-version-check --user \ flake8 'hacking>=3.0' sphinx pyOpenSSL setuptools -pip3 install --user 'meson==0.47.1' +pip3 install --user 'meson==0.48.1' if [ "$M32" ]; then # Installing 32-bit libraries. diff --git a/Documentation/faq/releases.rst b/Documentation/faq/releases.rst index d62d575eb..977822984 100644 --- a/Documentation/faq/releases.rst +++ b/Documentation/faq/releases.rst @@ -205,10 +205,10 @@ Q: What DPDK version does each Open vSwitch release work with? 2.10.x 17.11.10 2.11.x 18.11.9 2.12.x 18.11.9 - 2.13.x 19.11.10 - 2.14.x 19.11.10 - 2.15.x 20.11.4 - 2.16.x 20.11.4 + 2.13.x 19.11.13 + 2.14.x 19.11.13 + 2.15.x 20.11.6 + 2.16.x 20.11.6 ============ ======== Q: Are all the DPDK releases that OVS versions work with maintained? diff --git a/Documentation/intro/install/dpdk.rst b/Documentation/intro/install/dpdk.rst index 9ce5285c5..8bc6043f7 100644 --- a/Documentation/intro/install/dpdk.rst +++ b/Documentation/intro/install/dpdk.rst @@ -42,7 +42,7 @@ Build requirements In addition to the requirements described in :doc:`general`, building Open vSwitch with DPDK will require the following: -- DPDK 20.11.4 +- DPDK 20.11.6 - A `DPDK supported NIC`_ @@ -73,9 +73,9 @@ Install DPDK #. Download the `DPDK sources`_, extract the file and set ``DPDK_DIR``:: $ cd /usr/src/ - $ wget https://fast.dpdk.org/rel/dpdk-20.11.4.tar.xz - $ tar xf dpdk-20.11.4.tar.xz - $ export DPDK_DIR=/usr/src/dpdk-stable-20.11.4 + $ wget https://fast.dpdk.org/rel/dpdk-20.11.6.tar.xz + $ tar xf dpdk-20.11.6.tar.xz + $ export DPDK_DIR=/usr/src/dpdk-stable-20.11.6 $ cd $DPDK_DIR #. Configure and install DPDK using Meson diff --git a/NEWS b/NEWS index c6b9c2ca8..578b845dd 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,21 @@ v2.16.5 - xx xxx xxxx --------------------- + - DPDK: + * OVS validated with DPDK 20.11.6. + DPDK 20.11.6 requires a meson version of 0.48.1 or higher. + A bug was introduced in DPDK 20.11.5 by the commit + 33f2e3756186 ("vhost: fix unsafe vring addresses modifications"). + This bug can cause a deadlock when vIOMMU is enabled and NUMA + reallocation of the virtqueues happen. + A fix has been posted and pushed to the DPDK 20.11 branch. + It can be found here: + https://patches.dpdk.org/project/dpdk/patch/20220725203206.427083-2-david.marchand@redhat.com/. + If a user wishes to avoid the issue then it is recommended to use + DPDK 20.11.4 until the release of DPDK 20.11.7. + It should be noted that DPDK 20.11.4 does not benefit from the numerous + bug fixes addressed since its release. + If a user wishes to benefit from these fixes it is recommended to use + DPDK 20.11.6. v2.16.4 - 15 Jun 2022 ---------------------
Update OVS CLI and relevant documentation to use DPDK 20.11.6. A bug was introduced in DPDK 20.11.5 by the commit 33f2e3756186 ("vhost: fix unsafe vring addresses modifications"). This bug can cause a deadlock when vIOMMU is enabled and NUMA reallocation of the virtqueues happen. A fix [1] has been posted and pushed to the DPDK 20.11 branch. If a user wishes to avoid the issue then it is recommended to use DPDK 20.11.4 until the release of DPDK 20.11.7. It should be noted that DPDK 20.11.4 does not benefit from the numerous bug fixes addressed since its release. If a user wishes to benefit from these fixes it is recommended to use DPDK 20.11.6. [1] https://patches.dpdk.org/project/dpdk/patch/20220725203206.427083-2-david.marchand@redhat.com/ Signed-off-by: Michael Phelan <michael.phelan@intel.com> --- v3: - Update recommended meson version. - Refactor commit message. v2: - Update recommended DPDK version for older OvS versions in Documentation. --- --- .ci/linux-build.sh | 2 +- .ci/linux-prepare.sh | 2 +- Documentation/faq/releases.rst | 8 ++++---- Documentation/intro/install/dpdk.rst | 8 ++++---- NEWS | 16 ++++++++++++++++ 5 files changed, 26 insertions(+), 10 deletions(-)