Message ID | 20220804165211.1459138-1-vladbu@nvidia.com |
---|---|
State | Superseded |
Headers | show
Return-Path: <ovs-dev-bounces@openvswitch.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=oqSG9F2J; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=<UNKNOWN>) Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4LzFCF2txQz9s07 for <incoming@patchwork.ozlabs.org>; Fri, 5 Aug 2022 02:52:40 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id F4140831C1; Thu, 4 Aug 2022 16:52:38 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org F4140831C1 Authentication-Results: smtp1.osuosl.org; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=oqSG9F2J X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CNSxcwieFtgn; Thu, 4 Aug 2022 16:52:38 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTPS id 2376983183; Thu, 4 Aug 2022 16:52:37 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 2376983183 Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id E38C3C0033; Thu, 4 Aug 2022 16:52:36 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 1002BC002D for <dev@openvswitch.org>; Thu, 4 Aug 2022 16:52:35 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id DC7CA40C9F for <dev@openvswitch.org>; Thu, 4 Aug 2022 16:52:34 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org DC7CA40C9F Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=oqSG9F2J X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CnrxhIQ4lkbl for <dev@openvswitch.org>; Thu, 4 Aug 2022 16:52:34 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 0201040217 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41]) by smtp2.osuosl.org (Postfix) with ESMTPS id 0201040217 for <dev@openvswitch.org>; Thu, 4 Aug 2022 16:52:33 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LM7Z8+gcq47GEVt2HCdAA4XKttQ7Ge5NU3vqInsjy8q6Yvc1UcA9i9Xvb1yb2nwXo+TeuBSfzanFc9dx5+hRDU0UxQ9NejRVwyAQGhFGAua6o+TR4C3RkCf8dChMj8T8WQn5Xy6SDQmQyjT++gbogftOuHN+wwpQpN7TDTYg1xHOiFPxP6r6w9v+hLv1/2eyrwAkYiQ3iWw482qzqOGZ4q6X/xj8hvW91agl16E1yMYAhYk17bqBg667dek+Y3Fkzm04Q1nDZ4TwgRMOThcnP7wf8M4IP6j4xIw6nr6JaQL1Mh8tQmbXhfQJm/DKh4hSKR1OPiUvonlQ7CcGx/koCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u3XMX06BPVasgvPm1AejVGoLtCKfztj4MeXlp55UEBc=; b=DH4swab01skTPpflEsOHbwTvI6HSW1XtSci48Z9Y2whyffod5RBSunM74JKRMG688nmJXXd9Og6uAosKDb4BAfIc3eMJYsS9yFdw6CJeX48uGaNgeG0BH1MSAbO4W7BO7yh2edZ4lwowx8fWEXJH8sTZP+6mt5r5AX5j74HJMbOfkQ0wSIOw318LtYcWJT9aHc98KCA+KRqNH82Hqn4pzUV44bEdmZzm0iVT0taPEwuZzEhFQgO5lv22sbd27oG1POwFkIDLsfaS2mxeHk2kd0MD6nNw8N3bjjNWwRw/kON+Wp7Wcif67eakDZvxZUwY/VmLizTISc+ZVWxZ6qxjSw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 203.18.50.15) smtp.rcpttodomain=ovn.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u3XMX06BPVasgvPm1AejVGoLtCKfztj4MeXlp55UEBc=; b=oqSG9F2JhkybL0WKCeibPvRSl3vCALYMkqZcxY4DBbvtHAmYr+JfN+XuWr+SgSnBO7cQDnZWpj+PsNl8cC3BcFWP2+xxnAVNH4gnnZgHe7j2jHxv6R8VOdqSYNsdbwwQ5RPFnfXOWAlRcTY11T9yjLU0rbpnhphpUg7v9h3gsi5/P7m5WcIwSv85lu0NVACqs06e36F3flTEq2oW84MDXtJZbYbUvu2CBqg9pG+ZLBkCDYJUkImFQH8stPFtn3sHxCOsJYpOXTXS2K7aXRQRc6YK5eGiTizx90DfYDHSA8ag4wYJz0U/KYN0IpfsRz8YsrY3g6+Iq08JbBn3VpvKbA== Received: from BN0PR04CA0120.namprd04.prod.outlook.com (2603:10b6:408:ec::35) by CH2PR12MB4645.namprd12.prod.outlook.com (2603:10b6:610:2::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.14; Thu, 4 Aug 2022 16:52:30 +0000 Received: from BN8NAM11FT013.eop-nam11.prod.protection.outlook.com (2603:10b6:408:ec:cafe::62) by BN0PR04CA0120.outlook.office365.com (2603:10b6:408:ec::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.15 via Frontend Transport; Thu, 4 Aug 2022 16:52:30 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 203.18.50.15) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 203.18.50.15 as permitted sender) receiver=protection.outlook.com; client-ip=203.18.50.15; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (203.18.50.15) by BN8NAM11FT013.mail.protection.outlook.com (10.13.176.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.5504.14 via Frontend Transport; Thu, 4 Aug 2022 16:52:29 +0000 Received: from rnnvmail202.nvidia.com (10.129.68.7) by HKMAIL104.nvidia.com (10.18.16.13) with Microsoft SMTP Server (TLS) id 15.0.1497.32; Thu, 4 Aug 2022 16:52:26 +0000 Received: from rnnvmail203.nvidia.com (10.129.68.9) by rnnvmail202.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.26; Thu, 4 Aug 2022 09:52:25 -0700 Received: from vdi.nvidia.com (10.127.8.14) by mail.nvidia.com (10.129.68.9) with Microsoft SMTP Server id 15.2.986.26 via Frontend Transport; Thu, 4 Aug 2022 09:52:22 -0700 To: <dev@openvswitch.org>, <simon.horman@corigine.com>, <echaudro@redhat.com>, <i.maximets@ovn.org> Date: Thu, 4 Aug 2022 18:52:11 +0200 Message-ID: <20220804165211.1459138-1-vladbu@nvidia.com> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c0bf3255-27e2-4f08-b2ab-08da7639b821 X-MS-TrafficTypeDiagnostic: CH2PR12MB4645:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VM9/5COgEpE8BYHz+sR5Q1x5DhRvHisqhGrtiuMIU/tzfJUznpXStiCa+1wq9qPMbdnEop7fa/70ExcxBt7++7IOxXpib19ppA2iCsu+DdQHQ8f3+DtVFMDzLI9kY6XMCC38/zrRWFCQQRgor2xBlWf0DGH2HVFDcKvHhJyNVd/dz2q2pNRWCIDsL+3y0jpeNBV6v8/Vtq7FP8eb0tXaIo+AYvujmczI35Uqyh22tkcvutA/L9pKvx0xE4DR/5ZwcANm4xb1ODVY2gEk6vqMdFsEQcGln9U6lZ2l9m2fPACzd+un3Xwzc97Xw4il4KMn/BU8FqR4BIo5EDSaWxPt6mlSGwYMJSSuWyXpDxi865O85VZjWVECjxTOtUHaO2Rb+Xvkevvr8fr+i/49ZSiSqqE9skRAvkIX8MnS4+J9j78zRxmbGMYgeZwk0DGDlb+QCQ/okqnYYy+YE0VpC51OJkzJS2o56opM4sOZQ7oYTF9BWYhBshmkNkbdTfCwNMUX1KWFfs9jCyQJOHZlWsBUBkTeuOhQ5tQ9/lhbUIhn0aYlDo1xUE8v2dsadg2skD60HtToZjqscrHOvTvHxTPnulZy+CQQdyKaOCfBx19KpYWbWpR4x0A9k9mXkVXXVil13SM0MyIJnJakkAXkgTvGdSZAlroYCH2adYAW7rUzV7SgT8rwhQIE65V5/EmvM8sGEEMQTs6OQCDKmZ78c13+9OKLiDdfB8DAv1pW/K6P3C+xXVjEifEjBcyCvTmFmV+MQ94ZPJOTg/PAFTVRgZ987S4gIGCV15s42A+CfsF/MKUroU4R0pIZlr7gVW1erxMh X-Forefront-Antispam-Report: CIP:203.18.50.15; CTRY:HK; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:hkhybrid04.nvidia.com; CAT:NONE; SFS:(13230016)(4636009)(396003)(39860400002)(136003)(376002)(346002)(36840700001)(46966006)(40470700004)(2616005)(356005)(26005)(86362001)(7696005)(107886003)(7636003)(1076003)(8936002)(478600001)(5660300002)(82310400005)(2906002)(6666004)(41300700001)(40480700001)(36860700001)(336012)(186003)(47076005)(426003)(40460700003)(82740400003)(83380400001)(36756003)(110136005)(316002)(54906003)(4326008)(8676002)(70206006)(70586007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2022 16:52:29.5932 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c0bf3255-27e2-4f08-b2ab-08da7639b821 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[203.18.50.15]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT013.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4645 Cc: jianbol@nvidia.com, yong.xu@corigine.com, Vlad Buslov <vladbu@nvidia.com>, maord@nvidia.com Subject: [ovs-dev] [PATCH 2.17] netdev-linux: set correct action for packets that passed policer X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: <ovs-dev.openvswitch.org> List-Unsubscribe: <https://mail.openvswitch.org/mailman/options/ovs-dev>, <mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe> List-Archive: <http://mail.openvswitch.org/pipermail/ovs-dev/> List-Post: <mailto:ovs-dev@openvswitch.org> List-Help: <mailto:ovs-dev-request@openvswitch.org?subject=help> List-Subscribe: <https://mail.openvswitch.org/mailman/listinfo/ovs-dev>, <mailto:ovs-dev-request@openvswitch.org?subject=subscribe> From: Vlad Buslov via dev <ovs-dev@openvswitch.org> Reply-To: Vlad Buslov <vladbu@nvidia.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" <ovs-dev-bounces@openvswitch.org> |
Series |
[ovs-dev,2.17] netdev-linux: set correct action for packets that passed policer
|
expand
|
Context | Check | Description |
---|---|---|
ovsrobot/apply-robot | fail | apply and check: fail |
ovsrobot/intel-ovs-compilation | fail | test: fail |
diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c index c9cf8c7892f1..067e0175612b 100644 --- a/lib/netdev-linux.c +++ b/lib/netdev-linux.c @@ -2626,7 +2626,7 @@ static void nl_msg_act_police_end_nest(struct ofpbuf *request, size_t offset, size_t act_offset) { - nl_msg_put_u32(request, TCA_POLICE_RESULT, TC_ACT_PIPE); + nl_msg_put_u32(request, TCA_POLICE_RESULT, TC_ACT_UNSPEC); nl_msg_end_nested(request, offset); nl_msg_end_nested(request, act_offset); }
Referenced commit changed policer action type from TC_ACT_UNSPEC (continue) to TC_ACT_PIPE. However, since neither TC hardware offload layer nor mlx5 driver at the time validated action type and always assumed 'continue', the breakage wasn't caught until later validation code was added. The change also broke valid configuration when sending from offload-capable device to non-offload capable. For example, when sending from mlx5 VF to OvS bridge netdevice the traffic that passed matchall classifier with policer could no longer match the following flower rule in software: filter protocol all pref 1 matchall chain 0 filter protocol all pref 1 matchall chain 0 handle 0x1 in_hw (rule hit 7863) action order 1: police 0x1 rate 32Mbit burst 1000Kb mtu 64Kb action drop/pipe overhead 0b ref 1 bind 1 installed 17 sec firstused 17 sec Action statistics: Sent 152199634 bytes 102550 pkt (dropped 1315, overlimits 1315 requeues 0) Sent software 74612172 bytes 51275 pkt Sent hardware 77587462 bytes 51275 pkt backlog 0b 0p requeues 0 used_hw_stats delayed filter protocol ip pref 3 flower chain 0 filter protocol ip pref 3 flower chain 0 handle 0x1 dst_mac aa:94:1f:f2:f8:44 src_mac e4:00:01:08:00:02 eth_type ipv4 ip_flags nofrag not_in_hw action order 1: skbedit ptype host pipe index 1 ref 1 bind 1 installed 6 sec used 6 sec Action statistics: Sent 0 bytes 0 pkt (dropped 0, overlimits 0 requeues 0) backlog 0b 0p requeues 0 action order 2: mirred (Ingress Redirect to device br-ovs) stolen index 1 ref 1 bind 1 installed 6 sec used 6 sec Action statistics: Sent 0 bytes 0 pkt (dropped 0, overlimits 0 requeues 0) backlog 0b 0p requeues 0 cookie 401a9c8b3d403c62240d3eb5e21c1604 no_percpu Fix the issue by restoring policer action type to 'continue'. Fixes: c2567e533f8a ("add port-based ingress policing based packet-per-second rate-limiting") Signed-off-by: Vlad Buslov <vladbu@nvidia.com> --- lib/netdev-linux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)