Message ID | 20220713182807.3416578-6-harry.van.haaren@intel.com |
---|---|
State | Changes Requested |
Headers | show |
Series | Actions Infrastructure + Optimizations | expand |
Context | Check | Description |
---|---|---|
ovsrobot/apply-robot | success | apply and check: success |
ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
ovsrobot/intel-ovs-compilation | success | test: success |
Hi Harry/Amber, > -----Original Message----- > From: Van Haaren, Harry <harry.van.haaren@intel.com> > Sent: Wednesday, July 13, 2022 11:58 PM > To: dev@openvswitch.org > Cc: i.maximets@ovn.org; echaudro@redhat.com; Amber, Kumar > <kumar.amber@intel.com>; Pai G, Sunil <sunil.pai.g@intel.com>; Finn, Emma > <emma.finn@intel.com>; Stokes, Ian <ian.stokes@intel.com>; Van Haaren, > Harry <harry.van.haaren@intel.com> > Subject: [PATCH v10 05/10] acinclude: Add configure option to enable > actions autovalidator at build time. > > From: Kumar Amber <kumar.amber@intel.com> > > This commit adds a new command to allow the user to enable the actions > autovalidator by default at build time thus allowing for running unit test > by default. > > $ ./configure --enable-actions-default-autovalidator > > Signed-off-by: Kumar Amber <kumar.amber@intel.com> > Acked-by: Harry van Haaren <harry.van.haaren@intel.com> > > --- > > v9: > - rebase conflict on NEWS > - fixup missing "dnl" in comment introduced by previous line-wrapping > --- > NEWS | 2 ++ > acinclude.m4 | 20 ++++++++++++++++++++ > configure.ac | 1 + > lib/odp-execute.c | 4 ++++ > 4 files changed, 27 insertions(+) > Based on my comments addressed from V8, I'm happy to ack, Acked-by: Sunil Pai G <sunil.pai.g@intel.com> Thanks and regards Sunil
On 13 Jul 2022, at 20:28, Harry van Haaren wrote: > From: Kumar Amber <kumar.amber@intel.com> > > This commit adds a new command to allow the user to enable the > actions autovalidator by default at build time thus allowing for > running unit test by default. > > $ ./configure --enable-actions-default-autovalidator > > Signed-off-by: Kumar Amber <kumar.amber@intel.com> > Acked-by: Harry van Haaren <harry.van.haaren@intel.com> <SNIP> > index d15f11a4e..84fad425c 100644 > --- a/acinclude.m4 > +++ b/acinclude.m4 > @@ -14,6 +14,26 @@ > # See the License for the specific language governing permissions and > # limitations under the License. > > +dnl Set OVS Actions Autovalidator as the default action implementation > +dnl at compile time This enables automatically running all unit tests Need a dot after "at compile time". > +dnl with all actions implementations. <SNIP> One small change, if this is the only change in the next rev, please add my ACK. //Eelco
diff --git a/NEWS b/NEWS index d02733936..bb03457f6 100644 --- a/NEWS +++ b/NEWS @@ -54,6 +54,8 @@ Post-v2.17.0 implementations against default implementation. * Add command line option to switch between different actions implementations available at run time. + * Add build time configure command to enable auto-validator as default + actions implementation at build time. - Linux datapath: * Add offloading meter tc police. * Add support for offloading the check_pkt_len action. diff --git a/acinclude.m4 b/acinclude.m4 index d15f11a4e..84fad425c 100644 --- a/acinclude.m4 +++ b/acinclude.m4 @@ -14,6 +14,26 @@ # See the License for the specific language governing permissions and # limitations under the License. +dnl Set OVS Actions Autovalidator as the default action implementation +dnl at compile time This enables automatically running all unit tests +dnl with all actions implementations. +AC_DEFUN([OVS_CHECK_ACTIONS_AUTOVALIDATOR], [ + AC_ARG_ENABLE([actions-default-autovalidator], + [AC_HELP_STRING([--enable-actions-default-autovalidator], + [Enable actions autovalidator as default + ovs actions implementation.])], + [autovalidator=yes],[autovalidator=no]) + AC_MSG_CHECKING([whether actions Autovalidator is default implementation]) + if test "$autovalidator" != yes; then + AC_MSG_RESULT([no]) + else + AC_DEFINE([ACTIONS_AUTOVALIDATOR_DEFAULT], [1], + [Autovalidator for actions is a default implementation.]) + AC_MSG_RESULT([yes]) + fi +]) + + dnl Set OVS MFEX Autovalidator as default miniflow extract at compile time? dnl This enables automatically running all unit tests with all MFEX dnl implementations. diff --git a/configure.ac b/configure.ac index 6f8679d7c..6c51e48ce 100644 --- a/configure.ac +++ b/configure.ac @@ -184,6 +184,7 @@ OVS_CONDITIONAL_CC_OPTION([-Wno-unused-parameter], [HAVE_WNO_UNUSED_PARAMETER]) OVS_ENABLE_WERROR_TOP OVS_ENABLE_SPARSE OVS_CTAGS_IDENTIFIERS +OVS_CHECK_ACTIONS_AUTOVALIDATOR OVS_CHECK_DPCLS_AUTOVALIDATOR OVS_CHECK_DPIF_AVX512_DEFAULT OVS_CHECK_MFEX_AUTOVALIDATOR diff --git a/lib/odp-execute.c b/lib/odp-execute.c index d5be190e0..f112f3b48 100644 --- a/lib/odp-execute.c +++ b/lib/odp-execute.c @@ -928,7 +928,11 @@ odp_execute_init(void) static struct ovsthread_once once = OVSTHREAD_ONCE_INITIALIZER; if (ovsthread_once_start(&once)) { odp_execute_action_init(); +#ifdef ACTIONS_AUTOVALIDATOR_DEFAULT + odp_actions_impl_set("autovalidator"); +#else odp_actions_impl_set("scalar"); +#endif odp_execute_unixctl_init(); ovsthread_once_done(&once); }