| Message ID | 20220607103641.1634793-1-harry.van.haaren@intel.com |
|---|---|
| State | Accepted |
| Commit | 751d05b474183e5602ec7dafb44dafe4317a218a |
| Headers | show |
| Series | [ovs-dev,v2] dpcls: add unlisted alias for subtable lookup command | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
| ovsrobot/intel-ovs-compilation | fail | test: fail |
On 7 Jun 2022, at 12:36, Harry van Haaren wrote: > This patch adds the old name "subtable-lookup-prio-get" as an unlisted command, > to restore a consistency between OVS releases for testing scripts. > > Fixes 738c76a503f4 ("dpcls: Change info-get function to fetch dpcls usage stats.") > Suggested-by: Eelco Chaudron <echaudro@redhat.com> > Suggested-by: Ilya Maximets <i.maximets@ovn.org> > Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com> Thanks for the v2, it works as expected :) Acked-by: Eelco Chaudron <echaudro@redhat.com>
On 6/9/22 10:17, Eelco Chaudron wrote: > > > On 7 Jun 2022, at 12:36, Harry van Haaren wrote: > >> This patch adds the old name "subtable-lookup-prio-get" as an unlisted command, >> to restore a consistency between OVS releases for testing scripts. >> >> Fixes 738c76a503f4 ("dpcls: Change info-get function to fetch dpcls usage stats.") There is a missing colon here. Also, the NEWS file update is missing. I added both and applied the patch. Best regards, Ilya Maximets. >> Suggested-by: Eelco Chaudron <echaudro@redhat.com> >> Suggested-by: Ilya Maximets <i.maximets@ovn.org> >> Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com> > > Thanks for the v2, it works as expected :) > > Acked-by: Eelco Chaudron <echaudro@redhat.com>
diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index ff57b3961..f46b9fe18 100644 --- a/lib/dpif-netdev.c +++ b/lib/dpif-netdev.c @@ -1609,6 +1609,9 @@ dpif_netdev_init(void) unixctl_command_register("dpif-netdev/subtable-lookup-info-get", "", 0, 0, dpif_netdev_subtable_lookup_get, NULL); + unixctl_command_register("dpif-netdev/subtable-lookup-prio-get", NULL, + 0, 0, dpif_netdev_subtable_lookup_get, + NULL); unixctl_command_register("dpif-netdev/dpif-impl-set", "dpif_implementation_name", 1, 1, dpif_netdev_impl_set,
This patch adds the old name "subtable-lookup-prio-get" as an unlisted command, to restore a consistency between OVS releases for testing scripts. Fixes 738c76a503f4 ("dpcls: Change info-get function to fetch dpcls usage stats.") Suggested-by: Eelco Chaudron <echaudro@redhat.com> Suggested-by: Ilya Maximets <i.maximets@ovn.org> Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com> --- v2: - Based on discussion and push back on v1 patch here, this is a v2 implementing the suggested "alias" method. Suggested by tags added for both Eelco (for alias concept) and Ilya (for unlisted concept). https://patchwork.ozlabs.org/project/openvswitch/patch/20220525141014.661907-1-harry.van.haaren@intel.com/ --- lib/dpif-netdev.c | 3 +++ 1 file changed, 3 insertions(+)