| Message ID | 2022021512335258445022@chinatelecom.cn |
|---|---|
| State | Accepted |
| Commit | a9f5ee1199e1a944ec58b294f6df58f9031863a8 |
| Headers | show |
| Series | fix dpif backer revalidation | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
On 15 Feb 2022, at 5:33, lic121 wrote: > Currently, ipfix conf creation/deletion don't trigger dpif backer > revalidation. This is not expected, as we need the revalidation > to commit ipfix into xlate. So that xlate can generate ipfix > actions. > > This patch covers only new creation/deletion of ipfix config. > Will upload one more patch to cover ipfix option changes. > > Signed-off-by: lic121 <lic121@chinatelecom.cn> Acked-by: Eelco Chaudron <echaudro@redhat.com> Hoping you will follow up with the full fix later...
On 2/25/22 13:53, Eelco Chaudron wrote: > > > On 15 Feb 2022, at 5:33, lic121 wrote: > >> Currently, ipfix conf creation/deletion don't trigger dpif backer >> revalidation. This is not expected, as we need the revalidation >> to commit ipfix into xlate. So that xlate can generate ipfix >> actions. >> >> This patch covers only new creation/deletion of ipfix config. >> Will upload one more patch to cover ipfix option changes. >> >> Signed-off-by: lic121 <lic121@chinatelecom.cn> > > Acked-by: Eelco Chaudron <echaudro@redhat.com> > > Hoping you will follow up with the full fix later... Thanks! Applied this one patch. Backported down to 2.13. Please, re-send the second one once the conntrack issue is fixed. Best regards, Ilya Maximets.
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c index 8143dd9..ced67b0 100644 --- a/ofproto/ofproto-dpif.c +++ b/ofproto/ofproto-dpif.c @@ -2371,6 +2371,12 @@ set_ipfix( dpif_ipfix_unref(di); ofproto->ipfix = NULL; } + + /* TODO: need to consider ipfix option changes more than + * enable/disable */ + if (new_di || !ofproto->ipfix) { + ofproto->backer->need_revalidate = REV_RECONFIGURE; + } } return 0;
Currently, ipfix conf creation/deletion don't trigger dpif backer revalidation. This is not expected, as we need the revalidation to commit ipfix into xlate. So that xlate can generate ipfix actions. This patch covers only new creation/deletion of ipfix config. Will upload one more patch to cover ipfix option changes. Signed-off-by: lic121 <lic121@chinatelecom.cn> --- ofproto/ofproto-dpif.c | 6 ++++++ 1 file changed, 6 insertions(+) -- 1.8.3.1