| Message ID | 20220109090546.342090-1-sunil.pai.g@intel.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev,v4] acinclude: Provide better error info when linking fails with DPDK. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
On 1/9/22 10:05, Sunil Pai G wrote: > Currently, on failure to link with DPDK, the configure script provides > an error message to update the PKG_CONFIG_PATH even though the cause of > failure was missing dependencies. Improve the error message to include this > scenario. > > Signed-off-by: Sunil Pai G <sunil.pai.g@intel.com> > --- > v3-> v4: Address comments. > v2-> v3: Fix sentence. > v1-> v2: Improve logging instead of printing contents from config.log > --- > acinclude.m4 | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) Applied. Thanks! Best regards, Ilya Maximets.
diff --git a/acinclude.m4 b/acinclude.m4 index dba365ea1..e98aefb95 100644 --- a/acinclude.m4 +++ b/acinclude.m4 @@ -486,9 +486,10 @@ AC_DEFUN([OVS_CHECK_DPDK], [ DPDKLIB_FOUND=true], [AC_MSG_RESULT([no]) AC_MSG_ERROR(m4_normalize([ - Could not find DPDK library in default search path, update - PKG_CONFIG_PATH for pkg-config to find the .pc file in - non-standard location])) + Failed to link with DPDK, check the config.log for more details. + If a working DPDK library was not found in the default search path, + update PKG_CONFIG_PATH for pkg-config to find the .pc file in a + non-standard location.])) ]) CFLAGS="$ovs_save_CFLAGS"
Currently, on failure to link with DPDK, the configure script provides an error message to update the PKG_CONFIG_PATH even though the cause of failure was missing dependencies. Improve the error message to include this scenario. Signed-off-by: Sunil Pai G <sunil.pai.g@intel.com> --- v3-> v4: Address comments. v2-> v3: Fix sentence. v1-> v2: Improve logging instead of printing contents from config.log --- acinclude.m4 | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)