From patchwork Fri May 8 07:18:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Numan Siddique X-Patchwork-Id: 1285893 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.137; helo=fraxinus.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ovn.org Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 49JMBq48TNz9sRf for ; Fri, 8 May 2020 17:18:59 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 4D77C87B3E; Fri, 8 May 2020 07:18:57 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id T6Hk7kVcgt8M; Fri, 8 May 2020 07:18:56 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by fraxinus.osuosl.org (Postfix) with ESMTP id D6F5C87B28; Fri, 8 May 2020 07:18:56 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id BD1ECC0865; Fri, 8 May 2020 07:18:56 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 07E42C07FF for ; Fri, 8 May 2020 07:18:55 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id F35632152E for ; Fri, 8 May 2020 07:18:54 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cQacExQE7u21 for ; Fri, 8 May 2020 07:18:54 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by silver.osuosl.org (Postfix) with ESMTPS id C1BA421515 for ; Fri, 8 May 2020 07:18:53 +0000 (UTC) X-Originating-IP: 115.99.89.246 Received: from nusiddiq.home.org.com (unknown [115.99.89.246]) (Authenticated sender: numans@ovn.org) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id A8DC560006; Fri, 8 May 2020 07:18:49 +0000 (UTC) From: numans@ovn.org To: dev@openvswitch.org Date: Fri, 8 May 2020 12:48:35 +0530 Message-Id: <20200508071835.851174-1-numans@ovn.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Cc: Artem Teleshev Subject: [ovs-dev] [PATCH ovn] Fix typo for validation of logical ip in ipv6 mode. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" From: Artem Teleshev Reported-at: https://github.com/ovn-org/ovn/issues/42 Submitted-at: https://github.com/ovn-org/ovn/pull/43 Signed-off-by: Artem Teleshev Signed-off-by: Numan Siddique --- northd/ovn-northd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c index 83e6134b0..76b4a14ee 100644 --- a/northd/ovn-northd.c +++ b/northd/ovn-northd.c @@ -8845,7 +8845,7 @@ build_lrouter_flows(struct hmap *datapaths, struct hmap *ports, /* Check the validity of nat->logical_ip. 'logical_ip' can * be a subnet when the type is "snat". */ if (is_v6) { - error = ipv6_parse_masked(nat->external_ip, &ipv6, &mask_v6); + error = ipv6_parse_masked(nat->logical_ip, &ipv6, &mask_v6); } else { error = ip_parse_masked(nat->logical_ip, &ip, &mask); }