From patchwork Tue Dec 24 12:53:12 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Numan Siddique X-Patchwork-Id: 1215215 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.133; helo=hemlock.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ovn.org Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 47hx3d5K66z9s4Y for ; Tue, 24 Dec 2019 23:53:33 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id D450D86F8D; Tue, 24 Dec 2019 12:53:31 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jGJHPfZMhGRJ; Tue, 24 Dec 2019 12:53:31 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id 54EEA86EA3; Tue, 24 Dec 2019 12:53:31 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 3BE87C18DD; Tue, 24 Dec 2019 12:53:31 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id D68ADC0881 for ; Tue, 24 Dec 2019 12:53:29 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id C59A586EA3 for ; Tue, 24 Dec 2019 12:53:29 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UtBxUhUZ2ATH for ; Tue, 24 Dec 2019 12:53:28 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by hemlock.osuosl.org (Postfix) with ESMTPS id 87A7B86DE2 for ; Tue, 24 Dec 2019 12:53:28 +0000 (UTC) X-Originating-IP: 115.99.210.97 Received: from nummac.local (unknown [115.99.210.97]) (Authenticated sender: numans@ovn.org) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 49029E000D; Tue, 24 Dec 2019 12:53:24 +0000 (UTC) From: numans@ovn.org To: dev@openvswitch.org Date: Tue, 24 Dec 2019 18:23:12 +0530 Message-Id: <20191224125312.175418-1-numans@ovn.org> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 Subject: [ovs-dev] [PATCH ovn] ovn-controller: Don't monitor connection table columns X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" From: Numan Siddique ovn-controller doesn't need to know any changes to the connection table row. This patch omits alerts for the Connection table columns. In a large scale deployment like 1000 chassis, this can cause lot of CPU cycle wastages as ovsdb-server has to send out updates to all the ovn-controller connections. Signed-off-by: Numan Siddique Acked-by: Dumitru Ceara --- controller/ovn-controller.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/controller/ovn-controller.c b/controller/ovn-controller.c index ad6dff4a2..17744d416 100644 --- a/controller/ovn-controller.c +++ b/controller/ovn-controller.c @@ -1868,7 +1868,6 @@ main(int argc, char *argv[]) ovsdb_idl_omit(ovnsb_idl_loop.idl, &sbrec_sb_global_col_external_ids); ovsdb_idl_omit(ovnsb_idl_loop.idl, &sbrec_logical_flow_col_external_ids); ovsdb_idl_omit(ovnsb_idl_loop.idl, &sbrec_port_binding_col_external_ids); - ovsdb_idl_omit(ovnsb_idl_loop.idl, &sbrec_connection_col_external_ids); ovsdb_idl_omit(ovnsb_idl_loop.idl, &sbrec_ssl_col_external_ids); ovsdb_idl_omit(ovnsb_idl_loop.idl, &sbrec_gateway_chassis_col_external_ids); @@ -1876,6 +1875,18 @@ main(int argc, char *argv[]) ovsdb_idl_omit(ovnsb_idl_loop.idl, &sbrec_ha_chassis_group_col_external_ids); + /* We don't want to monitor Connection table at all. So omit all the + * columns. */ + ovsdb_idl_omit(ovnsb_idl_loop.idl, &sbrec_connection_col_external_ids); + ovsdb_idl_omit(ovnsb_idl_loop.idl, &sbrec_connection_col_inactivity_probe); + ovsdb_idl_omit(ovnsb_idl_loop.idl, &sbrec_connection_col_is_connected); + ovsdb_idl_omit(ovnsb_idl_loop.idl, &sbrec_connection_col_max_backoff); + ovsdb_idl_omit(ovnsb_idl_loop.idl, &sbrec_connection_col_other_config); + ovsdb_idl_omit(ovnsb_idl_loop.idl, &sbrec_connection_col_read_only); + ovsdb_idl_omit(ovnsb_idl_loop.idl, &sbrec_connection_col_role); + ovsdb_idl_omit(ovnsb_idl_loop.idl, &sbrec_connection_col_status); + ovsdb_idl_omit(ovnsb_idl_loop.idl, &sbrec_connection_col_target); + update_sb_monitors(ovnsb_idl_loop.idl, NULL, NULL, NULL); stopwatch_create(CONTROLLER_LOOP_STOPWATCH_NAME, SW_MS);