Message ID | 20181031180208.24924-1-blp@ovn.org |
---|---|
State | Accepted |
Headers | show |
Series | [ovs-dev] contributing: Signed-off-by tags should come last. | expand |
On 10/31/2018 11:02 AM, Ben Pfaff wrote: > Suggested-by: Gregory Rose <gvrose8192@gmail.com> > Signed-off-by: Ben Pfaff <blp@ovn.org> > --- > Documentation/internals/contributing/submitting-patches.rst | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/internals/contributing/submitting-patches.rst b/Documentation/internals/contributing/submitting-patches.rst > index 0ddd24502cc9..1755c8a6691a 100644 > --- a/Documentation/internals/contributing/submitting-patches.rst > +++ b/Documentation/internals/contributing/submitting-patches.rst > @@ -157,6 +157,12 @@ Examples of common tags follow. > If the author and submitter are different, each must sign off. If the patch > has more than one author, all must sign off. > > + Signed-off-by tags should be the last tags in the commit message. If the > + author (or authors) and submitter are different, the author tags should come > + first. More generally, occasionally a patch might pass through a chain of > + submitters, and in such a case the sign-offs should be arranged in > + chronological order. > + > :: > > Signed-off-by: Author Name <author.name@email.address...> Sounds good to me! Reviewed-by: Greg Rose <gvrose8192@gmail.com>
On Wed, Oct 31, 2018 at 11:02:08AM -0700, Ben Pfaff wrote: > Suggested-by: Gregory Rose <gvrose8192@gmail.com> > Signed-off-by: Ben Pfaff <blp@ovn.org> > --- > Documentation/internals/contributing/submitting-patches.rst | 6 ++++++ > 1 file changed, 6 insertions(+) LGTM Acked-by: Flavio Leitner <fbl@sysclose.org> > diff --git a/Documentation/internals/contributing/submitting-patches.rst b/Documentation/internals/contributing/submitting-patches.rst > index 0ddd24502cc9..1755c8a6691a 100644 > --- a/Documentation/internals/contributing/submitting-patches.rst > +++ b/Documentation/internals/contributing/submitting-patches.rst > @@ -157,6 +157,12 @@ Examples of common tags follow. > If the author and submitter are different, each must sign off. If the patch > has more than one author, all must sign off. > > + Signed-off-by tags should be the last tags in the commit message. If the > + author (or authors) and submitter are different, the author tags should come > + first. More generally, occasionally a patch might pass through a chain of > + submitters, and in such a case the sign-offs should be arranged in > + chronological order. > + > :: > > Signed-off-by: Author Name <author.name@email.address...> > -- > 2.16.1 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Wed, Oct 31, 2018 at 03:30:59PM -0300, Flavio Leitner wrote: > On Wed, Oct 31, 2018 at 11:02:08AM -0700, Ben Pfaff wrote: > > Suggested-by: Gregory Rose <gvrose8192@gmail.com> > > Signed-off-by: Ben Pfaff <blp@ovn.org> > > --- > > Documentation/internals/contributing/submitting-patches.rst | 6 ++++++ > > 1 file changed, 6 insertions(+) > > LGTM > Acked-by: Flavio Leitner <fbl@sysclose.org> Thanks Flavio and Greg. I applied this to master.
diff --git a/Documentation/internals/contributing/submitting-patches.rst b/Documentation/internals/contributing/submitting-patches.rst index 0ddd24502cc9..1755c8a6691a 100644 --- a/Documentation/internals/contributing/submitting-patches.rst +++ b/Documentation/internals/contributing/submitting-patches.rst @@ -157,6 +157,12 @@ Examples of common tags follow. If the author and submitter are different, each must sign off. If the patch has more than one author, all must sign off. + Signed-off-by tags should be the last tags in the commit message. If the + author (or authors) and submitter are different, the author tags should come + first. More generally, occasionally a patch might pass through a chain of + submitters, and in such a case the sign-offs should be arranged in + chronological order. + :: Signed-off-by: Author Name <author.name@email.address...>
Suggested-by: Gregory Rose <gvrose8192@gmail.com> Signed-off-by: Ben Pfaff <blp@ovn.org> --- Documentation/internals/contributing/submitting-patches.rst | 6 ++++++ 1 file changed, 6 insertions(+)