| Message ID | 20180504143512.11316-1-mchandras@suse.de |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev] rhel: openvswitch-fedora.spec.in: Drop explicit usermod/groupadd deps | expand |
Markos Chandras <mchandras@suse.de> writes: > These dependencies have been moved from the %post to the %pre scriptlet > in f624bf23b62a ("rhel: user/group openvswitch does not exist") and are > already provided by the shadow-utils package so we can simply drop > them. > > Cc: Alan Pevec <alan.pevec@redhat.com> > Cc: Aaron Conole <aconole@redhat.com> > Signed-off-by: Markos Chandras <mchandras@suse.de> > --- Acked-by: Aaron Conole <aconole@redhat.com>
On Fri, May 04, 2018 at 03:35:12PM +0100, Markos Chandras wrote: > These dependencies have been moved from the %post to the %pre scriptlet > in f624bf23b62a ("rhel: user/group openvswitch does not exist") and are > already provided by the shadow-utils package so we can simply drop > them. > > Cc: Alan Pevec <alan.pevec@redhat.com> > Cc: Aaron Conole <aconole@redhat.com> > Signed-off-by: Markos Chandras <mchandras@suse.de> Thanks Markos and Aaron, I applied this to master. Let me know if you want it backported (and how far).
diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in index 3e5cf21e0..6dbf20ce1 100644 --- a/rhel/openvswitch-fedora.spec.in +++ b/rhel/openvswitch-fedora.spec.in @@ -94,10 +94,6 @@ Requires: openssl hostname iproute module-init-tools Requires(pre): shadow-utils Requires(post): /bin/sed -%if %{with dpdk} -Requires(post): /usr/sbin/usermod -Requires(post): /usr/sbin/groupadd -%endif Requires(post): systemd-units Requires(preun): systemd-units Requires(postun): systemd-units
These dependencies have been moved from the %post to the %pre scriptlet in f624bf23b62a ("rhel: user/group openvswitch does not exist") and are already provided by the shadow-utils package so we can simply drop them. Cc: Alan Pevec <alan.pevec@redhat.com> Cc: Aaron Conole <aconole@redhat.com> Signed-off-by: Markos Chandras <mchandras@suse.de> --- rhel/openvswitch-fedora.spec.in | 4 ---- 1 file changed, 4 deletions(-)