From patchwork Tue Aug 8 21:30:28 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joe Stringer X-Patchwork-Id: 799445 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3xRnd23Vg1z9s5L for ; Wed, 9 Aug 2017 07:30:45 +1000 (AEST) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 7AC03BC3; Tue, 8 Aug 2017 21:30:41 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 4A873941 for ; Tue, 8 Aug 2017 21:30:40 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 224731E5 for ; Tue, 8 Aug 2017 21:30:40 +0000 (UTC) X-Originating-IP: 208.91.1.34 Received: from carno.eng.vmware.com (unknown [208.91.1.34]) (Authenticated sender: joe@ovn.org) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 6A08441C08E for ; Tue, 8 Aug 2017 23:30:38 +0200 (CEST) From: Joe Stringer To: dev@openvswitch.org Date: Tue, 8 Aug 2017 14:30:28 -0700 Message-Id: <20170808213028.16222-1-joe@ovn.org> X-Mailer: git-send-email 2.13.3 Subject: [ovs-dev] [PATCH] include: Add struct declaration to ofp-print.h. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org If a libopenvswitch user includes ofp-print.h before ofp-util.h (which is standard alphabetical order), and turns on -Werror, then they would hit this compilation error in the include: error: 'struct ofputil_port_map' declared inside parameter list will not be visible outside of this definition or declaration [-Werror] void ofp_print(FILE *, const void *, size_t *, const struct ofputil_port_map *, Fixes: 50f96b10e1c8 ("Support accepting and displaying port names in OVS tools.") Signed-off-by: Joe Stringer Acked-by: Ben Pfaff --- include/openvswitch/ofp-print.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/openvswitch/ofp-print.h b/include/openvswitch/ofp-print.h index 20f049a37f65..d02634e3e91c 100644 --- a/include/openvswitch/ofp-print.h +++ b/include/openvswitch/ofp-print.h @@ -29,6 +29,7 @@ struct ofp10_match; struct ofp_flow_mod; struct ofp_header; struct ofputil_flow_stats; +struct ofputil_port_map; struct ofputil_table_features; struct ofputil_table_stats; struct dp_packet;