| Message ID | 20170519091451.14640-1-stephen@that.guru |
|---|---|
| State | Accepted |
| Headers | show |
>-----Original Message----- >From: ovs-dev-bounces@openvswitch.org [mailto:ovs-dev- >bounces@openvswitch.org] On Behalf Of Stephen Finucane >Sent: Friday, May 19, 2017 10:15 AM >To: dev@openvswitch.org >Subject: [ovs-dev] [PATCH] doc: Resolve pep8 warnings in conf.py > >flake8 doesn't like us redefining variables in loops. > >Signed-off-by: Stephen Finucane <stephen@that.guru> >Reported-by: Bhanuprakash Bodireddy ><bhanuprakash.bodireddy@intel.com> >Fixes: f15010f ("doc: Reduce duplication in 'man_pages'") >Cc: Ben Pfaff <blp@ovn.org> >--- > Documentation/conf.py | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/Documentation/conf.py b/Documentation/conf.py index >d70ee6b..77c4df5 100644 >--- a/Documentation/conf.py >+++ b/Documentation/conf.py >@@ -121,6 +121,6 @@ _man_pages = [ > > # Generate list of (path, name, description, [author, ...], section) man_pages >= [ >- ('ref/%s' % filename, filename.split('.', 1)[0], >- description, [author], filename.split('.', 1)[1]) >- for filename, description in _man_pages] >+ ('ref/%s' % file_name, file_name.split('.', 1)[0], >+ description, [author], file_name.split('.', 1)[1]) >+ for file_name, description in _man_pages] Acked by: Bhanuprakash Bodireddy <Bhanuprakash.bodireddy@intel.com>
On Fri, May 19, 2017 at 10:01:19AM +0000, Bodireddy, Bhanuprakash wrote: > >-----Original Message----- > >From: ovs-dev-bounces@openvswitch.org [mailto:ovs-dev- > >bounces@openvswitch.org] On Behalf Of Stephen Finucane > >Sent: Friday, May 19, 2017 10:15 AM > >To: dev@openvswitch.org > >Subject: [ovs-dev] [PATCH] doc: Resolve pep8 warnings in conf.py > > > >flake8 doesn't like us redefining variables in loops. > > > >Signed-off-by: Stephen Finucane <stephen@that.guru> > >Reported-by: Bhanuprakash Bodireddy > ><bhanuprakash.bodireddy@intel.com> > >Fixes: f15010f ("doc: Reduce duplication in 'man_pages'") > >Cc: Ben Pfaff <blp@ovn.org> > >--- > > Documentation/conf.py | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > >diff --git a/Documentation/conf.py b/Documentation/conf.py index > >d70ee6b..77c4df5 100644 > >--- a/Documentation/conf.py > >+++ b/Documentation/conf.py > >@@ -121,6 +121,6 @@ _man_pages = [ > > > > # Generate list of (path, name, description, [author, ...], section) man_pages > >= [ > >- ('ref/%s' % filename, filename.split('.', 1)[0], > >- description, [author], filename.split('.', 1)[1]) > >- for filename, description in _man_pages] > >+ ('ref/%s' % file_name, file_name.split('.', 1)[0], > >+ description, [author], file_name.split('.', 1)[1]) > >+ for file_name, description in _man_pages] > > Acked by: Bhanuprakash Bodireddy <Bhanuprakash.bodireddy@intel.com> Thanks Stephen and Bhanu. I applied this to master.
diff --git a/Documentation/conf.py b/Documentation/conf.py index d70ee6b..77c4df5 100644 --- a/Documentation/conf.py +++ b/Documentation/conf.py @@ -121,6 +121,6 @@ _man_pages = [ # Generate list of (path, name, description, [author, ...], section) man_pages = [ - ('ref/%s' % filename, filename.split('.', 1)[0], - description, [author], filename.split('.', 1)[1]) - for filename, description in _man_pages] + ('ref/%s' % file_name, file_name.split('.', 1)[0], + description, [author], file_name.split('.', 1)[1]) + for file_name, description in _man_pages]
flake8 doesn't like us redefining variables in loops. Signed-off-by: Stephen Finucane <stephen@that.guru> Reported-by: Bhanuprakash Bodireddy <bhanuprakash.bodireddy@intel.com> Fixes: f15010f ("doc: Reduce duplication in 'man_pages'") Cc: Ben Pfaff <blp@ovn.org> --- Documentation/conf.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)