Message ID | 20170223210617.14032-3-russell@ovn.org |
---|---|
State | Rejected |
Headers | show |
On Thu, Feb 23, 2017 at 04:06:17PM -0500, Russell Bryant wrote: > From: Jakub Libosvar <libosvar@redhat.com> > > ovs-ctl script uses hostname. This patch adds dependency for debian > systems. > > Signed-off-by: Jakub Libosvar <libosvar@redhat.com> Thanks a lot for the patch. It's very kind to look out for the Debian packaging. I was pretty surprised to find out that there's a separate package just for the hostname command. Never noticed that before. However, the hostname package is marked "essential" and Debian policy says: Packages are not required to declare any dependencies they have on other packages which are marked `Essential' (see below), and should not do so unless they depend on a particular version of that package.[1] so probably we should not apply this change. Thanks, Ben.
On Wed, Mar 8, 2017 at 8:08 PM, Ben Pfaff <blp@ovn.org> wrote: > On Thu, Feb 23, 2017 at 04:06:17PM -0500, Russell Bryant wrote: >> From: Jakub Libosvar <libosvar@redhat.com> >> >> ovs-ctl script uses hostname. This patch adds dependency for debian >> systems. >> >> Signed-off-by: Jakub Libosvar <libosvar@redhat.com> > > Thanks a lot for the patch. It's very kind to look out for the Debian > packaging. > > I was pretty surprised to find out that there's a separate package just > for the hostname command. Never noticed that before. However, the > hostname package is marked "essential" and Debian policy says: > > Packages are not required to declare any dependencies they have on > other packages which are marked `Essential' (see below), and should > not do so unless they depend on a particular version of that > package.[1] > > so probably we should not apply this change. > > Thanks, > > Ben. Thanks, Ben! This is exactly why even though it looked incredibly trivial, I wanted someone with Debian packaging knowledge to review it. :-)
diff --git a/debian/control b/debian/control index 0b75f2b..25dc9b6 100644 --- a/debian/control +++ b/debian/control @@ -22,7 +22,7 @@ Homepage: http://openvswitch.org/ Package: openvswitch-datapath-source Architecture: all -Depends: bzip2, debhelper (>= 5.0.37), module-assistant, ${misc:Depends} +Depends: bzip2, debhelper (>= 5.0.37), hostname, module-assistant, ${misc:Depends} Suggests: openvswitch-switch Description: Open vSwitch datapath module source - module-assistant version Open vSwitch is a production quality, multilayer, software-based,