diff mbox

[ovs-dev,V2] Fix ovndb_servers master and VirtualIP are not on the same node.

Message ID 20161203073812.21996-1-ligs@dtdream.com
State Accepted
Headers show

Commit Message

Guoshuai Li Dec. 3, 2016, 7:38 a.m. UTC
PCS man page says role=Stopped/Started/Master/Slave.
A role can be master or slave (if no role is specified, it defaults to 'started').

Command line "$pcs constraint colocation add ovndb_servers-master with master VirtualIP"
means that the Started role node of ovsdb follows the master node of VirtualIP.
But we actually want the ovsdb master node to follow the VirtualIP's Started node.
---
 IntegrationGuide.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Babu Shanmugam Dec. 6, 2016, 12:49 p.m. UTC | #1
+ Andrew.

Hi Andrew,

Please see below. Your comments are most welcome.

--

Babu

On Saturday 03 December 2016 01:08 PM, Guoshuai Li wrote:
> PCS man page says role=Stopped/Started/Master/Slave.
> A role can be master or slave (if no role is specified, it defaults to 'started').
>
> Command line "$pcs constraint colocation add ovndb_servers-master with master VirtualIP"
> means that the Started role node of ovsdb follows the master node of VirtualIP.
> But we actually want the ovsdb master node to follow the VirtualIP's Started node.
> ---
>   IntegrationGuide.rst | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/IntegrationGuide.rst b/IntegrationGuide.rst
> index 8c3cca7..1a8e82c 100644
> --- a/IntegrationGuide.rst
> +++ b/IntegrationGuide.rst
> @@ -259,5 +259,5 @@ with the active server.
>   
>       pcs constraint order VirtualIP then ovndb_servers-master
>   
> -    pcs constraint colocation add ovndb_servers-master with master VirtualIP \
> +    pcs constraint colocation add master ovndb_servers-master with VirtualIP \
>           score=INFINITY
Andrew Beekhof Dec. 7, 2016, 1:33 a.m. UTC | #2
Based on the description, the amended constraint looks correct.

On Tue, Dec 6, 2016 at 11:49 PM, Babu Shanmugam <bschanmu@redhat.com> wrote:
> + Andrew.
>
> Hi Andrew,
>
> Please see below. Your comments are most welcome.
>
> --
>
> Babu
>
> On Saturday 03 December 2016 01:08 PM, Guoshuai Li wrote:
>>
>> PCS man page says role=Stopped/Started/Master/Slave.
>> A role can be master or slave (if no role is specified, it defaults to
>> 'started').
>>
>> Command line "$pcs constraint colocation add ovndb_servers-master with
>> master VirtualIP"
>> means that the Started role node of ovsdb follows the master node of
>> VirtualIP.
>> But we actually want the ovsdb master node to follow the VirtualIP's
>> Started node.
>> ---
>>   IntegrationGuide.rst | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/IntegrationGuide.rst b/IntegrationGuide.rst
>> index 8c3cca7..1a8e82c 100644
>> --- a/IntegrationGuide.rst
>> +++ b/IntegrationGuide.rst
>> @@ -259,5 +259,5 @@ with the active server.
>>         pcs constraint order VirtualIP then ovndb_servers-master
>>   -    pcs constraint colocation add ovndb_servers-master with master
>> VirtualIP \
>> +    pcs constraint colocation add master ovndb_servers-master with
>> VirtualIP \
>>           score=INFINITY
>
>
Andy Zhou Dec. 7, 2016, 2:36 a.m. UTC | #3
On Fri, Dec 2, 2016 at 11:38 PM, Guoshuai Li <ligs@dtdream.com> wrote:

> PCS man page says role=Stopped/Started/Master/Slave.
> A role can be master or slave (if no role is specified, it defaults to
> 'started').
>
> Command line "$pcs constraint colocation add ovndb_servers-master with
> master VirtualIP"
> means that the Started role node of ovsdb follows the master node of
> VirtualIP.
> But we actually want the ovsdb master node to follow the VirtualIP's
> Started node.
>

Thanks! Pushed to master.
diff mbox

Patch

diff --git a/IntegrationGuide.rst b/IntegrationGuide.rst
index 8c3cca7..1a8e82c 100644
--- a/IntegrationGuide.rst
+++ b/IntegrationGuide.rst
@@ -259,5 +259,5 @@  with the active server.
 
     pcs constraint order VirtualIP then ovndb_servers-master
 
-    pcs constraint colocation add ovndb_servers-master with master VirtualIP \
+    pcs constraint colocation add master ovndb_servers-master with VirtualIP \
         score=INFINITY